Author Topic: The 10 June 2019 build (11730) is out.  (Read 5871 times)

Offline stahta01

  • Lives here!
  • ****
  • Posts: 6610
    • My Best Post
Re: The 10 June 2019 build (11730) is out.
« Reply #15 on: June 11, 2019, 02:41:20 pm »
Untested patch

Code: [Select]
From 2aeec896382ffafad6a57e08e1adf66b0e4017ad Mon Sep 17 00:00:00 2001
From: Tim Stahlhut <stahta01@gmail.com>
Date: Tue, 11 Jun 2019 08:39:53 -0400
Subject: Change wxCHECK_VERSION guard to 3.1.2

---
 src/sdk/globals.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/sdk/globals.cpp b/src/sdk/globals.cpp
index 5f9198e83..9083cf456 100644
--- a/src/sdk/globals.cpp
+++ b/src/sdk/globals.cpp
@@ -1174,11 +1174,11 @@ double cbGetContentScaleFactor(wxWindow &window)
 // For other platforms the value returned by GetContentScalingFactor seems adequate.
 double cbGetActualContentScaleFactor(wxWindow &window)
 {
-#if wxCHECK_VERSION(3, 1, 0)
+#if wxCHECK_VERSION(3, 1, 2)
     wxDisplay display(wxDisplay::GetFromWindow(&window));
     const wxSize ppi = display.GetPPI();
     return ppi.y / 96.0;
-#else // wxCHECK_VERSION(3, 1, 0)
+#else // wxCHECK_VERSION(3, 1, 2)
     // This code is the simplest version which works in the most common case.
     // If people complain that multi-monitor setups behave strangely, this should be revised with
     // direct calls to GTK/GDK functions.
@@ -1195,7 +1195,7 @@ double cbGetActualContentScaleFactor(wxWindow &window)
     // My guess is that smaller scaling factor would look better. Probably it has effect only in
     // multi monitor setups where there are monitors with different dpi.
     return std::min(ppiX / 96.0, ppiY /96.0);
-#endif // wxCHECK_VERSION(3, 1, 0)
+#endif // wxCHECK_VERSION(3, 1, 2)
 }
 #else // __WXGTK__
 double cbGetActualContentScaleFactor(wxWindow &window)
--

Tim S.
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline trivia21

  • Single posting newcomer
  • *
  • Posts: 7
Re: The 10 June 2019 build (11730) is out.
« Reply #16 on: June 11, 2019, 02:49:26 pm »
Did you apply the change to the guard in globals.cpp before compilation with wx3.1.1?. If yes, can you post the error message?
Sorry, I mean compilation was successful, but I still can't modify key bindings.
« Last Edit: June 11, 2019, 02:59:47 pm by trivia21 »

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5177
Re: The 10 June 2019 build (11730) is out.
« Reply #17 on: June 11, 2019, 08:12:12 pm »
the size has doubled of the zip file, I did not check why.

Because commit 11729 "moved all generated static libs to devel* folders" and update.bat copies them to the output folder. The zip has a lot of *.a files that shouldn't be there.
This is 100% deliberate decision.
The libs must be in the zip file. This would make it possible for third parties to build plugins for cb night builds without the need to build incompatible version of CB. This is the first step. Next steps would be to copy the includes and after that all the stuff related to wxwidgets also needs to be copied.

If some windows dev is interested to do the work I'd be happy to help.
If the size increase is too much we could probably make two separate zip files, but I don't 24mb is unbearable in 2019.

Also if someone wants to move bzip2 in a separate project I'd be happy to help with reviewing. I'm a bit tired of these cbp changes.

indeed, 24 MB , who cares these days.
But on the other hand is there a public out there for this use case ?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11932
    • Travis build status
Re: The 10 June 2019 build (11730) is out.
« Reply #18 on: June 11, 2019, 08:39:07 pm »
I don't know if there are really people which want to do this, but other editors thrive around plugins. C::B is pretty poor in this regard.

There are some plugins which would become easier to build/ship if we're providing proper sdk. Like python plugins, cbsystemview, the fortran stuff could be removed from svn-external and be built easily separately.
Also this would be a preparation for shipping working sdk with the next release.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Xaviou

  • Regular
  • ***
  • Posts: 299
    • X@v's wxStuff
Re: The 10 June 2019 build (11730) is out.
« Reply #19 on: June 12, 2019, 10:55:56 pm »
Hi.

Linux build has been repaired and is working fine with wx-3.0

Rev 11738 for Debian Stretch (32 and 64 bits) can be installed from my repo.

Regards
Xav'
The french wxWidgets site : http://www.wxdev.fr
My wxWidgets's stuff : https://wxstuff.xaviou.fr/

Offline airc

  • Multiple posting newcomer
  • *
  • Posts: 34
Re: The 10 June 2019 build (11730) is out.
« Reply #20 on: June 12, 2019, 11:17:28 pm »
any win32 build ? :)

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2165
Re: The 10 June 2019 build (11730) is out.
« Reply #21 on: June 13, 2019, 04:56:00 pm »
On startup I get warning messages about conflicting key bindings. My custom keybindigs seem to be lost.
So I try to set them up again, but I'm not able to change key bindings in the editor settings. When clicking 'Add' I get the message 'KeyBinding file corrupted. Please delete'. I deleted the keybindig files from the config folder, but I still get the same error.

Ubuntu 18.04, wxWidgets 3.1.2 (in the op there is 3.1.1 but CB uses wxDisplay::GetPPI which was included in 3.1.2 so it didn't compile).

@trivia21
Would you please zip up your CodeBlocks config folder and attach it here so I have something to help debug your cbKeyBinder problem.
Thanks, Pecan

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 2455
Re: The 10 June 2019 build (11730) is out.
« Reply #22 on: June 13, 2019, 11:38:20 pm »
building latest svn on linux with wx28:
Code: [Select]
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I. -I../../../../src/include -I/root/wxInstall/wx28/lib/wx/include/gtk2-unicode-debug-2.8 -I/root/wxInstall/wx28/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D_LARGEFILE_SOURCE=1 -D__WXDEBUG__ -D__WXGTK__ -pthread -I../../../../src/include -I../../../../src/sdk/wxscintilla/include -DCB_AUTOCONF -DCB_PRECOMP -DPIC -I../../../../src/include/tinyxml -DTIXML_USE_STL=YES -Wno-unused-local-typedefs -O2 -ffast-math -Winvalid-pch -fPIC -fexceptions -MT menuutils.lo -MD -MP -MF .deps/menuutils.Tpo -c menuutils.cpp  -fPIC -DPIC -o .libs/menuutils.o
In file included from /root/wxInstall/wx28/include/wx-2.8/wx/defs.h:521:0,
                 from /root/wxInstall/wx28/include/wx-2.8/wx/wxprec.h:13,
                 from menuutils.cpp:18:
menuutils.cpp: In member function ‘virtual void wxMenuShortcutWalker::DeleteData(void*)’:
menuutils.cpp:942:13: error: invalid operands of types ‘const wxChar* {aka const wchar_t*}’ and ‘const wchar_t [56]’ to binary ‘operator+’
             + _T("\nwxMenuShortcutWalker does not use the 'data' parameter") // English for me too.
/root/wxInstall/wx28/include/wx-2.8/wx/debug.h:132:71: note: in definition of macro ‘wxASSERT_MSG’
           wxOnAssert(__TFILE__, __LINE__, __WXFUNCTION__, wxT(#cond), msg)

It seems that we have quite some building problems lately  :) (mea culpa too )

Offline sodev

  • Regular
  • ***
  • Posts: 314
Re: The 10 June 2019 build (11730) is out.
« Reply #23 on: June 14, 2019, 12:48:59 am »
Why do you translate assert messages? This is really nothing that a user should see during normal usage, and if he does, makes google much more easier if it's in english :). And don't use _T() in new code, use the successor wxT().

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2165
Re: The 10 June 2019 build (11730) is out.
« Reply #24 on: June 14, 2019, 07:00:54 am »
Why do you translate assert messages? This is really nothing that a user should see during normal usage, and if he does, makes google much more easier if it's in english :). And don't use _T() in new code, use the successor wxT().

You are most welcome to use what you like. And I will do the same.

Offline sodev

  • Regular
  • ***
  • Posts: 314
Re: The 10 June 2019 build (11730) is out.
« Reply #25 on: June 14, 2019, 05:15:09 pm »

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2165
Re: The 10 June 2019 build (11730) is out.
« Reply #26 on: June 15, 2019, 07:41:15 pm »
On startup I get warning messages about conflicting key bindings. My custom keybindigs seem to be lost.
So I try to set them up again, but I'm not able to change key bindings in the editor settings. When clicking 'Add' I get the message 'KeyBinding file corrupted. Please delete'. I deleted the keybindig files from the config folder, but I still get the same error.

Ubuntu 18.04, wxWidgets 3.1.2 (in the op there is 3.1.1 but CB uses wxDisplay::GetPPI which was included in 3.1.2 so it didn't compile).
Fixed Head rev 11741

Offline Frank_CB

  • Multiple posting newcomer
  • *
  • Posts: 45
Re: The 10 June 2019 build (11730) is out.
« Reply #27 on: June 25, 2019, 10:21:17 pm »
Hello,

I've built a 64-bit version of C::B from SVN 11742 source on Windows 10 using the 11730 build. When I execute it (11742), i get debug asserts.  Images are attached.

The wxWidgets libraries that I'm using are version 3.1.2.  11730 uses version 3.1.1.

Does anyone know if this might be the reason for the asserts?

Regards
« Last Edit: June 25, 2019, 11:28:18 pm by Frank_CB »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11932
    • Travis build status
Re: The 10 June 2019 build (11730) is out.
« Reply #28 on: June 26, 2019, 12:23:35 am »
Frank_CB: Can you run CB with a debugger and when an assert happens to press the stop button? Then post the backtrace/callstack. These error messages aren't really helpful without a callstack or a way to reproduce.

Note1: Please make sure that you're running the correct update.bat script after you've built CB from CB.
Note2: 3.1.2 has some bugs that affected CB badly, probably you're better of using wx-master.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Frank_CB

  • Multiple posting newcomer
  • *
  • Posts: 45
Re: The 10 June 2019 build (11730) is out.
« Reply #29 on: June 26, 2019, 02:44:51 am »
@oBFusCATed Thanks for responding!  I'm curious as to what is causing the asserts. Since these only just occur when C::B's IDE is opening, I can't visualize how it couuld be debugged. I'll just continue ignoring them. Hopefully, they aren't problematic? You referenced wx-master - what is it and how can I acquire that?

Regards