Author Topic: Keyboard shortcut and C::B translation problem  (Read 989 times)

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2150
Re: Keyboard shortcut and C::B translation problem
« Reply #15 on: June 15, 2019, 01:32:04 am »
I don't like that Next call tip will be ctrl-n and prev call tip would be ctrl-shift-p. I'd rather change both. Or just remove the shortcuts. I didn't know these existed, I'm using up and down arrows, they work just fine, not sure what is the benefit of using the shortcuts.

Ok, just get rid of them if nobody else objects. I've never used them myself.
It's also probable that nobody else uses them either, since there's been no complaints that they don't work.
« Last Edit: June 15, 2019, 01:36:48 am by Pecan »

Offline gd_on

  • Regular
  • ***
  • Posts: 456
Re: Keyboard shortcut and C::B translation problem
« Reply #16 on: June 15, 2019, 02:41:40 pm »
In menuutils.cpp, line 940 and 941 there is the same string. The extracting tool using xgettext see these two lines as only one, with twice the same string proposed for translation and separated by a \n. In this case, in a wxASSERT, I suppose that only the english string is needed, not the translated one. May be a better code could be :
Code: [Select]
    wxASSERT_MSG(data == NULL,
                wxT("wxMenuShortcutWalker does not use the 'data' parameter") // English only.
        );

and keep wxT (or _T) to be wx 2.8 compatible.

gd_on
Windows 10 or 7, svn C::B (last version or almost!), WxWidgets 2.8.12, Compilers TDM 4.9.2 32 bits (gcc and gfortran installed in C:\MinGW32). Tests with C::B 64 bits and WxWidgets 2.8.12 or 3.1.2 (64 bits) compiled by TDM 4.9.2 or Std 8.1 in C:\MinGW64

Offline Pecan

  • Plugin developer
  • Lives here!
  • ****
  • Posts: 2150
Re: Keyboard shortcut and C::B translation problem
« Reply #17 on: June 15, 2019, 08:41:24 pm »
In menuutils.cpp, line 940 and 941 there is the same string. The extracting tool using xgettext see these two lines as only one, with twice the same string proposed for translation and separated by a \n. In this case, in a wxASSERT, I suppose that only the english string is needed, not the translated one. May be a better code could be :
Code: [Select]
    wxASSERT_MSG(data == NULL,
                wxT("wxMenuShortcutWalker does not use the 'data' parameter") // English only.
        );

and keep wxT (or _T) to be wx 2.8 compatible.

gd_on
Fixed head rev 11742