Author Topic: Keyboard shortcuts disabled for alternate layouts  (Read 1817 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11827
    • Travis build status
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #15 on: March 24, 2019, 03:37:34 pm »
OK, I'll try to log the issue on your behalf...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11827
    • Travis build status
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #16 on: March 24, 2019, 05:21:45 pm »
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline hidefromkgb

  • Multiple posting newcomer
  • *
  • Posts: 40
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #17 on: April 22, 2019, 12:33:53 am »
Heads up, I`ve got news!

This is where the error seems to happen:

Code: C++
  1. int  ScintillaWX::DoKeyDown(const wxKeyEvent& evt, bool* consumed)
  2. {
  3.     int key = evt.GetKeyCode();
  4.     if (key == WXK_NONE) {
  5.         // This is a Unicode character not representable in Latin-1 or some key
  6.         // without key code at all (e.g. dead key or VK_PROCESSKEY under MSW).
  7.         if ( consumed )
  8.             *consumed = false;
  9.         return 0;
  10.     }
  11.  
  12.     ...

WxWidgets Scintilla implementation processes shortcuts not by the keyboard scancode as it needs to be, but by the actual character typed!
Do you guys know how to retrieve scancodes from a wxKeyEvent ?

Offline hidefromkgb

  • Multiple posting newcomer
  • *
  • Posts: 40
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #18 on: April 22, 2019, 12:47:10 am »
Update: found it! It`s called wxKeyEvent::GetRawKeyCode(), but its results are platform dependent. Okay that`s fine, I`ve already collected the scancode tables for Windows, Linux and MacOS =)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11827
    • Travis build status
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #19 on: April 22, 2019, 01:10:14 am »
Please post any of these in the wx's trac...
Here they would get lost...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline hidefromkgb

  • Multiple posting newcomer
  • *
  • Posts: 40
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #20 on: April 22, 2019, 01:12:26 am »
Can I just post a .DIFF patch to wxTRAC?
Something tells me I`m capable of fixing that problem all by myself.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11827
    • Travis build status
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #21 on: April 22, 2019, 08:36:43 am »
Yes, you can.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline hidefromkgb

  • Multiple posting newcomer
  • *
  • Posts: 40
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #22 on: April 22, 2019, 06:00:47 pm »
Done! PR #1305.

Offline hidefromkgb

  • Multiple posting newcomer
  • *
  • Posts: 40
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #23 on: April 27, 2019, 02:15:44 pm »
…Guys, would it be too much if I asked you to apply that patch to C::B ahead of the WXW trunk?
Granted, I can just take the source and do that myself, but it`d be way cool if that bugfix made it to C::B, for I doubt I`m the only one experiencing that problem.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11827
    • Travis build status
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #24 on: April 27, 2019, 04:34:44 pm »
I'm hesitant to do it, because syncing the source is already hard and applying this patch it will make it harder.
I guess New Pagodi could help test the patch?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline hidefromkgb

  • Multiple posting newcomer
  • *
  • Posts: 40

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11827
    • Travis build status
Re: Keyboard shortcuts disabled for alternate layouts
« Reply #26 on: May 24, 2019, 08:14:12 pm »
I'll pick the change next time I update wxscintilla...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]