Author Topic: wxWidgets 3.1.2 Released  (Read 5835 times)

Offline gd_on

  • Regular
  • ***
  • Posts: 458
Re: wxWidgets 3.1.2 Released
« Reply #45 on: January 17, 2019, 05:41:25 pm »
Thanks M. Gimenez. No more problem (until the next one  ;D) with your temporary patch  ;).
gd_on
Windows 10 or 7, svn C::B (last version or almost!), WxWidgets 2.8.12, Compilers TDM 4.9.2 32 bits (gcc and gfortran installed in C:\MinGW32). Tests with C::B 64 bits and WxWidgets 2.8.12 or 3.1.2 (64 bits) compiled by TDM 4.9.2 or Std 8.1 in C:\MinGW64

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 303
Re: wxWidgets 3.1.2 Released
« Reply #46 on: January 28, 2019, 11:25:31 am »
First we wait for the changes to enter wx-master. Then we'll decide what course of action we'll take for night/release binaries. I don't think waiting for wx3.1.3 is viable option. wx releases are very infrequent.

New Pagodi's changes to wxPopupWindow have been commited today:

https://github.com/wxWidgets/wxWidgets/commit/07f64c3b75c79b79b46a7e8ac8db585a618c57da

EDIT: I have just compiled C::B revision 11558 with this commit in MSW, the issues with Code Completion are gone.
« Last Edit: January 28, 2019, 02:41:21 pm by Miguel Gimenez »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11829
    • Travis build status
Re: wxWidgets 3.1.2 Released
« Reply #47 on: January 28, 2019, 07:45:12 pm »
Would it be possible to create a patch only containing this change against 3.1.2 and see if everything works fine.

@killerbot: Are you willing to use a patched version of 3.1.2 for the night builds?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 303
Re: wxWidgets 3.1.2 Released
« Reply #48 on: January 28, 2019, 08:44:58 pm »
I have patched my wx3.1.2 library with New Pagodi´s changes and Code Completion works fine.

I have generated a diff file, but I don't know if it can be applied without some tweaking (indexes probably are invalid).

Just in case I am attaching also the affected files (including the interface one, although it is not needed).

Offline gd_on

  • Regular
  • ***
  • Posts: 458
Re: wxWidgets 3.1.2 Released
« Reply #49 on: January 29, 2019, 08:54:52 am »
Does this new wxPopupWindow patch is cumulative with the precedent one (declared as temporary on january 16) or should we start from the original version ?
Windows 10 or 7, svn C::B (last version or almost!), WxWidgets 2.8.12, Compilers TDM 4.9.2 32 bits (gcc and gfortran installed in C:\MinGW32). Tests with C::B 64 bits and WxWidgets 2.8.12 or 3.1.2 (64 bits) compiled by TDM 4.9.2 or Std 8.1 in C:\MinGW64

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 303
Re: wxWidgets 3.1.2 Released
« Reply #50 on: January 29, 2019, 09:29:13 am »
If wxWidgets is patched then the temporary patch should be removed, because it hides the library's wxPopupWindow.

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5221
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: wxWidgets 3.1.2 Released
« Reply #51 on: January 29, 2019, 04:29:40 pm »
I have patched my wx3.1.2 library with New Pagodi´s changes and Code Completion works fine.

I have generated a diff file, but I don't know if it can be applied without some tweaking (indexes probably are invalid).

Just in case I am attaching also the affected files (including the interface one, although it is not needed).
Nice work, I just tested it, and it works fine!
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 303
Re: wxWidgets 3.1.2 Released
« Reply #52 on: January 29, 2019, 05:04:33 pm »
If devs choose patching wxWidgets 3.1.2 to solve CC crashes I suggest adding this code (or similar) somewhere so people compiling from SVN in MSW with 3.1.2 know what to do.

Code: [Select]
#if wxUSE_POPUPWIN && defined(__WXMSW__) && wxVERSION_NUMBER == 3102
    #include "wx/popupwin.h"
    #ifndef wxPU_CONTAINS_CONTROLS
        #error wxWidgets 3.1.2 must be patched or CC will crash
    #endif
#endif