Author Topic: User interface for project glob feature  (Read 1655 times)

Online BlueHazzard

  • Lives here!
  • ****
  • Posts: 1973
Re: User interface for project glob feature
« Reply #30 on: September 07, 2018, 12:09:43 am »
1. The manage dialog shouldn't call Manager::Get()->GetProjectManager()->GetActiveProject(), but a project pointer should be passed to the constructor. This would make it possible to add this manage command to the context menu
2. Adding a relative path to the current project makes the path look like ../myproj instead of just '.'.
i can try to fix this.
3. The ok/cancel buttons in the manage dialog must be moved at the bottom using a stdbuttonsizer. The current version looks bad.
i am really bad with UI things... I would like to let this to some one else

Here are some fixes on top of yours:
What is this with the tabs change in the code? Do you use fewer white spaces?

in src/src/manageglobsdlg.cpp
Code: [Select]
for (const cbProject::Glob &glob : m_GlobList)full c++11 support now? also with "auto"?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11047
    • Travis build status
Re: User interface for project glob feature
« Reply #31 on: September 07, 2018, 12:50:33 am »
The files used tabs, CB project uses 4 spaces. We're c++11 for quite a while now.
I don't understand why c++11 is associated with auto. The second worst feature added after rvalue refs and lambdas are third.
Generally it is preferable (at least by me) if auto is used as little as possible and only where the types are obvious or too long.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]