Author Topic: Newer tar causes make dist to fail  (Read 321 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11047
    • Travis build status
Newer tar causes make dist to fail
« on: August 16, 2018, 01:28:57 am »
I'm getting this error:
Code: [Select]
tardir=codeblocks-17.12svn11451 && /bin/sh /home/obfuscated/projects/codeblocks/temp_svn/missing --run tar chf - "$tardir" --exclude=".svn" | bzip2 -9 -c >codeblocks-17.12svn11451.tar.bz2
tar: The following options were used after any non-optional arguments in archive create or update mode.  These options are positional and affect only arguments that follow them.  Please, rearrange them properly.
tar: --exclude ‘.svn’ has no effect
tar: Exiting with failure status due to previous errors
tar: The following options were used after any non-optional arguments in archive create or update mode.  These options are positional and affect only arguments that follow them.  Please, rearrange them properly.
tar: --exclude ‘.svn’ has no effect
tar: Exiting with failure status due to previous errors
WARNING: I can't seem to be able to run `tar' with the given arguments.
         You may want to install GNU tar or Free paxutils, or check the
         command line arguments.
{ test ! -d codeblocks-17.12svn11451 || { find codeblocks-17.12svn11451 -type d ! -perm -200 -exec chmod u+w {} ';' && rm -fr codeblocks-17.12svn11451; }; }

It seems that it is cause by a newer version of tar (1.30 or 1.29) which is more strict with its parameters.

If I remove this line
Code: [Select]
am__tar = @am__tar@ $(ADDITIONAL_MAKE_DIST_OPTIONS)
from Makefile.am it works and it seems there aren't bad files in the created archive.
Do you think this is a safe change?

(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11047
    • Travis build status
Re: Newer tar causes make dist to fail
« Reply #1 on: September 10, 2018, 08:28:03 pm »
Ping?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline sodev

  • Almost regular
  • **
  • Posts: 163
Re: Newer tar causes make dist to fail
« Reply #2 on: September 10, 2018, 09:10:16 pm »
Pong!

This depends on if codeblocks-17.12svn11451 is the root directory of your working copy or not. Non-ancient svn clients put the .svn directory only in the root directory, from the command line it looks like you are tar-ing a subdirectory, so you should be fine without the exclude.

But if you remove that line, you should remove the second line below this as well, because it suffers from the same problem. But then you break that KEEP_DLLS feature, which technically is already broken :).

Actually it is a good idea to remove that whole am__tar replacement stuff, because according to my tar.m4 file this might not even call tar but something else, although i don't know under what obscure conditions that might happen. My understanding of Automake Magic is ... quite limited, zero is a valid limit :D.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11047
    • Travis build status
Re: Newer tar causes make dist to fail
« Reply #3 on: September 11, 2018, 03:41:06 pm »
OK, I've so used to now do build in my checkout dir that I forgot for this case. I'll test and I'll see what happens.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]