Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development
wxSmith and the Style woes of the future.
ouch:
The new trunk version of wxWidgets is changing border style names. I know it's not a release version yet but it's been a pain to work with in the editor so I've attached a patch to fix it for those who are using the trunk version of wxwidgets.
For patches fixing version issues should we use an ifdef wall or are you directly comparing the wxwidgets version in a variable someplace?
ollydbg:
Good work!
Hope some wxSmith export would give some advice. ;)
wxSmith should know which wx version does the generated code link to.
stahta01:
--- Quote from: ollydbg on July 28, 2018, 05:20:17 pm ---Good work!
Hope some wxSmith export would give some advice. ;)
wxSmith should know which wx version does the generated code link to.
--- End quote ---
Assuming it only changes to wxBORDER_* it should work with 2.8.12 which has those defines in wx/defs.h
Tim S.
oBFusCATed:
--- Quote from: ouch on July 28, 2018, 02:55:43 pm ---For patches fixing version issues should we use an ifdef wall or are you directly comparing the wxwidgets version in a variable someplace?
--- End quote ---
At the moment wxSmith needs to be able to generate valid wx2.8.12 code. C::B uses it and we're still building for wx2.8.
The best option is to generate something that is available in both versions. If not wxCHECK_VERSION macros should be generated.
How do I test this patch if it generates correct code?
ouch:
If 2.8 has the new styles defined then it should work regardless right?
And if that is the case why not change all of them across the entire codeblocks file structure.
This patch does just that. It was done with a program that does blind search and replace. I have went through it and removed nonsense things like log and readme changes.
But this should in theory work on all versions of wxWidgets >= 2.8.
Navigation
[0] Message Index
[#] Next page
Go to full version