Author Topic: Problem with icons on HiDPI displays  (Read 6250 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #45 on: April 08, 2019, 07:46:54 pm »
The proper fix for this is to use wxChoice...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 281
Re: Problem with icons on HiDPI displays
« Reply #46 on: April 09, 2019, 11:43:05 am »
Quote
The proper fix for this is to use wxChoice...

OK, this patch changes wxComboBox to wxChoice

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #47 on: April 10, 2019, 08:51:54 am »
Thanks, I'll apply in the next days...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #48 on: May 03, 2019, 05:07:44 pm »
All sizes up to 64x64 have been added. 22x22 have been removed.
Testing and reporting any problems is welcome...  8)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 281
Re: Problem with icons on HiDPI displays
« Reply #49 on: May 03, 2019, 07:19:02 pm »
In update.bat resources.zip includes src\resources\images\12x12\*.png, this folder does not exist.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #50 on: May 04, 2019, 01:13:14 pm »
@darmar:
I've made a simple script to gather all sizes in a single image, so I can compare images and see if there are problems.
An example output images could be seen here: http://cmpt.benbmp.org/codeblocks/images/
From the images it is obvious that size 40x40 is not right. It needs to be lighter. Now it looks bolder/darker than both 32x32 and 48x48 or bigger. And the jump from 32x32 is very abrupt.

This script also finds mismatches between image names. There are some.

If you're interested in the script I can make a pull request against your repo.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 2361
Re: Problem with icons on HiDPI displays
« Reply #51 on: May 07, 2019, 08:20:00 pm »
We probably need all this for the wxSmith plugin too?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #52 on: May 07, 2019, 08:39:49 pm »
Yes, I'll get to it, but first I need to handle other more important icons. If you're interested to do the work for wxSmith I won't mind :)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 281
Re: Problem with icons on HiDPI displays
« Reply #53 on: May 08, 2019, 04:10:14 pm »
This morning i got an alert probably related to these HiDPI changes. When trying to rename a symbol using Code Refactoring a wxWdgets alert pops up indicating invalid bitmap.

The error is in line 74 of coderefactoring.cpp, the specified file (share\CodeBlocks\images\32x32\filefind.png) does not exist.

EDIT: found the same problem in three more files, proposed patch is attached

EDIT 2: created ticket 826, https://sourceforge.net/p/codeblocks/tickets/826/
« Last Edit: May 10, 2019, 09:14:19 am by Miguel Gimenez »

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 2361
Re: Problem with icons on HiDPI displays
« Reply #54 on: May 08, 2019, 06:08:00 pm »
I have a similar problem for all wxSmith icons... Still have to figure out what is going on...
I have deleted all output and devel folders and now i get this error message for all wxSmith icons..

It is working now... probably some mismatch with compiler options
« Last Edit: May 08, 2019, 06:39:06 pm by BlueHazzard »

Offline Miguel Gimenez

  • Regular
  • ***
  • Posts: 281
Re: Problem with icons on HiDPI displays
« Reply #55 on: May 09, 2019, 11:56:38 am »
The folder src\src\resources\images\22x22 is empty and can be removed, because 22x22 images are no longer used.

There are still references to 22x22 images, notably in XRC files and in ThreadSearch\update31

Code: [Select]
G:\Codeblocks312\src\plugins\compilergcc\resources\compiler_toolbar.xrc|7|<bitmap>images/22x22/compile.png</bitmap>|
G:\Codeblocks312\src\plugins\compilergcc\resources\compiler_toolbar.xrc|12|<bitmap>images/22x22/run.png</bitmap>|
G:\Codeblocks312\src\plugins\compilergcc\resources\compiler_toolbar.xrc|17|<bitmap>images/22x22/compilerun.png</bitmap>|
G:\Codeblocks312\src\plugins\compilergcc\resources\compiler_toolbar.xrc|22|<bitmap>images/22x22/rebuild.png</bitmap>|
G:\Codeblocks312\src\plugins\compilergcc\resources\compiler_toolbar.xrc|27|<bitmap>images/22x22/stop.png</bitmap>|
G:\Codeblocks312\src\plugins\compilergcc\resources\compiler_toolbar.xrc|39|<bitmap>images/22x22/select_target.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\BrowseTracker\BrowseTrackerToolbar.xrc|7|<bitmap>images/22x22/prev.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\BrowseTracker\BrowseTrackerToolbar.xrc|12|<bitmap>images/22x22/next.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\BrowseTracker\BrowseTrackerToolbar.xrc|18|<bitmap>images/22x22/mark.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\BrowseTracker\BrowseTrackerToolbar.xrc|23|<bitmap>images/22x22/mark_prev.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\BrowseTracker\BrowseTrackerToolbar.xrc|28|<bitmap>images/22x22/mark_next.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\BrowseTracker\BrowseTrackerToolbar.xrc|33|<bitmap>images/22x22/mark_clear.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\FortranProject\fortranproject.cpp|1128|tbSStr = _T("_22x22");|
G:\Codeblocks312\src\plugins\contrib\FortranProject\fpimagelist.cpp|20|prefix2 = ConfigManager::GetDataFolder() + _T("/images/fortranproject/22x22/");|
G:\Codeblocks312\src\plugins\contrib\FortranProject\resources\fortranprojecttoolbar.xrc|21|<object class="wxToolBarAddOn" name="fortran_project_toolbar_22x22">|
G:\Codeblocks312\src\plugins\contrib\FortranProject\resources\fortranprojecttoolbar.xrc|25|<bitmap>images/22x22/fprojectjumpback.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\FortranProject\resources\fortranprojecttoolbar.xrc|30|<bitmap>images/22x22/fprojectjumphome.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\FortranProject\resources\fortranprojecttoolbar.xrc|35|<bitmap>images/22x22/fprojectjumpforward.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|8|<bitmap>images/22x22/incsearchclear.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|14|<bitmap>images/22x22/incsearchprev.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|19|<bitmap>images/22x22/incsearchnext.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|24|<bitmap>images/22x22/incsearchhighlight.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|30|<bitmap>images/22x22/incsearchselectedonly.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|36|<bitmap>images/22x22/incsearchcase.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\IncrementalSearch\IncrementalSearchToolbar.xrc|42|<bitmap>images/22x22/incsearchregex.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|7|<bitmap>images/22x22/selecttool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|14|<bitmap>images/22x22/instrtool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|21|<bitmap>images/22x22/iftool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|26|<bitmap>images/22x22/switchtool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|33|<bitmap>images/22x22/whiletool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|38|<bitmap>images/22x22/dowhiletool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|43|<bitmap>images/22x22/fortool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|48|<bitmap>images/22x22/blocktool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|55|<bitmap>images/22x22/breaktool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|60|<bitmap>images/22x22/continuetool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|65|<bitmap>images/22x22/returntool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|72|<bitmap>images/22x22/glassptool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|77|<bitmap>images/22x22/glassntool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|84|<bitmap>images/22x22/sourceToggletool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\NassiShneiderman\nassi_shneiderman_toolbar.xrc|89|<bitmap>images/22x22/commentToggletool.png</bitmap>|
G:\Codeblocks312\src\plugins\contrib\ThreadSearch\update31|4|mkdir -p ../../../devel31/share/codeblocks/images/ThreadSearch/22x22 > /dev/null 2> /dev/null|
G:\Codeblocks312\src\plugins\contrib\ThreadSearch\update31|7|mkdir -p ../../../output31/share/codeblocks/images/ThreadSearch/22x22 > /dev/null 2> /dev/null|
G:\Codeblocks312\src\plugins\contrib\ThreadSearch\update31|12|cp ./resources/images/22x22/*.png ../../../devel31/share/codeblocks/images/ThreadSearch/22x22/ > /dev/null 2> /dev/null|
G:\Codeblocks312\src\plugins\contrib\ThreadSearch\update31|15|cp ./resources/images/22x22/*.png ../../../output31/share/codeblocks/images/ThreadSearch/22x22/ > /dev/null 2> /dev/null|
G:\Codeblocks312\src\sdk\xtra_res.cpp|67|finalName.Replace(wxT("22x22"), m_PathReplaceString);|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|7|<bitmap>images/22x22/dbgrun.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|12|<bitmap>images/22x22/dbgrunto.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|17|<bitmap>images/22x22/dbgnext.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|22|<bitmap>images/22x22/dbgstep.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|27|<bitmap>images/22x22/dbgstepout.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|32|<bitmap>images/22x22/dbgnexti.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|37|<bitmap>images/22x22/dbgstepi.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|42|<bitmap>images/22x22/dbgpause.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|47|<bitmap>images/22x22/dbgstop.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|53|<bitmap>images/22x22/dbgwindow.png</bitmap>|
G:\Codeblocks312\src\src\resources\debugger_toolbar.xrc|58|<bitmap>images/22x22/dbginfo.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|10|<bitmap>images/22x22/filenew.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|15|<bitmap>images/22x22/fileopen.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|20|<bitmap>images/22x22/filesave.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|25|<bitmap>images/22x22/filesaveall.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|31|<bitmap>images/22x22/undo.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|35|<bitmap>images/22x22/redo.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|41|<bitmap>images/22x22/editcut.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|46|<bitmap>images/22x22/editcopy.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|51|<bitmap>images/22x22/editpaste.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|57|<bitmap>images/22x22/filefind.png</bitmap>|
G:\Codeblocks312\src\src\resources\main_toolbar.xrc|62|<bitmap>images/22x22/searchreplace.png</bitmap>|

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #56 on: May 09, 2019, 07:27:40 pm »
1. 22x22 in *toolbar.xrc is fine. It is replaced with the proper string for the selected resolution. I guess we could change it to something more meaningful.
2. update31 should all be removed. I'll do it soon.
3. I don't have any 22x22 folder. I guess someone with svn should remove the empty folders. Git just removes them, I guess, without telling svn.
4. FortranProject is maintained by darmar.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 2361
Re: Problem with icons on HiDPI displays
« Reply #57 on: May 12, 2019, 10:59:09 pm »
linux mint 18
if i run ./update30 i get
Code: [Select]
codeblocks_sf/src$ ./update30
./update30: 2: ./update30: source: not found

and for
./update
Code: [Select]
codeblocks_sf/src$ ./update
Updating Linux version.
./update: 26: ./update: Syntax error: "(" unexpected (expecting "}")

I had to replace the first line with
Code: [Select]
#!/bin/bash

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11770
    • Travis build status
Re: Problem with icons on HiDPI displays
« Reply #58 on: May 12, 2019, 11:48:13 pm »
Bleh, I guess dash doesn't support source. :(

Can you replace it with either (note the dot at the beginning)
Code: [Select]
. ./update

or just
Code: [Select]
./update

And tell me which works for you?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline darmar

  • Multiple posting newcomer
  • *
  • Posts: 57
Re: Problem with icons on HiDPI displays
« Reply #59 on: May 18, 2019, 06:48:59 pm »
I have a question: What icons are still needed?

For example, wxSmith plugin has 16x16 and 32x32 size icons. Do we need other size icons?
How with the SciptedWizard?