Code::Blocks Forums
Welcome,
Guest
. Please
login
or
register
.
Did you miss your
activation email
?
1 Hour
1 Day
1 Week
1 Month
Forever
Login with username, password and session length
News:
As usual while waiting for the next release - don't forget to check the
nightly builds
in the forum.
Home
Help
Search
Login
Register
Code::Blocks Forums
»
Developer forums (C::B DEVELOPMENT STRICTLY!)
»
Development
»
small clean up in cbeditor
« previous
next »
Send this topic
Print
Pages: [
1
]
Go Down
Author
Topic: small clean up in cbeditor (Read 3438 times)
frithjofh
Regular
Posts: 376
small clean up in cbeditor
«
on:
May 27, 2018, 06:07:37 pm »
hi everyone,
i am proposing a small code change in the area of cbeditor.
i removed a variable in editorbase which was used to hold the information whether a given pointer refers to a builtin editor or not. i replaced it with the proper override in the derived class.
reasoning: 1) breaks nothing 2) expresses more clearly the relationship 3) removes several lines of code
patch file attached.
regards
Logged
architect with some spare time - c::b compiled from last svn - openSuSE leap x86_64 - AMD FX-4100
oBFusCATed
Developer
Lives here!
Posts: 13413
Re: small clean up in cbeditor
«
Reply #1 on:
May 27, 2018, 08:40:48 pm »
1 is clearly not true, because you've broken the ABI, so you need to rise the sdk version numbers in the cbplugin.h (just the last number).
Also virtual functions are a bit slower than normal methods. I doubt it would matter too much, but still.
Logged
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]
killerbot
Administrator
Lives here!
Posts: 5491
Re: small clean up in cbeditor
«
Reply #2 on:
May 27, 2018, 09:38:20 pm »
patch seems ok
Logged
Send this topic
Print
Pages: [
1
]
Go Up
« previous
next »
Code::Blocks Forums
»
Developer forums (C::B DEVELOPMENT STRICTLY!)
»
Development
»
small clean up in cbeditor