Author Topic: The 29 April 2018 build (11386) is out.  (Read 8765 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5102
Re: The 29 April 2018 build (11386) is out.
« Reply #15 on: May 05, 2018, 07:54:40 am »
correct, the plan is for the next nightly to step up to wx 3.1.x, that's why we didn't bother anymore to take the step towards 3.0.4.

Offline Melchior

  • Multiple posting newcomer
  • *
  • Posts: 62
  • Sage of Life, Reason, and Time
Re: The 29 April 2018 build (11386) is out.
« Reply #16 on: May 05, 2018, 08:10:38 am »
oh ook...
(PC Specs)
CPU: AMD FX-9590 4.7GHz 8-core  RAM: 32GB
Motherboard: Asus SABERTOOTH 990FX R2.0
GPU: nVidia GTX 750Ti SC 2GB  --  GFX Drivers: Nvidia v416.34
OS: Windows 7 Ultimate 64-bit SP1 (x64)

Offline Khram

  • Single posting newcomer
  • *
  • Posts: 7
  • 3D-tensor mathematics - vector space
    • ShipDesign
Re: The 29 April 2018 build (11386) is out.
« Reply #17 on: May 05, 2018, 05:12:26 pm »
Problems with checking spelling are still the same. Now there are no word breaks, but only the last letters are spelling, ... after this the code::blocks is very quickly destroyed.
C++ & Fortran in MinGW-GCC-4.3.3 & Equation-GCC-9.0 with CB 13.12-9958

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11131
    • Travis build status
Re: The 29 April 2018 build (11386) is out.
« Reply #18 on: May 05, 2018, 05:56:14 pm »
Problems with checking spelling are still the same.
Unfortunately your bug reporting skills haven't improved either...  8)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Xaviou

  • Regular
  • ***
  • Posts: 278
    • X@v's wxStuff
Re: The 29 April 2018 build (11386) is out.
« Reply #19 on: May 09, 2018, 08:53:21 am »
Hi.

I've just noticed that it was no more possible to move files betwen/from/to virtual folders in the projects tree.

Is there now an option I missed to re-activate this ?

Tested on Windows 10 with the "official binary", and on OS-X and Debian.

Regards
XAv'
The french wxWidgets site : http://www.wxdev.fr
My wxWidgets's stuff : https://wxstuff.xaviou.fr/

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11131
    • Travis build status
Re: The 29 April 2018 build (11386) is out.
« Reply #20 on: May 09, 2018, 09:23:22 am »
Does it work with the previous night build?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Xaviou

  • Regular
  • ***
  • Posts: 278
    • X@v's wxStuff
Re: The 29 April 2018 build (11386) is out.
« Reply #21 on: May 09, 2018, 11:14:26 am »
Does it work with the previous night build?
Yes, it works.

I have also tested with a personnal build (rev 11374) and it doesn't work.

Regards
Xav'
The french wxWidgets site : http://www.wxdev.fr
My wxWidgets's stuff : https://wxstuff.xaviou.fr/

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11131
    • Travis build status
Re: The 29 April 2018 build (11386) is out.
« Reply #22 on: May 09, 2018, 06:48:24 pm »
Can you find the commit that breaks it?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Xaviou

  • Regular
  • ***
  • Posts: 278
    • X@v's wxStuff
Re: The 29 April 2018 build (11386) is out.
« Reply #23 on: May 09, 2018, 08:42:47 pm »
Can you find the commit that breaks it?
I'll try...

Regards
Xav'
The french wxWidgets site : http://www.wxdev.fr
My wxWidgets's stuff : https://wxstuff.xaviou.fr/

Offline Xaviou

  • Regular
  • ***
  • Posts: 278
    • X@v's wxStuff
Re: The 29 April 2018 build (11386) is out.
« Reply #24 on: May 09, 2018, 10:13:04 pm »
I think I've found the commit : it seems to be rev 11345 :
  • CodeSnippets - Apply modified patches by Miguel Gimenez and bluehazzard
        Adds DnD to projectmanagerui, removes it from the plugin, and fixes asserts
Its not just a supposition related to the comments above : I've built both rev-11344 and rev-11345.
But I've not made 'clean builds' (just svn update and build for both revs) so I can't be 100% sure of what I'm saying.

I have also built the last rev (11400) with src/src/projectmanagerui.cpp of rev 11344 (just before the problematic modification witch was the last modification made on this file) and it works (files can be dragged between virtual folders).
But I don't know witch other impact it can have : it was just for testing purpose.

Hope it'll help

Regards
Xav'
The french wxWidgets site : http://www.wxdev.fr
My wxWidgets's stuff : https://wxstuff.xaviou.fr/

Offline Miguel Gimenez

  • Almost regular
  • **
  • Posts: 128
Re: The 29 April 2018 build (11386) is out.
« Reply #25 on: May 10, 2018, 02:40:50 pm »
It seems pecan disabled dragging in the project tree on purpose:

Quote
// we disallow the drag of files within the project tree

Offline BlueHazzard

  • Lives here!
  • ****
  • Posts: 2025
Re: The 29 April 2018 build (11386) is out.
« Reply #26 on: May 10, 2018, 04:17:27 pm »
This is my fault....
I will look into it and post a patch


Offline BlueHazzard

  • Lives here!
  • ****
  • Posts: 2025
Re: The 29 April 2018 build (11386) is out.
« Reply #27 on: May 10, 2018, 09:51:16 pm »
This should fix the issue

Code: [Select]
diff --git a/src/src/projectmanagerui.cpp b/src/src/projectmanagerui.cpp
index cbd93a6fe..6ca7d0926 100644
--- a/src/src/projectmanagerui.cpp
+++ b/src/src/projectmanagerui.cpp
@@ -977,11 +977,8 @@ void ProjectManagerUI::OnTreeBeginDrag(wxTreeEvent& event)
         wxDropSource dragSource(m_pTree);
         dragSource.SetData(dropObject);
         dragSource.DoDragDrop();
-        // we disallow the drag of files within the project tree
-        return;
     }
-
-    // allowed
+    // Allow drag and drop within the project tree
     event.Allow();
 }

On windows the handling is somehow bugged: If you drag a file the "forbidden" cursor will be shown as long as you hold the mouse button. As soon you release the button the normal "drag&drop" cursor will appear and drag and drop is possible...
It works, but i still will look further...

Offline BlueHazzard

  • Lives here!
  • ****
  • Posts: 2025
Re: The 29 April 2018 build (11386) is out.
« Reply #28 on: May 10, 2018, 10:03:46 pm »
Quote
On windows the handling is somehow bugged: If you drag a file the "forbidden" cursor will be shown as long as you hold the mouse button. As soon you release the button the normal "drag&drop" cursor will appear and drag and drop is possible...
It works, but i still will look further...
i am not quite sure if this is wxWidgets behaviour:
http://docs.wxwidgets.org/3.0/overview_dnd.html
Quote
Dragging: The call to DoDragDrop() blocks the program until the user releases the mouse button (unless you override the wxDropSource::GiveFeedback function to do something special). When the mouse moves in a window of a program which understands the same drag-and-drop protocol (any program under Windows or any program supporting the XDnD protocol under X Windows), the corresponding wxDropTarget methods are called - see below.

Offline Miguel Gimenez

  • Almost regular
  • **
  • Posts: 128
Re: The 29 April 2018 build (11386) is out.
« Reply #29 on: May 11, 2018, 12:33:51 pm »
The forbidden cursor appears because the project manager window should be also a drop target.