Author Topic: Line duplicated in R11515 (@ollydbg)  (Read 93 times)

Offline Miguel Gimenez

  • Almost regular
  • **
  • Posts: 136
Line duplicated in R11515 (@ollydbg)
« on: December 11, 2018, 11:45:46 am »
Commit 11515 duplicated a line in cctest:frame.cpp, giving a redefiition error:

Quote
wxString content = m_CompletionTestCtrl->GetValue();

Online ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5127
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Line duplicated in R11515 (@ollydbg)
« Reply #1 on: December 11, 2018, 02:52:38 pm »
Oh, sorry about this mistake. Definitely a copy and paste error.
I will fix it soon.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Online ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5127
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: Line duplicated in R11515 (@ollydbg)
« Reply #2 on: December 11, 2018, 03:19:12 pm »
Fixed in r11516.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.