Author Topic: compiling trunk against wx 3.1.1 wxTB_3DBUTTONS problem solved  (Read 560 times)

Offline blauzahn

  • Multiple posting newcomer
  • *
  • Posts: 59
compiling trunk against wx 3.1.1 wxTB_3DBUTTONS problem solved
« on: February 21, 2017, 11:17:41 am »
compiling current trunk of cb with current trunk of wx as of today failed because of missing wxTB_3DBUTTONS.
It seems, that does not exist within wx trunk any more.

Deleting the 2 only occurences solved this for us (see attached plain diff)

OS is Ubuntu 16.04 x86_64, g++-5.4.0,
cb built out of tree with:
Code: [Select]
../trunk/configure --prefix=/usr/local --with-contrib-plugins=all,-NassiShneiderman
wxwidgets was built with:

Code: [Select]
../trunk/configure -with-gtk=3 --enable-cxx11 --with-cxx=11 --enable-stl
corresponding change of wxwidgets see:
https://github.com/wxWidgets/wxWidgets/pull/223/commits/1a13f8e5b706afdcae9db58d1cb2c8b8a14dde07

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 10117
Re: compiling trunk against wx 3.1.1 wxTB_3DBUTTONS problem solved
« Reply #1 on: February 21, 2017, 08:34:05 pm »
Uau, you're really brave to use gtk3...
<debugger plugin maintainer>
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline blauzahn

  • Multiple posting newcomer
  • *
  • Posts: 59
Re: compiling trunk against wx 3.1.1 wxTB_3DBUTTONS problem solved
« Reply #2 on: February 21, 2017, 10:48:02 pm »
...and I use it for quite some tme by now on a daily basis. My general feeling is ok with that.

And I do not consider myself brave;-)

One thing I have deactivated (and miss) though is the keybinder plugin due to F2 not reopening the log window.

Since it works at first then stops and closing does always work I assume that the key actually makes it into the plugin.
Looks like the state within the plugin gets corrupted. Had a brief look into it. Tried first some minor formal things
(usual suspects like uninitialized data-member etc.). To dig deeper I'll be nice to know more about expected (local)
behaviour to make sure I do not break things accidentially. And to be able to set up a handful of unittests,
a tiny dose of decoupling non-gui from gui stuff only where appropriate would be necessary. Changes without any tests
in place are more daring, let alone the fact that they have to pass acceptance getting into cb trunk. And I do not want
to play keyboard-monkey over and over again to test.



Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 10117
Re: compiling trunk against wx 3.1.1 wxTB_3DBUTTONS problem solved
« Reply #3 on: February 22, 2017, 12:36:55 am »
Changes without any tests in place are more daring...
I don't think there is a way to successfully regression test a keybinding plugin that plugs into the event loop and messes things up.
But if you succeed then I'll be happy to review the patch. :)
<debugger plugin maintainer>
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]