Author Topic: Bug with latest trunk and goto file dialog  (Read 862 times)

Offline BlueHazzard

  • Lives here!
  • ****
  • Posts: 1581
Bug with latest trunk and goto file dialog
« on: February 07, 2017, 07:00:46 pm »
Hi, i experience a new introduced bug with the goto file dialog:
if i type in the search field, the list does not get updated. The scroll bar is updated (it gets bigger, so the list has less entries), but the text in the list not. I have to scroll the list out of view to get a updated list. So it seems the redraw is not handled correctly?

greetings

[Edit:]
OS: Windows 7 x64 wx2.8 latest trunk tdm 4.8

Offline BlueHazzard

  • Lives here!
  • ****
  • Posts: 1581
Re: Bug with latest trunk and goto file dialog
« Reply #1 on: February 07, 2017, 07:43:39 pm »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 10398
Re: Bug with latest trunk and goto file dialog
« Reply #2 on: February 07, 2017, 09:31:19 pm »
Bleh. I guess it is some windows only bug. I've tried it on wx2.8 on linux and it worked. :(

Can you try if this patch fixes the problem:
Code: [Select]
diff --git a/src/sdk/incremental_select_helper.cpp b/src/sdk/incremental_select_helper.cpp
index 5f9fd3e38..1989ad544 100644
--- a/src/sdk/incremental_select_helper.cpp
+++ b/src/sdk/incremental_select_helper.cpp
@@ -107,6 +107,7 @@ void FilterItemsFinalize(wxListCtrl &list, IncrementalSelectIterator &iterator)

     if (iterator.GetFilteredCount() > 0)
         list.SetItemState(0, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED);
+    list.Refresh();
 }

 void IncrementalSelectHandler::FilterItems()
<debugger plugin maintainer>
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 10398
Re: Bug with latest trunk and goto file dialog
« Reply #3 on: February 07, 2017, 09:33:36 pm »
And if possible make a really big project and try before and after the patch if performance on windows is similarly improved as on linux.
Downloading the latest linux sources and just adding all h and c files to the project is a good test for performance.
In fact it has show many performance problems already.

Expect more breakages when I start pushing fixes for them in the next days :)
<debugger plugin maintainer>
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline BlueHazzard

  • Lives here!
  • ****
  • Posts: 1581
Re: Bug with latest trunk and goto file dialog
« Reply #4 on: February 07, 2017, 10:50:38 pm »
yes, this fixes the issue, and the speedup to the old version is really nice!

good work!

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 10398
Re: Bug with latest trunk and goto file dialog
« Reply #5 on: February 08, 2017, 12:44:56 am »
In svn...
<debugger plugin maintainer>
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]