« previous next »
Pages: [1]   Go Down

Author Topic: Windows XP manifests  (Read 4438 times)

sethjackson

  • Guest
Windows XP manifests
« on: January 19, 2006, 10:46:53 pm »
Hi I was looking at the manifest creation code, and since this is MSW only I added a *gasps* macro :lol: that lets it compile only on MSW (I hope I did it right). Is this OK? I'm going to submit a patch to SF.net if so.....
« Last Edit: January 20, 2006, 06:00:43 pm by sethjackson »
Logged

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: Windows XP manifests
« Reply #1 on: January 20, 2006, 09:09:06 am »
Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)
Logged
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

sethjackson

  • Guest
Re: Windows XP manifests
« Reply #2 on: January 20, 2006, 05:34:44 pm »
Quote from: thomas on January 20, 2006, 09:09:06 am
Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)

Ok I'm not to good with preprocessor macros (I looked at wx sources).....
Logged
Pages: [1]   Go Up
« previous next »