Author Topic: codeblocks wxWidgets 3.0 on openSuSe 13.2  (Read 7189 times)

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
codeblocks wxWidgets 3.0 on openSuSe 13.2
« on: October 27, 2015, 11:17:14 pm »
hi everybody,

has somebody ever made some tries compiling c::b with wxWidgets 3.0 on openSuSE 13.2 ?

Got any results?

regards
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #1 on: October 28, 2015, 09:54:28 am »
Night builds should compile fine. If not please post the error messages, so we can look it up.
But there might be problems at runtime, because the porting to wx30 hasn't finished.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #2 on: October 28, 2015, 02:11:01 pm »
hi and thx for the answer...

so, I built it and everything worked fine, but now I have to start it...

it gives me this message in a pop up window:


Cannot find resources...
Code::Blocks was configured to be installed in '/home/fri/Programmieren/cb_svn/trunk/srd/devel30/share/codeblocks'.
Please use the command-line switch '--prefix' or set the CODEBLOCKS_DATA_DIR environment variable to point where Code::Blocks is installed,
or try re-installing the application...




maybe its because I am really lacking sleep, but I can help myself here...

any hints appreciated

regards
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #3 on: October 28, 2015, 05:49:50 pm »
OK, forgot the update30 command...

sorry
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #4 on: October 28, 2015, 06:46:06 pm »
working now.

had to make some changes in source code because I compiled against wxWidgets 3.0  STD (the default coming with opensSuSE 13.2)

only minor changes though, all due to STD:
- putting auto where compiler claimed not knowing some types (compatibility_iterator).
- adding some .c_strg() here and there, mainly in the loggers.h/loggers.cpp.
- making a change sc_wxtypes.cpp in registering wxArraystring to squirrel (had to split it up: some functions wxArrayString, some wxArrayStringBase) (why?).

many dialogues really fumbled up (why?). some gui elements pretty ugly (why?).

but working

was fun
« Last Edit: October 28, 2015, 06:47:47 pm by frithjofh »
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #5 on: October 28, 2015, 11:54:48 pm »
all plugins work too.

not much to adapt in their code.

exception: wxSmith. it relies too heavily on wxWidgets containers... seems to be a lot of work
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #6 on: October 29, 2015, 12:39:55 am »
Is suse's wx compiled in stl mode?
Generally auto should not be used in the current code base.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #7 on: October 29, 2015, 08:05:49 am »
yes, the wx of suse is in STL mode...

that was what I was trying out, compiling c::b with wx in STL mode.

using auto wasn't really necessary, I could have put compatibility_iterator instead. it just saved typing and was in order to test auto in these places.
« Last Edit: October 29, 2015, 08:09:26 pm by frithjofh »
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #8 on: October 30, 2015, 10:01:51 am »
Patches?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #9 on: October 30, 2015, 11:35:55 am »
whoa, slow down please ...  ;)

I id this like as a personal experiment first. like to ponder the amount of work it would suppose and if it even was possible.

well, it is working right now. I didn't have any crashes so far. but there are some strange behaviours in gui elements.

for patches I would do things more serious.

for instance, I would think these changes should be made so, that they don't affect the wx native containers build. in order to have only one code base for both wx native and wx STL. maybe even, if this would require using the auto keyword.

for other patches I would need to help from you devs. for instance many compiler errors come from the function signature

Code: [Select]
inline wxString F(const wxChar* msg, ...)
in logmanagers.h because of the use of const wxChar* which does not go along with wx STL wxString. I changed that functions signature to

Code: [Select]
inline wxString F(const wxString& msg, ...)
because as far as I could see, this change doesn't affect the way this function works or any of its callers.

Then again, that same function seems a bit messy all together, so I changed it to:

Code: [Select]
inline wxString F(wxString msg, ...)
    {
        va_list arg_list;
        va_start(arg_list, msg);

#if wxCHECK_VERSION(2,9,0) && wxUSE_UNICODE
        // in wx >=  2.9 unicode-build (default) we need the %ls here, or the strings get cut after the first character
        msg.Replace(_T("%s"), _T("%ls"));
#endif

        ::temp_string = wxString::FormatV(msg, arg_list);

        va_end(arg_list);

        return ::temp_string;
    }

to save all this needless copying of strings. but then: what happens to wxCHECK_VERSION(3,0,0) etc...?

short: I am too insecure  :-[
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #10 on: October 30, 2015, 12:28:53 pm »
what is that ::temp_string variable good for anyway?

to me it seems like a intended optimization for speed, but I don't think it really gives any benefit. on the contrary I think it even slows things down because it looses cache locality this way...

in all the 14 places it shows up, it could be easily and better be substituted for a local string, I think.
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #11 on: October 31, 2015, 12:24:21 pm »
The patches are in svn.
Some notes:
1. you've created them in reverse, the plus lines should contain your changes.
2. please if you have more patches post them in this topic.

About the F function, yes it is some awkward one.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #12 on: October 31, 2015, 12:45:46 pm »
sorry for that reverse...

here comes a patch for the logmanager.h file...

that messy F function
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #13 on: October 31, 2015, 01:19:10 pm »
patch for EnvVars

- only some change of variables

- changed some wxString functions to the STL versions

- replaced some wxString wx1.0 compatibility functions by STL version

- changed the   void EnvVarsDebugLog(wxString msg, ...) similar as in logmanager.h. they were actually quite the same
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #14 on: October 31, 2015, 01:27:20 pm »
patch for smartindent

only a glitch in the c::b project file
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #15 on: October 31, 2015, 01:55:07 pm »
important:

I can test any of these patches against wx wxcontainers

I only have wx STL at my disposition right now

I do try to keep all changes as "harmless" as possible under this aspect
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #16 on: October 31, 2015, 03:51:14 pm »
BTW, I have a branch that have some of these changes applied. I've forgotten about it. I'm trying to resurrect it. I'll post a link when I have something that builds.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #17 on: October 31, 2015, 03:57:40 pm »
OK, I wont have time this weekend to prepare all the other patches...

till now these are almost all for minor plugins.

there are some 20 more in the line.

one more complicated for squirrel and some more intrusive for wxSmith.

all together leave c::b in working state both with wx normal and wx STL as far as I can see...

there are occasional crashes when splitting and unsplitting editors, but I think they are due to something in the wxaui, and not related to wx3.0 STD. also sometimes a strange effect, that when having  splitted the view, that newly opened files just show a grey editor (not blank, but grey, no editor at all in the new tab). I think that comes out of the same wxaui corner...
« Last Edit: October 31, 2015, 04:06:57 pm by frithjofh »
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #18 on: November 01, 2015, 06:53:06 pm »
You can check this branch https://github.com/obfuscated/codeblocks_sf/tree/builds/wx31
It has everything except wxsmith fixed when building against wx3.1+stl.

If you can post patches against this branch it will be good.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #19 on: November 02, 2015, 05:38:22 pm »
I can do that, but my aim was to make changes to the wx3 wxcontainer c::b  code base  directly as to make it compile both against a wx3 wxcontainer and the wx STL

so there would be only one c::b code base without branches. the changes are not that big as to need a separate branch at all...

what do you think?

btw: in order to achieve this someone would have to test the patches compiling against wx wxcontainer lib
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #20 on: November 02, 2015, 08:13:05 pm »
for my understanding: are there people, which rely on building c::b only against wx containers without using anything of STL? which really can't have any STL element in the code base?

and why?
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #21 on: November 03, 2015, 12:50:07 am »
The branch contains a codebase that has almost everything compile in wx2.8, wx3.0 and wx3.0+stl.
The only thing that doesn't compile is wxsmith.

This is a working branch, if you tell me that the changes are ok, they'll land in svn's trunk.
Using git branches is easier (at least for me) to test changes that are not 100% ready.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #22 on: November 03, 2015, 11:03:05 am »
but the branch you told me doesn't even compile...

it hits an error in toolsmanager.cpp with the ToolsList::node same as the normal svn branch...

am I understanding something wrong?
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline stahta01

  • Lives here!
  • ****
  • Posts: 6671
    • My Best Post
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #23 on: November 03, 2015, 01:11:32 pm »
but the branch you told me doesn't even compile...

it hits an error in toolsmanager.cpp with the ToolsList::node same as the normal svn branch...

am I understanding something wrong?

Do you know how to checkout a branch in git?

Sounds like you are on the master branch instead of builds/wx31 branch.

Note: I have never used the "builds/wx31" branch so I might be wrong.

It could be instead that he never fixed the branch "builds/wx31" for full STL wxWidgets building.

Edit: I will try building on Windows and Debian later this week and see if it builds for me.

Tim S.
« Last Edit: November 03, 2015, 01:13:53 pm by stahta01 »
C Programmer working to learn more about C++ and Git.
On Windows 7 64 bit and Windows 10 32 bit.
On Debian Stretch, compiling CB Trunk against wxWidgets 3.0.
--
When in doubt, read the CB WiKi FAQ. http://wiki.codeblocks.org

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #24 on: November 03, 2015, 03:03:08 pm »
omg... thx

I didn't check out the branch... just forgot...  ::)
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #25 on: November 04, 2015, 11:03:42 am »
if somebody could help please...

when I compile the wx3.1 branch it does compile, but it takes very long. the process seems to pause always in the line in the log below, where it quotes that the particular directory was not a working copy. I am not fit in git, I don't know, why c::b is complaining here...

Code: [Select]
-------------- Build: tinyXML in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: AutoRevision in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: ConsoleRunner in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Squirrel in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Squirrel std lib in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: SqPlus in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: scintilla in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.
Running target pre-build steps
build_tools/autorevision/autorevision30 +wx +int +t . include/autorevision.h
svn: E155007:  '/home/fri/Programmieren/codeblocks_sf/src' is not a working copy
Unable to determine upstream SVN information from working tree history
svn: E155007: '/home/fri/Programmieren/codeblocks_sf/src' is not a working copy

-------------- Build: sdk in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: src in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Abbreviations in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: AStyle in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Autosave in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Compiler depslib in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Compiler in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Debugger in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Code-completion in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Class wizard in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Default MIME handler in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Occurrences Highlighting in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Open files list in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Projects-workspaces importer in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: Scripted wizard in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.

-------------- Build: To-do in Code::Blocks wx3.0.x - Unix (compiler: GNU GCC Compiler)---------------

Target is up to date.
Process terminated with status 0 (1 minute(s), 25 second(s))
0 error(s), 0 warning(s) (1 minute(s), 25 second(s))
 
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #26 on: November 04, 2015, 09:22:56 pm »
For some reason getting the revision from git is slow. It won't harm if you remove this line in the post/pre build steps.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #27 on: November 08, 2015, 12:48:37 pm »
I've pushed the debugger patch in the branch.
Do we need any more patches for none wxsmith parts of the project?
Do you plan to post a patch for wxsmith?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #28 on: November 08, 2015, 02:53:12 pm »
yes I plan to post more patches. it is just that I have to do my normal life and work too, so my contribution come a little irregular, sorry for that.

I specially want to send in those patches for wxSmith...

right now I have a problem with the debugger plugin, I don't seem to be able to understand or track down.

I have everything built with wx3.0 STL and working so far. but if I have a project open, then close it and open the same or another project, c::b crashes on me. it tracks to the menu of the debugger plugin. concrete to the function that recreates the target menu, the point, where the plugin wants to delete the menu items in the "Select target" submenu.

This also happens when trying to release the plugin. the crash report always lists this function

Code: [Select]
void DoClearTargetMenu();
when I out-comment the line actually deleting the item c::b ceases to crash. naturally then the menu doesn't get cleared and opening a new project adds the new targets to the existing.

I attach a crash report

perhaps it is only my version of wx3.0.2
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #29 on: November 08, 2015, 03:25:27 pm »
just tried to send some git updates for wxSmith.

but as I still have no experience with git and the gui I use, please tell me if something actually arrived...
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #30 on: November 08, 2015, 04:49:45 pm »
The easiest way to give me patches is:
1. commit each change in a separate commit
2. when you have something to submit use the git format-patch command to generate the patches
3. post the patches and then I'll be able to apply them with a single command.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #31 on: November 08, 2015, 05:14:36 pm »
I've reproduced the issue with the menu. It is cause by the compiler's menu rebuilding. I'll see if it is a cb or wx bug.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #32 on: November 08, 2015, 07:21:57 pm »
I've fixed the issue in the branch. It turned out that invalid iterator is used, which is only visible in the wx-stl version.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #33 on: November 08, 2015, 09:07:37 pm »
lets try...

with an easy one.

please tell me if it worked
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #34 on: November 18, 2015, 09:40:41 am »
hi again,

had a sudden work tsunami... donít have much time right now.

attached the patch for the wxSmith
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #35 on: November 18, 2015, 09:45:16 pm »
1. std::vector<bool> is a special beast and should be avoided, I'd prefer if this is fixed by switching the type from bool to int in the wxArray declaration
2. you're using c++11, which is not allowed at the moment
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #36 on: November 18, 2015, 10:05:10 pm »
2. use of c++11 is not essential in the patches. it can easily be done without any c++11 artifact.

1. I agree on better not use std::vector<bool> for being such a strange asset. I would think it well possible to replace it with an std::vector<int> or even a plain int[] array. maybe a bitfield could be a candidate too, but that is too low level in my opinion.

in the long run I think, that wxSmith has to be gradually rewritten. it is too error prone, to hard too understand, too hard to extend, too brittle, way too low level without any need. too many language noise covers the real structure of the plugin, and the distinct parts are way too interdependent. a lot of work...

do you want me to change the patch, or have you already done that?
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline frithjofh

  • Regular
  • ***
  • Posts: 373
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #37 on: November 18, 2015, 10:11:53 pm »
I forgot:

could you confirm that after the application of the patch wxSmith is working correctly?

any changes from std::vector<bool> to another and better solution could be made later on.
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12122
    • Travis build status
Re: codeblocks wxWidgets 3.0 on openSuSe 13.2
« Reply #38 on: November 18, 2015, 11:50:49 pm »
in the long run I think, that wxSmith has to be gradually rewritten. it is too error prone, to hard too understand, too hard to extend, too brittle, way too low level without any need. too many language noise covers the real structure of the plugin, and the distinct parts are way too interdependent. a lot of work...
There is no doubt about all these issues, but we need a volunteer who will spend all this time doing the work. :)

do you want me to change the patch, or have you already done that?
I've made it compile with a simple wxArray<int>, but I don't know if it works correctly.
If you can test this it will be the best fix for the problem.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]