Author Topic: The 12 January 2006 build is out.  (Read 26001 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5241
The 12 January 2006 build is out.
« on: January 13, 2006, 12:40:14 am »
Get quick announcements through the RSS feed http://www.codeblocks.org/nightly/CodeBlock_RSS.xml
A link to the unicode windows wxWidget dll for Code::Blocks : http://download.berlios.de/codeblocks/wxmsw26u_gcc_cb.7z

The 12 January 2006 build is out.
  - Windows : http://download.berlios.de/codeblocks/CB_12jan2006_rev1731_win32.7z
  - Linux : not supported yet


Resolved Fixed:

  • wxSmith : Adding support for Image property and Adding wxStaticBitmap widget
  • Changed some default editor settings:
            - Highlight line: OFF
            - Gutter: OFF
            - End file with extra line: ON
            - Show line numbers: ON.
  • Optimized debugger regular expressions
  • Fixed bug with special characters in filenames (debugger)
  • Updated wxFlatNotebook to version 1.1
  • Fixed error in wxSmith project file (linker dir)
  • Fixed syntax error in C/C++ lexer file
  • Fixed crash when loading an invalid editor lexer file
  • Added code-completion option to use scintilla's auto-complete instead of our own. This also fixes bug #1399921
  • wxWidgets template :Removed message box providing wrong information
  • Improved wxString/wxChar support in debuggers
  • Fixed "View->Go to function"
  • Fixed debugger watches tree parsing error when parsing templates

Regressions/Confirmed/Annoying/Common bugs:

  • DDE bug : clicking in windows explorer on a CB registered file throws an error message box
  • toolbar-images-not-changing-state (is a wx problem)


Offline artoj

  • Almost regular
  • **
  • Posts: 206
  • Location: Supporting my team
    • http://ajonsson.kapsi.fi/
Re: The 12 January 2006 build is out.
« Reply #1 on: January 13, 2006, 08:23:06 am »
you are right, i confirm.

Thank you very much. This is now in SF..net: #1404517 C::B fails to restore itself from taskbar

Now, if someone could reproduce this evil bug I could send it to SF.net.

Please post your comments/findings to this topic.

Thank you.
« Last Edit: January 13, 2006, 08:27:48 am by artoj »

Offline kkez

  • Almost regular
  • **
  • Posts: 153
    • WinapiZone
Re: The 12 January 2006 build is out.
« Reply #2 on: January 13, 2006, 02:23:53 pm »
I can confirm this bug. The "check for externally modified files" option is checked. The reload file dialog is shown only when i switch to another application.

I may have found another bug:
1) Create a new file.
2) Modify it but don't save it.
3) Close this file. The confirm save dialog is shown two times.
« Last Edit: January 13, 2006, 02:43:15 pm by kkez »

Offline Michael

  • Lives here!
  • ****
  • Posts: 1608
Re: The 12 January 2006 build is out.
« Reply #3 on: January 13, 2006, 02:34:00 pm »
I may have found another bug:
1) Create a new file.
2) Modify it but don't save it.
3) Close this file. The confirm save dialog is shown two times.

I have observed this bug too with rev1728. If you right click on the file tab and select "close", then the confirm save dialogue is shown two times. But if you close the file with the "x" icon, then it is shown just one time.

Michael

Offline Michael

  • Lives here!
  • ****
  • Posts: 1608
Re: The 12 January 2006 build is out.
« Reply #4 on: January 13, 2006, 02:48:56 pm »
Now, if someone could reproduce this evil bug I could send it to SF.net.

I have observed this bug too with rev1728. I have also tried with UltraEdit-32. If I do not close it, there is no bug, but if I close it, the bug is there.

Michael

Offline artoj

  • Almost regular
  • **
  • Posts: 206
  • Location: Supporting my team
    • http://ajonsson.kapsi.fi/
Re: The 12 January 2006 build is out.
« Reply #5 on: January 13, 2006, 03:51:41 pm »
Thanks kkez and Michael. It seems I had already submitted the bug to SF.net :oops: but I now added the steps how to reproduce the bug better.

I may have found another bug:
1) Create a new file.
2) Modify it but don't save it.
3) Close this file. The confirm save dialog is shown two times.

I can confirm. You should create a new bug to SourceForge.net's Code::Blocks project page.

Offline agentsmith

  • Single posting newcomer
  • *
  • Posts: 6
Re: The 12 January 2006 build is out.
« Reply #6 on: January 13, 2006, 08:06:07 pm »
Hello,
I'm not so sure if this is a right plate to post it, but I haven't found this issue anywhere on this forum, so please have mercy for a rookie ;)
Anyway, I've noticed that "Show spaces" option doesn't work. And this is unconditional. Both "All spaces" and "Only after indent" options always result that all white space is is...still white ;)
I verified this on few builds (from 02 Jan to this build) and on two different machines (both with WinXP).

Regards
« Last Edit: January 13, 2006, 08:08:21 pm by agentsmith »

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4291
    • Code::Blocks IDE
Re: The 12 January 2006 build is out.
« Reply #7 on: January 13, 2006, 08:20:30 pm »
I'm not so sure if this is a right plate to post it

It is not the right place to post it ;).
But thanks anyway. Fixed in r1750.
Be patient!
This bug will be fixed soon...

Offline Michael

  • Lives here!
  • ****
  • Posts: 1608
Re: The 12 January 2006 build is out.
« Reply #8 on: January 13, 2006, 08:23:38 pm »
Fixed in r1750.

And I have just finished to compile rev1749 :D. How fast bugs are fixed is always a surprise for me (and a pleasant one :D).

Michael

Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1441
    • CenizaSOFT
Re: The 12 January 2006 build is out.
« Reply #9 on: January 13, 2006, 08:31:36 pm »
Heh, I always have the same "problem". I just finish compiling the most recent revision and a new one comes.

mandrav and his team of slaves developers do it on purpose, I know...

Offline Michael

  • Lives here!
  • ****
  • Posts: 1608
Re: The 12 January 2006 build is out.
« Reply #10 on: January 13, 2006, 08:35:47 pm »
slaves developers

Ehm...slaves :D? I used the same methaphor with my old project supervisor :).

Michael

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5241
Re: The 12 January 2006 build is out.
« Reply #11 on: January 13, 2006, 09:09:15 pm »
Thanks kkez and Michael. It seems I had already submitted the bug to SF.net :oops: but I now added the steps how to reproduce the bug better.

I may have found another bug:
1) Create a new file.
2) Modify it but don't save it.
3) Close this file. The confirm save dialog is shown two times.

I can confirm. You should create a new bug to SourceForge.net's Code::Blocks project page.

was the file part of a project ??
I just tried without projects , and for the new file, only 1 message box came up.

Offline artoj

  • Almost regular
  • **
  • Posts: 206
  • Location: Supporting my team
    • http://ajonsson.kapsi.fi/
Re: The 12 January 2006 build is out.
« Reply #12 on: January 13, 2006, 09:11:21 pm »
was the file part of a project ??
I just tried without projects , and for the new file, only 1 message box came up.

EDIT: You need to select No when the confirm dialog pops up first time.

So:

1) Create a new file.
2) Modify it but don't save it.
3) Close this file.
4) Select No.

The dialog is shown twice.
« Last Edit: January 13, 2006, 09:22:51 pm by artoj »

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5241
Re: The 12 January 2006 build is out.
« Reply #13 on: January 13, 2006, 09:54:29 pm »
I have found the problem and have a solution.

When you call close by right clicking on the tab , you end up in this function :
Code: [Select]
bool EditorManager::Close(EditorBase* editor,bool dontsave)
{
    SANITY_CHECK(false);
    if (editor)
{
int idx = FindPageFromEditor(editor);
if (idx != -1)
{
            if(!dontsave)
                if(!QueryClose(editor))
                    return false;
            wxString filename = editor->GetFilename();
//            LOGSTREAM << wxString::Format(_T("Close(): ed=%p, title=%s\n"), editor, editor ? editor->GetTitle().c_str() : _T(""));
            m_pNotebook->DeletePage(idx);
}
}
    m_pData->m_NeedsRefresh = true;
    return true;
}

-> The QueryClose() call shows the message box. When the user clicks on no, the function returns true, so it ends up at m_pNoteBook->DeletePage(idx), and that one will call OnPageClosing
Code: [Select]
void EditorManager::OnPageClosing(wxFlatNotebookEvent& event)
{
    EditorBase* eb = static_cast<EditorBase*>(m_pNotebook->GetPage(event.GetSelection()));
//    LOGSTREAM << wxString::Format(_T("OnPageClosing(): ed=%p, title=%s\n"), eb, eb ? eb->GetTitle().c_str() : _T(""));
    if (!QueryClose(eb))
        event.Veto();
    event.Skip(); // allow others to process it too
}
Which calls .... QueryClose() --> so a second message box.

If you close with the x button, then you end up immediately in OnPageClosing -> 1 message box.

My suggestion is to remove the part :

            if(!dontsave)
                if(!QueryClose(editor))
                    return false;
            wxString filename = editor->GetFilename();
//            LOGSTREAM << wxString::Format(_T("Close(): ed=%p, title=%s\n"), editor, editor ? editor->GetTitle().c_str() : _T(""));

EditorManager::QueryClose returns false, only when the saving faild for some reason or the user pressed cancel, then EditorManager::Close will return after the QueryClose call and not call the notebook anymore, so no problem for this either, the one time change is in both cases best suited inthe notebook.

Another thing is then the QueryClose checks on ed->GetModified() and on a NO click it will do ed->SetModified(false); so that means in our secon call the GetModified should return false (and hence no message box), but it seems again this returns true.



But Yiannis could you take a look at it ? Maybe the functions is also called in other flows where it is still needed ???



[EDIT], the reason why the second modify again gets returned true is :
bool cbEditor::GetModified()
{
    return m_Modified || m_pControl->GetModify();
}

m_Modified was set to false, but it is the second part that make the whole evaluate to true.
« Last Edit: January 13, 2006, 10:03:11 pm by killerbot »

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4291
    • Code::Blocks IDE
Re: The 12 January 2006 build is out.
« Reply #14 on: January 13, 2006, 10:25:54 pm »
I have found the problem and have a solution.

Hehe, as always ;)
Fixed.
Thanks Lieven.
Be patient!
This bug will be fixed soon...

Offline rickg22

  • Lives here!
  • ****
  • Posts: 2283
Re: The 12 January 2006 build is out.
« Reply #15 on: January 13, 2006, 10:53:59 pm »
mandrav and his team of slaves developers do it on purpose, I know...

That's Dr. Mandrav and his minions, to you, sir. :P
« Last Edit: January 13, 2006, 10:55:52 pm by rickg22 »