Author Topic: MiniDoc  (Read 22615 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11053
    • Travis build status
Re: MiniDoc
« Reply #30 on: August 14, 2014, 11:08:49 pm »
Ah, you've posted a link to a bug reported by me...  ;D
« Last Edit: August 15, 2014, 01:11:48 am by oBFusCATed »
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9456
Re: MiniDoc
« Reply #31 on: August 17, 2014, 03:23:35 pm »
MiniDoc.cpp fails to compile with wx30 (non-PCH) due to a missing include of logmanager.cpp.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11053
    • Travis build status
Re: MiniDoc
« Reply #32 on: August 19, 2014, 09:58:58 am »
This is the bug report: http://trac.wxwidgets.org/ticket/13709 if you want to join the discussion:)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9456
Re: MiniDoc
« Reply #33 on: August 19, 2014, 05:37:05 pm »
This is the bug report: http://trac.wxwidgets.org/ticket/13709 if you want to join the discussion:)
...why do we care about wxSTC? We can do it ourselves... don't we (I guess I am missing something...).
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11053
    • Travis build status
Re: MiniDoc
« Reply #34 on: August 19, 2014, 09:07:26 pm »
Because the wx devs can help with the fix, I'm not too familiar with the code.
Also the original bug report has nothing to do with codeblocks (I've tried to do a svn blame gui tool back then).

And also because I'm left with the impression that the wx project is the current maintainer of the wxscintilla component.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7262
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: MiniDoc
« Reply #35 on: August 19, 2014, 09:16:02 pm »
And also because I'm left with the impression that the wx project is the current maintainer of the wxscintilla component.

In general yes, and we (better Morten) regularily synchronize our sources with the wxSTC-sources, but nevertheless we acn not use it directly, because we use many own patches in (wx)scintilla.

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9456
Re:
« Reply #36 on: August 19, 2014, 10:02:15 pm »
Well in fact we are synchronizing with scintilla directly and not with wxstc. Wxstc is far older than our wxscintilla component, additionally our component can do more than scintilla. We are the maintainer of wxscintilla meanwhile if you wish. Btw: I've already prepared the synch to scintilla 3.50 hence I see an issue with white fonts on white background I was unable to resolve so far. Scintilla has undergone some major changes I.e. switching the architecture to an mvc principle. This obviously is the reason but I could not pin point the exact code portion. I could do a branch of you like...
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7262
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: MiniDoc
« Reply #37 on: August 19, 2014, 10:28:20 pm »
What I meant are commits like this:
Quote from: http://sourceforge.net/p/codeblocks/code/8278/
* pumped (wx)Scintilla to 3.2.2
* harmonised (wx)Scintilla with wxSTC from wxWidgets SVN (which happened to have updated scintilla, too lately)
The updates to scintilla are more or less independent from this.

You could make branch with the new scintilla, so more devs can have a look into the issue(s) with 3.50 .
What exactly is the issue with white fonts on white background ?

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9456
Re:
« Reply #38 on: August 20, 2014, 05:31:34 am »
Oh right,I see.Well what I harmonised was mainly the layout of the source code wrt where the methods are located so you can compare better and (most important) the generator that actually creates the source code out of a template. It's a python script.

I'll do a branch hopefully tomorrow...
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline danselmi

  • Developer
  • Almost regular
  • *****
  • Posts: 202
Re: MiniDoc
« Reply #39 on: August 25, 2014, 02:13:40 pm »
This is the bug report: http://trac.wxwidgets.org/ticket/13709 if you want to join the discussion:)

Attached is how I think the solution should look like.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11053
    • Travis build status
Re: MiniDoc
« Reply #40 on: August 25, 2014, 08:55:52 pm »
About the patch: it would be good if you can put a comment why do you need the second draw rectangle call.
Also: I'll be happy if you can negotiate this with the developers of wxWidgets...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9456
Re:
« Reply #41 on: August 26, 2014, 09:26:45 am »
I'll do a branch hopefully tomorrow...
Well I did a branch right now (a little later than tomorrow :P). Please use the new project file "CodeBlocks.scintilla.cbp" for testing. I have done this for Windows only, atm. The branch is located at:

https://svn.code.sf.net/p/codeblocks/code/branches/scintilla_3_5_0

Edit: Not to forget: Due to the changes of path's in the branch its best if you do a full re-build and a clean before. Its enough to compile/test this single project file, not the whole C::B workspace. But make sure you don't have any old plugins in the way referencing a different (old) scintilla component...
« Last Edit: August 26, 2014, 09:33:52 am by MortenMacFly »
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7262
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: MiniDoc
« Reply #42 on: August 30, 2014, 03:57:52 pm »
I just committed a linux project-file (only C::B core), some (linux) build-fixes and most important a fix for the white-text-on-white-background-issue (not yet tested on windows).

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9456
Re: MiniDoc
« Reply #43 on: August 30, 2014, 09:59:38 pm »
I just committed a linux project-file (only C::B core), some (linux) build-fixes and most important a fix for the white-text-on-white-background-issue (not yet tested on windows).
OK Jens - so it was the Ascent method... Oh dear - 4 eyes only see more than two. I've merged all my remaining stuff that was pending in the mean time. This includes danselmi's changes wrt to the patch in MiniDoc (was it that one, or cbDiff?!), obfuscate's patch wrt to the black border and some others like a new event that allows (plugins) to modify the text being copied /pasted via clipboard...

I've merged trunk into the branch, cleaned it up, fixed (?) the autotools build system so it would be ready to get merged into trunk again, if there are no complaints...

Are there any?
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline jens

  • Administrator
  • Lives here!
  • *****
  • Posts: 7262
    • Jens' unofficial debian-repository for the Code::Blocks - IDE
Re: MiniDoc
« Reply #44 on: August 31, 2014, 12:25:11 am »
I will test it today or tomorrow.
Or just commit it, if there are no obvious issues and we fix it in trunk.