Author Topic: C::B and wxWidgets 2.9.5 under Windows  (Read 31207 times)

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #15 on: October 01, 2013, 11:46:02 pm »
Thanks a lot to fuscated for appling the patches r9375-r9378.

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #16 on: October 02, 2013, 08:43:27 am »
The changes to scintilla code will likely need submitted upstream to them for the changes to be put into CB.

I submitted a report to https://sourceforge.net/p/scintilla/bugs/1531/, but it was declined, saying that sources which use the CallTip.h should include <string>. (Honestly this seems a bit weird, in particular if the code that needs to include that header doesn't do anything with strings at all, it just needs the header to prevent a compile error.)

And wxScintilla seems pretty abandoned to me. At least I have no clue where to submit any bug reports. I saw that wxWidgets patches the code (see https://github.com/wxWidgets/wxWidgets/blob/master/src/stc/ScintillaWX.cpp) by adding the following to ScintillaWX.cpp:

Code: [Select]
#if !wxUSE_STD_CONTAINERS && !wxUSE_STD_IOSTREAM && !wxUSE_STD_STRING
    #include "wx/beforestd.h"
    #include <string>
    #include "wx/afterstd.h"
#endif

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11899
    • Travis build status
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #17 on: October 02, 2013, 09:31:51 am »
It is not abandoned. See here for contacts http://www.scintilla.org/
I'm not sure where wxScintilla is developed, probably wxwidgets.
Morten would know better.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #18 on: October 02, 2013, 09:44:30 am »
No, Scintilla is not abandoned, but wxScintilla seems to be.

http://wxcode.sourceforge.net/showcomp.php?name=wxScintilla

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11899
    • Travis build status
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #19 on: October 02, 2013, 11:35:36 am »
I believe my SDL patch for the wizard has still NOT been applied; but, I gave up on it long ago.
I don't see it in the patch tracker.

If you don't get your patches applied in time there are three options you have:
1. bug us more
2. become a developer
3. don't do patches

I suppose 3 is a bad option :)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #20 on: October 02, 2013, 12:05:41 pm »
No, Scintilla is not abandoned, but wxScintilla seems to be.
Yes the original wxScintilla is dead. wxSTC is the replacement in the wxWidgets source tree, hence it is not as up-to-date as our fork nor we could use it by now as it is available in wx2.9.x+ only.

Besides us, I am not aware of other meaningful further-developed forks of wxScintilla.

So: Everything related to the scintilla core goes to the scintilla maintainer (Neil Hodges, http://www.scintilla.org), everything related to wxScintilla is our business.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #21 on: October 02, 2013, 12:20:19 pm »
In that case I would like to request including <string> in src/sdk/wxscintilla/src/ScintillaWX.cpp. I still believe that it would be more logical if it was included in the Scintilla core, but they closed the ticket as invalid, so fixing ScintillaWX.cpp seems to be the only remaining option.

Other than that I have two questions:
  • Is there any reasonable way to find all required patches for wxWidgets 2.9 compatibility in trunk (to be able to backport them to 12.11)? The code compiles now, but lacks some of the necessary patches that have been applied recently to work flawlessly. Or is there any new CB release planned in the near future? I would like to allow users to avoid using wxGTK on Mac and this is only possible with wxWidgets 2.9 on recent systems.
  • I opened a new topic about the remaining problems with compiling the code in trunk http://forums.codeblocks.org/index.php/topic,18394.0.html. I would be grateful for help to fix these. The version 12.11 compiles now, but I don't know how to proceed with fixing issues in trunk.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11899
    • Travis build status
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #22 on: October 02, 2013, 01:21:17 pm »
If I were you I'd wait for a while, maybe a release will happen, maybe not...   ::)
Also I won't bother with 12.11 anymore, being marked as stable doesn't mean it is.

p.s. Can you close all you bugs that you've opened for the patches I've applied, because I can track them down. And in the future don't add bugs and patches simultaneously, it makes it harder for us.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #23 on: October 02, 2013, 01:54:00 pm »
I would happily close the tickets, but I don't know how. Do I have sufficient permissions for that?

The problem with the tracker is that it's not too user-friendly. I found a bug, reported it, later I came up with a patch, but bug reports don't allow attachments, so I didn't see a better solution.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11899
    • Travis build status
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #24 on: October 02, 2013, 02:06:36 pm »
List them here and I'll close them.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #25 on: October 02, 2013, 05:35:06 pm »
The following tickets can be closed:

This has been partially fixed (I believe removing the two [or more] remaining lines as described in the ticket is safe & trivial):

The following two require an easy fix (in case that you are willing to fix & close):

Thank you.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11899
    • Travis build status
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #26 on: October 02, 2013, 07:11:09 pm »
Patch #3501 changes some KWIC header, Morten where is the upstream for this project?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline mojca

  • Multiple posting newcomer
  • *
  • Posts: 17
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #27 on: October 02, 2013, 10:42:55 pm »
No, KWIC headers have already been patched. I uploaded a new patch to the same ticket, please take a look at that one. It is only patching src/plugins/contrib/wxContribItems/wxTreeList/src/treelistctrl.cpp, but I don't know if there is any other upstream source for that.

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #28 on: October 06, 2013, 06:52:16 pm »
Morten where is the upstream for this project?
What is an "upstream"?
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 11899
    • Travis build status
Re: C::B and wxWidgets 2.9.5 under Windows
« Reply #29 on: October 06, 2013, 07:17:33 pm »
Morten: The place where this project is maintained.
For example we're called upstream maintainers by distro maintainers. So if we use a library/component then we call them upstream, or at least this is what I do.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]