Menu Icons are gone

[tiwag]

@tiwag: try this but keep a copy of the devel/ dir first. If this fixes it for you too, compare the new devel/ with the copy you kept. We might pinpoint the reason then...

although i thought i would have done something equivalent with completely rebuilding,
i followed your advice and --  YOU ARE RIGHT !!!
with a newly generated devel directory the icons are back again !

now i'll study the differences...
some ideas where to look first ?

[thomas]

@thomas - can you please post your mingw10.dll here

Hmm... don't believe that can be a reason, but ok.

I assume I don't have to post the source to comply with the GPL, too...

[attachment deleted by admin]

[tiwag]

@thomas - can you please post your mingw10.dll here

Hmm... don't believe that can be a reason, but ok.

thomas the nonbeliever is right - my mingwm10.dll is exactly the same as yours ;-)

[Pecan]

Ok folks,

This looks like a keybinder problem. Keybinder replaces
the menuitem name and label even if it doesnt have a
darn binding for the thing.

Any suggestions as to how I should preserve the icon??

thanks
pecan

[thomas]

Now that explains a lot... I have the keybinder plugin disabled... :lol:

[killerbot]

and on linux, I did not build the contribs ..

[killerbot]

turned keybinder off and --> icons back .  yesssssssssssssssss

[tiwag]

just now found independently out that cbKeybinder is guilty - ok - bug is pinpointed !
thx @all !

[Pecan]

I could get busy and look it up, but.....

How is that icon attached to the menuitem label?
Could someone point my nose in an "info" direction?

thanks
pecan

[thomas]

Umm... XRC...  if you want a reference to the bitmap, you will have to call wxMenuItem::GetBitmap, no other way.

[Pecan]

Thanks thomas

That give me a direction in which to start.

thanks
pecan

[Pecan]

Commited Keybinder ver 0.4.4 1/7/2006 10:56 PM

Re: keybinder clobbers menuitems with bitmaps.

It's been a real education tracing through WX262 menu
code this past week. It appears to me that the menu bitmap code
is a paste and forget job. Very disappointing.

The XRC code "owner draws" the bitmap onto the menu, then
the menu code willy nilly turns off the "m_bOwnerDrawn" flag.
Bitmapped menuitems are not supported in WX menu code, only OwnerDrawn.

Reason: Looks like a Win98 thingie. But...

The next time the menuitem is updated, ownerdrawn attributes, bitmaps
etc are clobbered because, of course, the owner drawn code is never called.

If the modifying coder turns owner drawn back on, the width of the
menuitem is ignored, the accelerator is drawn "right aligned", thus
clobbering (drawing over) the menuitem text. Ugly!

Hack:
SetText without OwnerDrawn to guarantee the menuitem width,
then do it again with OwnerDrawn=true to redraw/reinstate the bitmap. Jeeezzh!!!

Code

	// set "un-ownerdrawn" text to preserve menu width
        m_pItem->SetText(newtext);
        //now redraw the menuitem if bitmapped
	if (m_pItem->GetBitmap().GetWidth())
        {   m_pItem->SetOwnerDrawn();
            m_pItem->SetText(newtext);
        }
        //-m_pItem->GetMenu()->UpdateAccel(m_pItem); //<--does nothing       previous SetTExt() didnt

The results are not pretty. The margin between the bitmap and the text is changed,
and the accelerator is vertically misaligned with its siblings  because it's
drawn "right aligned" into the menuitem. Yuk!

So: I'm commiting the "fixed" keybinder, and will now find a way to draw
it as pretty as XRC does it. I think this is important, because we're all
gonna have to mangle a menu someday.

thanks
pecan

[Der Meister]

Well, there is a little problem with the modification you showed here:
wxMenuItem::SetOwnerDrawn() does not exist - at least not in wxGTK 2.6.1 and not in the official documentation of wxWidgets 2.6.2. Maybe it is a wxMSW-specific function (although I could not find something like this in the documentation) but then it should be wrapped with preprocessor macros to be only included on windows. Therefore it should be changed like this:

Code

$ svn diff src/plugins/contrib/keybinder/menuutils.cpp 
Index: src/plugins/contrib/keybinder/menuutils.cpp
===================================================================
--- src/plugins/contrib/keybinder/menuutils.cpp (revision 1676)
+++ src/plugins/contrib/keybinder/menuutils.cpp (working copy)
@@ -109,7 +109,10 @@
         m_pItem->SetText(newtext);
         //now redraw the menuitem if bitmapped
                if (m_pItem->GetBitmap().GetWidth())
-        {   m_pItem->SetOwnerDrawn();
+        {
+#if defined( __WXMSW__ )
+               m_pItem->SetOwnerDrawn();
+#endif
             m_pItem->SetText(newtext);
         }
         //-m_pItem->GetMenu()->UpdateAccel(m_pItem); //<--does nothing previous SetTExt() didnt

I don't know if this still workes - but at least it can be compiled again.

[Pecan]

Is there anyone out there that could test the
Der Meister fix and tell me yea or ney on this.

I dont have a GTK system.

thanks
pecan

Edit:
Looking at the DerMeister fix again....
That looks good, if GTK was working Ok before,
it should work fine with the DerMeister fix.

I'll change it and re-commit

Thanks
pecan

[Pecan]

I've commited keybinder (svn1682) with hopefully
the original GTK menuitem update code.

If someone with GTK would test this and report back,
I'd really appreciate it.

thanks
pecan