Author Topic: Building from the new SF repo  (Read 32880 times)

Online Commaster

  • Almost regular
  • **
  • Posts: 171
Re: Building from the new SF repo
« Reply #15 on: March 30, 2013, 12:01:29 am »
Should be fixed in svn r8926.
svn build rev 8926 (2013-03-29 21:04:23) gcc 4.7.2 Linux/unicode - 64 bit
Thank you very much!
We can now lock this topic, I think...

Offline Folco

  • Regular
  • ***
  • Posts: 343
    • Folco's blog (68k lover)
Re: Building from the new SF repo
« Reply #16 on: March 30, 2013, 09:42:58 am »
Thanks for this quick fix ! And don't be sorry Jens, the work of the CB team is just awesome :D
Kernel Extremist - PedroM power ©

stefanos_

  • Guest
Re: Building from the new SF repo
« Reply #17 on: March 30, 2013, 03:27:40 pm »
Latest revision compiles fine under Debian wheezy, 32-bit but the crashing issue with cleaning "Recent Projects > Clear History" still exists. I ran it via terminal and reports a Segmentation Fault.

Steps taken with gdb:

Code
Loading toolbar...
Initializing plugins...
KeyBinder failed UpdateById on[3401][_Export]
KeyBinder failed UpdateById on[1019][Cu_t]
KeyBinder failed UpdateById on[1018][_Copy]
KeyBinder failed UpdateById on[1020][_Paste]

Program received signal SIGSEGV, Segmentation fault.
0x00000018 in ?? ()
(gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault.
0xb657be48 in ?? () from /lib/i386-linux-gnu/libgcc_s.so.1
(gdb) c
Continuing.
[Thread 0xae05eb70 (LWP 9414) exited]
[Thread 0xb0321b70 (LWP 9379) exited]
[Thread 0xb0b22b70 (LWP 9378) exited]
[Thread 0xb1323b70 (LWP 9377) exited]
[Thread 0xb5fd5880 (LWP 9157) exited]

Program terminated with signal SIGSEGV, Segmentation fault.
The program no longer exists.
(gdb)

I hope it helps a bit; I don't know how to use it properly, therefore show some respect :D

Update: This time decided to throw a window with report: http://pastebin.com/bLqUevvm
« Last Edit: March 30, 2013, 06:35:21 pm by stefanos_ »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Building from the new SF repo
« Reply #18 on: March 30, 2013, 07:54:03 pm »
I hope it helps a bit; I don't know how to use it properly, therefore show some respect :D
No, probably next time try to use the bt command, so the place where it have crashed is visible.

But don't worry this time because I get the crash, too.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Folco

  • Regular
  • ***
  • Posts: 343
    • Folco's blog (68k lover)
Re: Building from the new SF repo
« Reply #19 on: March 31, 2013, 09:41:21 pm »
I confirm that now, it compiles again. Thanks :)
Kernel Extremist - PedroM power ©

stefanos_

  • Guest
Re: Building from the new SF repo
« Reply #20 on: April 01, 2013, 08:19:41 pm »
I hope it helps a bit; I don't know how to use it properly, therefore show some respect :D
No, probably next time try to use the bt command, so the place where it have crashed is visible.

But don't worry this time because I get the crash, too.

I have done so, and I hope it did it properly :D

Here you are: http://pastebin.com/s2LbzixV

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: Building from the new SF repo
« Reply #21 on: April 01, 2013, 09:41:16 pm »
I hope it helps a bit; I don't know how to use it properly, therefore show some respect :D
No, probably next time try to use the bt command, so the place where it have crashed is visible.

But don't worry this time because I get the crash, too.

I have done so, and I hope it did it properly :D

Here you are: http://pastebin.com/s2LbzixV
The crash happens, because the pointers holding the wxFileHistory-object for the projects and the files in MainFrame get recreated, but the pointers stored in the starthere-page are not updated.

Can you please test the attached patch ?
« Last Edit: April 01, 2013, 09:44:11 pm by jens »

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Building from the new SF repo
« Reply #22 on: April 01, 2013, 11:11:18 pm »
Can you please test the attached patch ?
Don't bother, I'm currently fixing this in a rather brutal way:)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: Building from the new SF repo
« Reply #23 on: April 01, 2013, 11:26:07 pm »
Can you please test the attached patch ?
Don't bother, I'm currently fixing this in a rather brutal way:)
The patch already by resetting the two pointers in the startherepage class at the end of MainFrame::InitializeRecentFilesHistory(), that's the only place where the pointers get recreated in MainFrame.
Another (probably better) approach would be to have a (probably protected?) getter-function in MainFrame for the pointers, make both classes friends and always fetch the pointers if needed (not too expensive, because this happens not very often).

stefanos_

  • Guest
Re: Building from the new SF repo
« Reply #24 on: April 02, 2013, 12:06:58 am »
yep, the patch works just fine. Shall I fetch the latest updates and adjust to those?

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Building from the new SF repo
« Reply #25 on: April 02, 2013, 12:36:47 am »
Jens:
A really better approach is what I'm doing -> remove the code duplication by extracting the code for a single list in its own class.
Then I'll see if this logic can be simplified, further.
Please don't commit.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

stefanos_

  • Guest
Re: Building from the new SF repo
« Reply #26 on: April 02, 2013, 02:31:27 pm »
@Jens: The issue remains the same with Windows XP SP3, TDM's GCC 4.7.1-2, 32-bit, wxMGW-2.18.12; it crashes upon cleanup.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: Building from the new SF repo
« Reply #27 on: April 03, 2013, 11:19:01 pm »
Check trunk head for the changes. Report any problems you encounter with the new version.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

stefanos_

  • Guest
Re: Building from the new SF repo
« Reply #28 on: April 04, 2013, 11:05:26 am »
With the latest revision, it compiles on Windows and cleans the project history just fine. I will compile the latest revision on Debian wheezy too and let you know if not today, by tomorrow.

Cheers

stefanos_

  • Guest
Re: Building from the new SF repo
« Reply #29 on: April 06, 2013, 03:11:34 pm »
Under Debian wheezy, the latest revision throws the following errors:

Code
startherepage.h: In member function 'void StartHerePage::SetProjectsFiles(const wxFileHistory*, const wxFileHistory*)':
startherepage.h:32:74: error: no match for 'operator=' in '((StartHerePage*)this)->StartHerePage::m_projects = projects'
startherepage.h:32:74: note: candidate is:
recentitemslist.h:10:7: note: RecentItemsList& RecentItemsList::operator=(const RecentItemsList&)
recentitemslist.h:10:7: note:   no known conversion for argument 1 from 'const wxFileHistory*' to 'const RecentItemsList&'
startherepage.h:32:94: error: no match for 'operator=' in '((StartHerePage*)this)->StartHerePage::m_files = files'
startherepage.h:32:94: note: candidate is:
recentitemslist.h:10:7: note: RecentItemsList& RecentItemsList::operator=(const RecentItemsList&)
recentitemslist.h:10:7: note:   no known conversion for argument 1 from 'const wxFileHistory*' to 'const RecentItemsList&'
main.cpp: In member function 'void MainFrame::InitializeRecentFilesHistory()':
main.cpp:2192:48: error: 'm_pProjectsHistory' was not declared in this scope
main.cpp:2192:68: error: 'm_pFilesHistory' was not declared in this scope
make[3]: *** [main.o] Error 1
make[3]: Leaving directory `/home/stefanos/svn_code/CodeBlocks/src/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/stefanos/svn_code/CodeBlocks/src/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/stefanos/svn_code/CodeBlocks/src'
make: *** [all-recursive] Error 1