Column editing in C::B 12.11

[fubo]

Hi all,
I noticed that column editing in C::B 12.11 is totally broken, am I right?
Thanks.

[oBFusCATed]

Explanation? Example?

[fubo]

Example1: pressing ALT and drawing a vertical line, I want to write an all lines. It writes only on latest.
Example2: pressing ALT and drawing a vertical line, pressing TAB should indent the text to the right. Now it makes a lot of mess deleting pieces of text.

[Jenna]

The first works if you set the options in "Settings -> Editor -> Margins and caret -> Selections" correctly.
The second does not work and might be a bug or a scintilla limitation ( I will see if I find the time to look into it deeper).

[fubo]

Thanks, example 1 is now working.

[oBFusCATed]

The second does not work and might be a bug or a scintilla limitation ( I will see if I find the time to look into it deeper).

It works in scite and I think our smart indenter messes things.

[Jenna]

The second does not work and might be a bug or a scintilla limitation ( I will see if I find the time to look into it deeper).

It works in scite and I think our smart indenter messes things.

If all smartindent-plugins are switched off it still does not work.
But it works as expected, if I select several lines with Ctrl-key pressed.
So it might be an issue with rectangle-selection (with width 0 in this special case).

[oBFusCATed]

If all smartindent-plugins are switched off it still does not work.

For me it works if I compile cb with cb, no contrib plugins. Gentoo linux, latest head.

[Jenna]

If all smartindent-plugins are switched off it still does not work.

For me it works if I compile cb with cb, no contrib plugins. Gentoo linux, latest head.

Good catch, I found the "evil" plugin, it's the spellchecker.

Thanks, example 1 is now working.

If you either disable the spellchecker-plugin completetely via "Plugins -> Manage plugins" or at least disable online spellchecking from "Settings -> Editor -> SpellChecker" the second example should work also.

[oBFusCATed]

Good catch, I found the "evil" plugin, it's the spellchecker.

Strange...

[fubo]

If you either disable the spellchecker-plugin completetely via "Plugins -> Manage plugins" or at least disable online spellchecking from "Settings -> Editor -> SpellChecker" the second example should work also.

Thanks! I confirm it on Win7 x64. Now it works!

[danselmi]

Good catch, I found the "evil" plugin, it's the spellchecker.

I will look into it

[danselmi]

I still don't know what the problem is:

Code

void OnlineSpellChecker::DoSetIndications(cbEditor* ctrl)const // called OnUpdate
...
    if(stc->SelectionIsRectangle() || (stcr && stcr->SelectionIsRectangle())) return; // workaround so Example2 is working
    stc->IndicatorSetStyle(GetIndicator(), wxSCI_INDIC_SQUIGGLE);
    // when we return here, after IndicatorSetStyle() the Example 2 is not working
...

Any ideas?

[Jenna]

I still don't know what the problem is:

Code

void OnlineSpellChecker::DoSetIndications(cbEditor* ctrl)const // called OnUpdate
...
    if(stc->SelectionIsRectangle() || (stcr && stcr->SelectionIsRectangle())) return; // workaround so Example2 is working
    stc->IndicatorSetStyle(GetIndicator(), wxSCI_INDIC_SQUIGGLE);
    // when we return here, after IndicatorSetStyle() the Example 2 is not working
...

Any ideas?

I see if I find the time to look into it this weekend.

[Jenna]

Please test the attached patch and give feedback.

It uses the already existing oldCtrl to ensure the calls to IndicatorSetStyle(), IndicatorSetForeground() and IndicatorSetUnder() are done only once for each control and not every time DoSetIndications() is called.

Ths will work unless another part of C::B will use (amd modify) the same indicator, what (most likely) works with the existing code, but would probably lead to other issues.