Author Topic: EditorTweaks: new option 'Convert Matching Braces' : little bug  (Read 30314 times)

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #45 on: November 05, 2012, 08:03:59 pm »
Ok, I'm leaving this one to you guys.
I am not really looking into it. Please continue testing, if possible. I was just the one breaking it. :P
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline Alpha

  • Developer
  • Lives here!
  • *****
  • Posts: 1513
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #46 on: November 06, 2012, 12:55:36 am »
Oh dear... I'm afraid I just screwed the compatibility with the patch after the last commits of mine (renaming of SmartIndent). Maybe you can provide an updated version? Sorry - I didn't have that in mind.
Not a problem; update attached.

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #47 on: November 06, 2012, 01:20:07 pm »
OK. If Morten doesn't break anything in between,  ;D I will test and commit tonight.
« Last Edit: November 06, 2012, 02:46:27 pm by dmoore »

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #48 on: November 06, 2012, 03:37:57 pm »
OK. If Morten doesn't break anything in between,  ;D I will test and commit tonight.
I'll keep my fingers away - I promise...
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #49 on: November 07, 2012, 03:53:05 am »
Committed rev 8514. FYI - I had to clean out my build settings before this one worked properly, but this was probably due to the other SmartIndent changes that Morten made.

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #50 on: November 07, 2012, 05:06:51 am »
In rev 8515 I fixed a bug that prevented Convert Matching Braces from being saved. I also tidied up the naming of the config settings for EditorTweaks. Unfortunately, this will means users will need to redo any previously set aligner settings (sorry!)

Offline Alpha

  • Developer
  • Lives here!
  • *****
  • Posts: 1513
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #51 on: November 09, 2012, 04:46:41 am »
Committed rev 8514.
Uh-oh... looks like I killed three of the lexers:
Code: [Select]
Index: src/sdk/resources/lexers/lexer_batch.xml
===================================================================
--- src/sdk/resources/lexers/lexer_batch.xml    (revision 8529)
+++ src/sdk/resources/lexers/lexer_batch.xml    (working copy)
@@ -78,7 +78,6 @@
                     BoxCommentMid=""
                     BoxCommentEnd=""
                     CaseSensitive="0"
-                    CaseSensitive="1"
                     LexerCommentStyles="1"
                     LexerCharacterStyles=""
                     LexerStringStyles=""
Index: src/sdk/resources/lexers/lexer_css.xml
===================================================================
--- src/sdk/resources/lexers/lexer_css.xml      (revision 8529)
+++ src/sdk/resources/lexers/lexer_css.xml      (working copy)
@@ -110,7 +110,6 @@
                     BoxCommentMid=" * "
                     BoxCommentEnd=" */"
                     CaseSensitive="0"
-                    CaseSensitive="1"
                     LexerCommentStyles="9"
                     LexerCharacterStyles=""
                     LexerStringStyles="13,14"
Index: src/sdk/resources/lexers/lexer_cmake.xml
===================================================================
--- src/sdk/resources/lexers/lexer_cmake.xml    (revision 8529)
+++ src/sdk/resources/lexers/lexer_cmake.xml    (working copy)
@@ -542,10 +542,7 @@
                     CaseSensitive="0"
                     LexerCommentStyles="1"
                     LexerStringStyles="2,3,4"
-                    CaseSensitive="1"
-                    LexerCommentStyles="1"
                     LexerCharacterStyles=""
-                    LexerStringStyles="2,3,4"
                     LexerPreprocessorStyles=""/>
         </Lexer>
 </CodeBlocks_lexer_properties>

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #52 on: November 09, 2012, 12:59:08 pm »
Is it just these 3?

Offline Alpha

  • Developer
  • Lives here!
  • *****
  • Posts: 1513
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #53 on: November 09, 2012, 10:00:52 pm »
From what I can tell, yes.  In the application log for revisions 8514 - 8529, the "Loading lexer_*" failed on these three.
(It seems I had not been careful enough in modifying all the lexers so quickly to ensure valid XML files :-\.)

Offline dmoore

  • Developer
  • Lives here!
  • *****
  • Posts: 1576
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #54 on: November 09, 2012, 10:41:56 pm »
Looks like Morten got all these?

Offline Alpha

  • Developer
  • Lives here!
  • *****
  • Posts: 1513
Re: EditorTweaks: new option 'Convert Matching Braces' : little bug
« Reply #55 on: November 12, 2012, 02:45:22 am »
Yes.  (Sorry, forgot to respond.)