Fixed annoying FindDlg bugs

[knue]

I have fixed a couple of bugs in the FindDlg:
- The FindDlg does not crash, if you "find in files"
- calling the Dlg sets the focus now properly
- Backspace works now in the ComboBox
- small fix for the update of some ui-elements(in "find in files", "search path" and that stuff when you play with the scope setting and restart the dlg)

EDIT: I use the linux-version. Perhaps some bugs can only be seen there.

[attachment deleted by admin]

[mandrav]

Please use the patch tracker. Posting patches here, is certain to be overlooked/lost.

[280Z28]

Please use the patch tracker. Posting patches here, is certain to be overlooked/lost.

What's that?

Edit nevermind i found it.

[knue]

Perhaps somebody can tell whether this patch was useful.

[tiwag]

Perhaps somebody can tell whether this patch was useful.

want to test it soon but currently is only windows build possible for me.
but i want to collect infos and ideas about Search features

see also
http://forums.codeblocks.org/index.php?topic=1678.msg12347#msg12347

thanks

[knue]

Why does nobody apply my patch?
The finddlg in the svn repository is still buggy.

[rickg22]

knue: I'm afraid we're running out of developers. I'm focusing 100% on the code completion annoyances - plus, we need someone who tests your patches first. Look in the sourceforge page, there are some beta-testers there, they might test your patches. It might also work if you edit your submission and assign it to Thomas. He's good at patching

[takeshimiya]

Yeah, we need an official patch reviewer ASAP

[rickg22]

Is me22 still around? He's fixed LOTS of unicode errors in patches before.

[tiwag]

in the past i was using Ubuntu 5.04 and was using wxGTK-2.6.0 Ansi build to build Codeblocks - but this isn't contemporary any longer.

since Monday i've set up a new Ubuntu 5.10 with wxGTK-2.6.1-Unicode and have built the latest CodeBlocks from SVN.
( there were a few small problems, but now with SVN rev. 1606 all builds fine !!! )

i wanted to look at and test this (and other pending unicode-) patch(es) but i need(ed) some time to create a rock-solid test-environment.
sorry for the delay ... 

[edit]
btw.  @ knue
which linux build do you use ?
neither the Find nor the FindinFiles dialogs does crash in its current state in my actual unicode build  :?

[280Z28]

knue: I'm afraid we're running out of developers. I'm focusing 100% on the code completion annoyances - plus, we need someone who tests your patches first. Look in the sourceforge page, there are some beta-testers there, they might test your patches. It might also work if you edit your submission and assign it to Thomas. He's good at patching

I'll volunteer if you ever feel like taking me up on the offer.

[killerbot]

I'll volunteer too, I am getting to know more and more cb code through applying patches as it is.

Lieven

[knue]

@tiwag: The current svn version does not crash anymore. Besides the UI-update bugs seem to be fixed. But the focus and backspace problems remain.

Now we have more then double work

I will test my patch today by myself with the unicode version.

I use gentoo linux with wxGTK-2.6.2 and (now) unicode support.

I am also interessted in helping with developing. I have not that much time. But I can help fixing bugs (especially for the linux version) and integrating features I'd like to see in codeblocks.

What about this: Support for the "wine mingw32" compiler. So you can build the windows version within linux. Actually codeblocks is powerful enough to handle that but there are a couple of bugs when you fiddle around with compiler options. Besides I like to see the Devpak-Plugin in the linux version for this purpose.

[takeshimiya]

Some thoughs: GCC cross-compiling (mingw32, etc), cygwin, and msys support out-of-the-box.

How?

[knue]

Hmm the unicode version does not start at all. So I can't test my patch

This is my error message:

E: A

@Takeshi Miya: Well, just try
$ wine mingw32.exe test.cpp -o test.exe
this test.exe will start under windows.

[takeshimiya]

I know, but I'm talking of supporting cross-compilation without wine.
And about supporting from C::B the following environments: cross-mingw32, cygwin, cross-cygwin, msys.

[duncanka]

I've fixed another minor error in the FindDlg code (I think): if you switched to the "Find in Files" tab before typing the text to search for, the dialog did not save the search term in the search history.  I've created a patch, but I can't test it at the moment.  Could someone test whether the patch below (the forum wouldn't let me attach it as a file) works before I submit it to the tracker?

Code: diff

Index: finddlg.cpp
===================================================================
--- finddlg.cpp	(revision 2173)
+++ finddlg.cpp	(working copy)
@@ -128,7 +128,7 @@
 
 	// save last searches (up to 10)
     wxComboBox* combo = XRCCTRL(*this, "cmbFind1", wxComboBox);
-	if (!m_Complete)
+	if ( IsFindInFiles() )
         combo = XRCCTRL(*this, "cmbFind2", wxComboBox);
     wxArrayString previous;
     for (int i = 0; (i < combo->GetCount()) && (i < 10); ++i)