Debugger branch: Placement of Windows

[MortenMacFly]

BTW, notice that the PlaceWindow method uses "pdlBest" as default argument for the method. So unless its really provided/enforced by the caller, the following code:

Code

    if (mode == pdlBest)
        the_mode = cfg->ReadInt(_T("/dialog_placement/dialog_position"), (int) pdlCentre);
    else
        the_mode = (int) mode;

...makes sure that the method does the right thing which is "centre" by default unless the user said different, as you see. So if there is no good reason you should always call PlaceWindow without additional argument.

[ollydbg]

So if there is no good reason you should always call PlaceWindow without additional argument.

You mean we should always do like below (call PlaceWindow() with only first parameter)

Code

     CompilerSettingsDlg dlg(this);
     PlaceWindow(&dlg);

In this case, If I would like place dlg in the center of the screen. I need to check on both:
View->Enhance multi-monitor dialog place and Move to "head up" position. Otherwise, the dialog place badly as my original post in this discussion thread.

That's not intuitive, because I work on a Single monitor Laptop.

[MortenMacFly]

That's not intuitive, because I work on a Single monitor Laptop.

But that's what PlaceWindow is for. If you want to change the default behaviour of of dialogs you should position them in their constructor before calling PlaceWindow. PlaceWindow IMHO is only for multi-monitor placement.

[ollydbg]

That's not intuitive, because I work on a Single monitor Laptop.

But that's what PlaceWindow is for. If you want to change the default behaviour of of dialogs you should position them in their constructor before calling PlaceWindow. PlaceWindow IMHO is only for multi-monitor placement.

Ok, I presume that those two options should not be selected.
But if I do not select both, the dialog position is too bad. see the screen shot of my whole screen.

I even can't see the buttons of the dialog. This is the same behavior in both Windows and Ubuntu 10.10.

[MortenMacFly]

I even can't see the buttons of the dialog. This is the same behavior in both Windows and Ubuntu 10.10.

That's why I said its an improper design of the dialog itself then. the constructor should make everything needed/possible to properly position the dialog initially. Then PlaceWindow may adjust it to the users needs in case of multiple monitors.

For the debugger settings pane I see two drawbacks in its contructor:
1.) its wxSmith based, but sets:

Code

	SetMinSize(wxSize(600, 600));
	SetSize(wxSize(600, 600));

manually -> no good style.
2.) it does not center itself on the parent (if any).

Both should be adjusted using wxSmith. Than you should be happy.

The same applies to all other dialogs that do not behave / position correctly.

[oBFusCATed]

Sorry, but these two calls are needed in order to make the dialog large enough and they are there because a bug/missing feature of wxSmith.
The missing feature/bug is that wxSmith adds the setsize/setminsize, right after the creation of the dialog and thus they are useless and doesn't enforce the minimal size.

If you know how to make it work show patches, I do not.

[MortenMacFly]

If you know how to make it work show patches, I do not.

Well surely you should not adjust the min-size flag of the dialog (this is useless most of the time), but the controls on the dialog, that are too small - such as the wxTreeBook.

If I set the min-size of the wxTreeBook (and only that flag, otherwise you screw sizing) to e.g. 500x500 using wxSmith it works just fine.

[oBFusCATed]

Can I see a patch?

[MortenMacFly]

Can I see a patch?

Are you serious? OK, here it is at your service - what I did:
- remove the hand-crafted SetSize stuff
- open the dialog in wxSmith
- adjust the min size of the tree control
- hit compile.

Not sure why this was too hard for you, but anyways...

[oBFusCATed]

Not sure why this was too hard for you, but anyways...

Because you had the changes already made and to make sure I've understood what you've meant.

Any idea how to force the dialog to auto-resize in order to fit the panel for the debuggergdb options?
Currently using your patch, the disassembly options are clipped.

ollydbg: Does Morten's patch fix your problem?

[ollydbg]

ollydbg: Does Morten's patch fix your problem?

No, I just test this patch, but the problem still exists. 

[oBFusCATed]

2.) it does not center itself on the parent (if any).

Both should be adjusted using wxSmith. Than you should be happy.

How do we set the 2.) in wxSmith? Using the ExtraCode field?

[MortenMacFly]

Any idea how to force the dialog to auto-resize in order to fit the panel for the debuggergdb options?
Currently using your patch, the disassembly options are clipped.

IMHO, the panels are badly design because they do not allow expanding (thats what I recall from the options). Maybe that's the issue. (Cannot look into it ATM.)

2.) it does not center itself on the parent (if any).

Yes, enable the "Centered" flag in the wxSmith options (of the wxScrollingDialog). - I didn't do it in the patch.

[ollydbg]

@morten:
Did you fixed this in the trunk? rev7941? I don't have many time to test it right now.

[MortenMacFly]

Did you fixed this in the trunk? rev7941? I don't have many time to test it right now.

The first part, yes. That actually what I sent to oBFusCATed. To be honest: It was actually more an accident because in the revision before, a file of that patch file slipped in. Thus I thought: "What the heck lets try...". ;-)

It works just fine here btw... so I don't expect any issues - its no functional change, just layout.