Author Topic: The 06 March 2011 build (7040) is out.  (Read 34574 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12121
    • Travis build status
Re: The 06 March 2011 build (7040) is out.
« Reply #30 on: April 04, 2011, 10:31:26 am »
Any ideas?
Have you seen the initializers in c++-0x?
Your suggestion probably will break the call tip in this mode.

Also what you are talking about is not directly related to my patch, am I correct?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5247
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: The 06 March 2011 build (7040) is out.
« Reply #31 on: April 04, 2011, 01:33:24 pm »
Any ideas?
Have you seen the initializers in c++-0x?
Your suggestion probably will break the call tip in this mode.
No, so maybe, we can leave it as it is.

Quote
Also what you are talking about is not directly related to my patch, am I correct?
correct! I can't find any thing wrong.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12121
    • Travis build status
Re: The 06 March 2011 build (7040) is out.
« Reply #32 on: April 04, 2011, 02:06:25 pm »
No, so maybe, we can leave it as it is.
We can add a counter and if the counter is greater than 1000 characters (for example), we stop the search :)
Can you do some measurements, if this is really a performance problem?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5247
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: The 06 March 2011 build (7040) is out.
« Reply #33 on: April 04, 2011, 02:10:39 pm »
No, so maybe, we can leave it as it is.
We can add a counter and if the counter is greater than 1000 characters (for example), we stop the search :)
Yes, 1000 chars is quite enough.

Code: [Select]
Can you do some measurements, if this is really a performance problem?add a timer to test it? and log out the time? :D

PS:
If we catch the new added char every time, then we can avoid counting the commas every time we do the calltip. :D I mean, we can only check the new added char, if it is a commas, then we can increase the previous value.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12121
    • Travis build status
Re: The 06 March 2011 build (7040) is out.
« Reply #34 on: April 04, 2011, 03:10:58 pm »
Code: [Select]
Can you do some measurements, if this is really a performance problem?add a timer to test it? and log out the time? :D
My idea you to do it, because I don't care, too much about it :)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 12121
    • Travis build status
Re: The 06 March 2011 build (7040) is out.
« Reply #35 on: April 09, 2011, 12:05:27 pm »
The patch is committed, so please test again :)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5247
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Re: The 06 March 2011 build (7040) is out.
« Reply #36 on: April 09, 2011, 04:48:20 pm »
The patch is committed, so please test again :)
Nice, it works fine!
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.