Author Topic: SpellChecker plugin  (Read 92777 times)

Offline danselmi

  • Developer
  • Almost regular
  • *****
  • Posts: 202
Re: SpellChecker plugin
« Reply #30 on: September 09, 2010, 02:04:24 pm »
Therefore we should think about what could be easier or reasonable if the status bar offers such a functionality.
True. I would (however) wait for danselmi's answer on that topic concerning the readiness:
Also I remember that danselmi ones said it's only a feasibility study.
It was a feasibility study, but I completely reworked it since then.

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5177
Re: SpellChecker plugin
« Reply #31 on: September 09, 2010, 02:33:18 pm »
maybe the time has come to make a contrib plug-in out of this.

What things might be blocking at this moment ?
- windows build ok ?
- linux build ?
- everything portable ?
- dependencies to things outside CB ?
- ...


Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: SpellChecker plugin
« Reply #32 on: September 09, 2010, 02:36:12 pm »
- windows build ok ?
Yes.

- everything portable ?
Looks like that, yes.

What things might be blocking at this moment ?
[...]
- dependencies to things outside CB ?
Not really stopping, but something to think about: You'll need a dictionary for your target language which I don't want to put into SVN (it makes no sense). Without that SpellChecker will not work, so we need some clarification (e.g. on first start) what to do and where to get them. That's a "feature" which is missing.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline laube

  • Single posting newcomer
  • *
  • Posts: 3
Re: SpellChecker plugin
« Reply #33 on: September 09, 2010, 02:59:23 pm »
wow great news!

while i was using the online-spellchecker I have done some more changes to it.

The patch "online-spellchecker-style-fix.patch" implements the following:
 - spellchecking in xml files (OnlineSpellChecking.xml)
 - fixes the problem with style change in the middle of a word
 - personal dictionary file load/save.
   some notes about the dictionary file load/save: currently it locates the dictionary in the following Paths: sdConfig | sdBase. Maybe this needs some change.

The patch "online-spellchecker-efficiency.patch"
this path improves the personal dictionary efficiency by using a wxSortedArrayString and the style lookup by using a set. This patch is for efficiency only. (especially the style lookup should be efficient because it is done for every character.)

I hope these patches further improve the plugin!

Both patches are for revision 34 of the plugin.

laube

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5177
Re: SpellChecker plugin
« Reply #34 on: September 09, 2010, 04:12:13 pm »
It is up to danselmi to "prepare" the plug-in, and tackle the concerns about the dictionary, have a look at the above mentioned patches. Once that is done, we can add it to contrib.

Sounds some exciting functionality is coming ...

Offline danselmi

  • Developer
  • Almost regular
  • *****
  • Posts: 202
Re: SpellChecker plugin
« Reply #35 on: October 18, 2010, 10:34:55 pm »
Hi

The patches from laube are applied, thanks a lot.

I tried to explain how to install a dictionary in the wiki:
http://wiki.codeblocks.org/index.php?title=SpellChecker
and added a link to it in an AnnoyingDialog and to the config panel.

The following points are still open:
  • The status bar patch is not reviewed (or at least I have no feedback)
  • The personal dictionary does not change if the active language changes
« Last Edit: October 18, 2010, 10:37:51 pm by danselmi »

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: SpellChecker plugin
« Reply #36 on: October 19, 2010, 07:33:33 am »
The following points are still open:
  • The status bar patch is not reviewed (or at least I have no feedback)
I've applied your patch (in a modified version) to trunk for testing. I am using it since "day 1" without any issues. If somebody complains we can revert this commit easily. In addition I would welcome if you apply the project clean-up patch attached to this post. It modifies the project files to be more consistent with the other plugins.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline danselmi

  • Developer
  • Almost regular
  • *****
  • Posts: 202
Re: SpellChecker plugin
« Reply #37 on: October 20, 2010, 11:06:48 pm »
... In addition I would welcome if you apply the project clean-up patch attached to this post. It modifies the project files to be more consistent with the other plugins.
Applied. I really like to thank MortenMacFly for all the tests/patches/assistance.

  • The personal dictionary does not change if the active language changes
Is now solved in rev 39.

So I have no more open points!

danselmi

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: SpellChecker plugin
« Reply #38 on: October 26, 2010, 08:16:15 am »
So I have no more open points!
I have some: After the last update SpellChecker keeps asking me on startup of C::B to setup the folders to the dictionaries (which are correct btw). I assume it keeps asking because I don't have index files for the dictionaries. Unfortunately I don't know where to get them (the rest I got from OpenOffice.org) and as it works well without, too I would suggest you make the index file optional to avoid this bugging on startup.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline danselmi

  • Developer
  • Almost regular
  • *****
  • Posts: 202
Re: SpellChecker plugin
« Reply #39 on: October 26, 2010, 01:02:30 pm »
I have some: After the last update SpellChecker keeps asking me on startup of C::B to setup the folders to the dictionaries (which are correct btw).
Do you mean the AnnoyingDialog? Does it ask even after you told it to "Don't Annoy me again!"?
« Last Edit: October 26, 2010, 03:30:15 pm by danselmi »

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: SpellChecker plugin
« Reply #40 on: October 26, 2010, 09:15:42 pm »
Do you mean the AnnoyingDialog? Does it ask even after you told it to "Don't Annoy me again!"?
Yes I mean that. And no: It does not ask anymore. However, as not having the index file does not limit the functionality I believe this dialog should not show up every time. Sure thing that the other two files are required and setup correctly. My point is, that for some dictionaries you don't get the index files. So the dialog would impose you did something wrong which isn't the case.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: SpellChecker plugin
« Reply #41 on: October 26, 2010, 09:23:54 pm »
...wait! I had a look at the code: You seem to always show this dialog, no matter if the settings are OK or not. Is that right? I think in that case you really should check if the user needs to be informed - that's only the case when the settings are incorrect. Otherwise this will surely lead to confusion (as in my case... ;-)).
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline danselmi

  • Developer
  • Almost regular
  • *****
  • Posts: 202
Re: SpellChecker plugin
« Reply #42 on: October 26, 2010, 10:59:16 pm »
...wait! I had a look at the code: You seem to always show this dialog, no matter if the settings are OK or not. Is that right? I think in that case you really should check if the user needs to be informed - that's only the case when the settings are incorrect. Otherwise this will surely lead to confusion (as in my case... ;-)).
So, I added a check if dictionaries are present and the dialog wil not be shown then.

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9496
Re: SpellChecker plugin
« Reply #43 on: October 27, 2010, 05:42:30 pm »
So, I added a check if dictionaries are present and the dialog wil not be shown then.
Aaaah! Nice. :-) :)

Guess it's time to move it into the main repo I'd say. Didn't killerbot wanted to take care of it? Any comments/thoughts?
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: http://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: http://wiki.codeblocks.org/index.php?title=FAQ

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5177
Re: SpellChecker plugin
« Reply #44 on: October 27, 2010, 07:52:51 pm »
I will/can take care of it ;-)