Splitting debugger in two - specific debugger and common GUI

[ollydbg]

a silly question:

If the new debugger plugin use the "MI" interface, can we still enter some command in “CLI” mode as the current implementation?

[oBFusCATed]

If the new debugger plugin use the "MI" interface, can we still enter some command in “CLI” mode as the current implementation?

Yes you can, look at the gdb docs for details.

[ollydbg]

Yes you can

Ok, this is an enough good answer. thanks.

[oBFusCATed]

Next patch: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0015.2.patch

1. fixes formatting
2. improves the parsing of watch variables

Unittest project for the debugger plugin: http://smrt.is-a-geek.org/codeblocks/patches/dbg/test_dbg.zip

1. extract the zip file in the src/ directory
2. add the test project in a workspace with the codeblock-unix.cbp
3. make codeblocks to depend on the test project

The provided project is linux only and requires unittest++ to compile.

Any feedback is welcome

[oBFusCATed]

OK, Next patch: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0016.0.patch

What it does:
1. Adds another command step into instruction.
1.1. Added toolbar button (please add the proper icons from the nightly thread)
1.2. Added menu item
2. Rearranges the icons on the toolbar a bit

[oBFusCATed]

And another one: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0016.1.patch

Fixed this bug:

At first no window was ticked. I clicked on "Watches" (which was already visible), and it go its tick. Disassembly window was not shown. I clicked on it, I got it, and the tick was also there. CPU Registers was shown from the beginning, never clicked it, never got the tick.

[cbexaminr]

FWIW -

In svn branch wxpropgrid_debugger, file plugins\debuggergdb\gdb_commands.h, "class GdbCmd_TooltipEvaluation", routine "void ParseOutput(const wxString& output)", toward the end of the routiine, I think there is a problem with the variable s_pWin.

It appears some code was added (relative to current trunk) to avoid invoking the tipwindow if the mouse has moved.  As a result of that addition, it seems s_pWin can be left with a value of an item that was "Close()"ed in a previous iteration, such that subsequent attempts to "Close()" that old item could occur, which might be a bad thing.

Didn't see anywhere else where s_pWin was being cleared to avoid this potential problem, but I may be overlooking something - and I don't know for sure that the "Close()" will render the item invalid, but...

it looks suspicious to me.

[oBFusCATed]

Will look at it...

[oBFusCATed]

Next patch: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0016.3.1.patch

1. Added s_pWin = NULL in GdbCmd_TooltipEvaluation::ParseOutput
2. Added the check if the terminal opening has finished in a loop. The terminal should open faster. Also it should be detected correctly if it is started on a slower computer.
3. Fixed parsing of std::string = "test,test" in the watches window
4. Fixed "Catch exception" on windows
5. Fixed some "Do not run debuggee bugs"
5.1. "tbreak" command was emitted, when the debug/continue button was hit
5.2. "run" command was emitted, when in remote debugging mode, now emits the correct "cont"
5.3. "start" command was emitted, now the correct "run" is emitted

Test please

[oBFusCATed]

Next patch: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0016.4.patch

1. Combined "Debug -> Start" and "Debug -> Continue" in one menu item
2. Moved "Debug -> Run to Cursor" below "Stop debugger"
3. Implemented interrupting the debugger while remote debugging (see this thread for details http://forums.codeblocks.org/index.php/topic,12412.0.html )
4. Fixed a warning

Test again please...

[MortenMacFly]

BTW: Did you already try the new official 7.2 debugger from MinGW?!

http://sourceforge.net/projects/mingw/files/MinGW/BaseSystem/GDB/GDB-7.2/gdb-7.2-1-mingw32-bin.tar.lzma/download

[oBFusCATed]

No, it is not available in gentoo, for some reason

[oBFusCATed]

Next patch: http://smrt.is-a-geek.org/codeblocks/patches/dbg/dbg_refactor0016.5.patch

1. Fixed some bugs related to the auto switch mode
1.1. Switch to the valid frame even when the backtrace windows is closed
1.2. If we're doing to update the backtrace, don't sync the editor. This prevents a popup to show when it is not needed.
2. Autosize the File column in the backtrace window

Morten, please merge trunk to debuggers branch, so I can test the fix for the loggers...

[oBFusCATed]

Morten: can you revert the change in MainFrame::ScanForPlugins() in r5795?
I've accidentally removed the code that searches for plugins in the user's directory, bad me, bad

The change should be something like this:

Code

Index: src/src/main.cpp
===================================================================
--- src/src/main.cpp    (revision 6571)
+++ src/src/main.cpp    (working copy)
@@ -1010,11 +1010,16 @@
 
     PluginManager* m_PluginManager = Manager::Get()->GetPluginManager();
 
-    // global paths
-    wxString path = ConfigManager::GetPluginsFolder(true);
+    // user paths first
+    wxString path = ConfigManager::GetPluginsFolder(false);
     Manager::Get()->GetLogManager()->Log(_("Scanning for plugins in ") + path);
     int count = m_PluginManager->ScanForPlugins(path);
 
+    // global paths
+    path = ConfigManager::GetPluginsFolder(true);
+    Manager::Get()->GetLogManager()->Log(_("Scanning for plugins in ") + path);
+    count += m_PluginManager->ScanForPlugins(path);
+
     // actually load plugins
     if (count > 0)
     {

[MortenMacFly]

Morten: can you revert the change in MainFrame::ScanForPlugins() in r5795?

Done.

BTW: In fact I was always curious about that change and never applied it in my local copy. But I forgot to discuss this with you. Glad it's solved now. :-)