Code::Blocks Forums

User forums => Using Code::Blocks => Topic started by: MortenMacFly on October 08, 2008, 08:39:24 am

Title: SPLITTED: wxScintilla (was: Re: Incremental Search)
Post by: MortenMacFly on October 08, 2008, 08:39:24 am
Looks good, though highlighting didn't work for me at all.
Might be the same problem taht Mario has (and me with XP on my Laptop as I just found out).
Works *very* well for me on XP (including the highlighting...).
But sure I am using more recent version of wxScintilla / Scintilla working very smooth for the last "years".
Probably it's finally time for a huge component-update-commit???
Yiannis?!
Title: Re: Incremental Search
Post by: mandrav on October 08, 2008, 09:52:28 am
But sure I am using more recent version of wxScintilla / Scintilla working very smooth for the last "years".
Probably it's finally time for a huge component-update-commit???
Yiannis?!

If you tested it and found it working nice, update it. What are you waiting for? ;)
Title: Re: Incremental Search
Post by: MortenMacFly on October 08, 2008, 11:35:21 am
What are you waiting for? ;)
You were the one always telling me not to do as this is a major component... :lol:

But honestly: I'll prepare and do the step. Hence it still needs testing on Linux (although it works on my Linux box...)
Title: Re: Incremental Search
Post by: dje on October 08, 2008, 11:37:23 am
What's new in "your" version Morten ?

Dje
Title: Re: Incremental Search
Post by: mandrav on October 08, 2008, 01:00:24 pm
What are you waiting for? ;)
You were the one always telling me not to do as this is a major component... :lol:

I was telling you not to do it without extensive testing. But since you are testing it for "years", how can I say no? :lol:
Title: Re: Incremental Search
Post by: killerbot on October 08, 2008, 01:31:17 pm
be sure to check all our patches/fixes. From the top of my head I recall the patch/fix I applied solving (the majority) copy?paste/cut issue in linux.
Title: Re: Incremental Search
Post by: MortenMacFly on October 08, 2008, 02:51:36 pm
be sure to check all our patches/fixes. From the top of my head I recall the patch/fix I applied solving (the majority) copy?paste/cut issue in linux.
Don't worry - I transformed that, too literally the time you applied it in SVN.
What's new in "your" version Morten ?
The most new features come as a result of the Scintilla upgrade (routed through wxScintilla). It's for example a lot improvements in existing lexers and (IIRC) about 8 new lexers in general.
If you tested it and found it working nice, update it. What are you waiting for? ;)
Well... that time I told you I would like to have others, helping me testing it under  Linux. But I didn't found one and no branch was created for me so that others could check out my changes.

So - let me put it this way: My preferred steps would be:
1.) Create a branch for me ;-)
2.) Let me check into this branch
3.) Let us do some more (Linux!) testing --> Jens?!
4.) Let's apply it in trunk.

That's how such major modifications should always be IMHO. Shall we try to introduce this mechanism this time?
Title: Re: Incremental Search
Post by: mandrav on October 08, 2008, 03:24:20 pm
1.) Create a branch for me ;-)

The new "scintilla" branch awaits you ;)
Title: Re: Incremental Search
Post by: Jenna on October 08, 2008, 04:11:22 pm
3.) Let us do some more (Linux!) testing --> Jens?!

If it's committed I will download and test it.
Title: Re: Incremental Search
Post by: MortenMacFly on October 08, 2008, 06:28:40 pm
The new "scintilla" branch awaits you ;)
Hooray!
If it's committed I will download and test it.
Hooray!
:lol:

Give me time until tomorrow. I am already at home and my family needs me. :-)
Title: Re: SPLITTED: wxScintilla (was: Re: Incremental Search)
Post by: MortenMacFly on October 09, 2008, 10:30:46 am
Commit done.

I am not sure how up-to-date the "Makefile.am based" build system is. Seems like the modifications of the latest changes to scintilla are... erm... gone?! (Probably I did that at home...?!) I just realised that. :-(

But maybe we can fix this again, quickly.

Oh: BTW: MAC testing is needed urgently, too!!!
Title: Re: SPLITTED: wxScintilla (was: Re: Incremental Search)
Post by: rhf on October 10, 2008, 06:10:55 pm
I just updated with SVN 5253 and experimented with Incremental Search. It appears to work properly; however, the toolbar buttons for Prev, Next, etc do not appear. There is just a single large button with no icons.  This is on Windows XP.
Thanks for adding a nice feature.
Title: Re: SPLITTED: wxScintilla (was: Re: Incremental Search)
Post by: Jenna on October 10, 2008, 06:33:31 pm
I am not sure how up-to-date the "Makefile.am based" build system is. Seems like the modifications of the latest changes to scintilla are... erm... gone?! (Probably I did that at home...?!) I just realised that. :-(

But maybe we can fix this again, quickly.

Should be fixed in scintilla branch (cbp-file and Makefile.am). It builds at least for me on Linux, did not try it on win.

@rhf : the thread is splitted, please post here: http://forums.codeblocks.org/index.php/topic,9289.0.html (http://forums.codeblocks.org/index.php/topic,9289.0.html).