Code::Blocks

User forums => Nightly builds => Topic started by: killerbot on August 25, 2007, 11:00:38 pm

Title: The 25 August 2007 build will NOT be out.
Post by: killerbot on August 25, 2007, 11:00:38 pm
first we need to sort out this : http://forums.codeblocks.org/index.php?topic=6765.msg51964#msg51964
Title: Re: The 25 August 2007 build will NOT be out.
Post by: thomas on August 26, 2007, 12:18:04 am
Martin reverted it though? So... nothing to solve?
Title: Re: The 25 August 2007 build will NOT be out.
Post by: stahta01 on August 26, 2007, 05:12:14 am
SVN 4410 crashes on my WinXP SP2, wxWidgets 2.8 Branch

Tim S

PS: Trying backgroundthread.h SVN 4181 now to see if it works OK. It seemed to fix the Crash on startup issue. Note, I only changed the one file from SVN 4410.

The patch to revert backgroundthread.h to SVN 4181 is below.
Code: [Select]
Index: src/include/backgroundthread.h
===================================================================
--- src/include/backgroundthread.h (revision 4410)
+++ src/include/backgroundthread.h (working copy)
@@ -27,18 +27,13 @@
 * BackgroundThreadPool is a low overhead thread pool implementation around BackgroundThread.
 */
 
+
 class AbstractJob
 {
-    friend class BackgroundThread;
-
-    bool deleted;
-    bool done;
-
 public:
-    AbstractJob() : deleted(false), done(false) {};
+    AbstractJob(){};
     virtual ~AbstractJob(){};
     virtual void operator()() = 0;
-    void Delete() { deleted = true; if(done) delete this;};
 };
 
 
@@ -155,20 +150,10 @@
                 break;
 
             job = queue->Pop();
-
-            if(job->deleted)
-            {
-                delete job;
-                continue;
-            }
-
             (*job)();
-            job->done = true;
 
-            if(job->deleted || ownsJobs)
-            {
+            if(ownsJobs)
                 delete job;
-            }
         }
         return 0;
     };
Title: Re: The 25 August 2007 build will NOT be out.
Post by: killerbot on August 26, 2007, 08:22:58 am
no It was not reverted. And as stated in an other thread, the precompiled header include should be removed (this will not cause a crash, I think, but can lead to 'not building').
Title: Re: The 25 August 2007 build will NOT be out.
Post by: MortenMacFly on August 26, 2007, 10:05:11 am
Martin reverted it though? So... nothing to solve?
No, I didn't revert. I don't revert code I don't understand - and I was under the assumption you had a good reason for your revert...?!
Title: Re: The 25 August 2007 build will NOT be out.
Post by: stahta01 on August 27, 2007, 01:56:46 am
no It was not reverted. And as stated in an other thread, the precompiled header include should be removed (this will not cause a crash, I think, but can lead to 'not building').

Builds under windows OK without precompiled header include.

Tim S