Code::Blocks

User forums => Using Code::Blocks => Topic started by: Quiss on October 10, 2018, 02:14:21 pm

Title: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Quiss on October 10, 2018, 02:14:21 pm
Hi,

Every time you right click a folder or a file in projects tree, you see right click menu but also clicked item selected (like ctrl+left click, multiple selection). Can you reproduce it? Should I open a ticket?

Windows10-64, svn11499.
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 10, 2018, 05:13:22 pm
Can you describe the exact steps needed to reproduce this?
Does it happens with17.12 or the latest non wx3.1 night build?
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Quiss on October 11, 2018, 07:31:29 am
Open any project, just right click files and/or folders. After that it look like this:
https://imgur.com/a/h1qWZNh

11449 nightly: Ok
11472 wx31_64, gcc7.2.0: NOT ok
11499 nightly: NOT ok
11499 wx31_64, gcc7.2.0: NOT ok

I've been looking around and I think the problem is right click DragScroll fix svn11455. If i disable DragScroll plugin or use middle button instead of right button of mouse, it's ok.
Edit: svn11455 fix was for this: http://forums.codeblocks.org/index.php/topic,22807.msg155023.html#msg155023
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 11, 2018, 09:39:55 am
Does it go away if you locally revert this commit?
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 11, 2018, 09:48:31 am
BTW: I cannot reproduce this on linux :(
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Quiss on October 12, 2018, 07:27:30 am
Does it go away if you locally revert this commit?
Yes. But then highlight disappear problem comes back.

I reverted that commit and apply the patch in this message http://forums.codeblocks.org/index.php/topic,22807.msg155000.html#msg155000. This fixes highlight issue and does not have right click side effect.
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 12, 2018, 08:30:04 am
So, you are using right mouse button for dragscroll, aren't you?
What happens if you switch to middle mouse button?
Does this problem disappear?
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Quiss on October 12, 2018, 08:38:03 am
Yes, I'm using right mouse button; I think I'm the only one using it :).

There is no problem with middle mouse button.
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 12, 2018, 10:15:10 am
@Pecan: Could you take a look at this?
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Pecan on October 17, 2018, 08:25:37 pm
@Pecan: Could you take a look at this?
Aknowledge. I'll have a look at it.
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 18, 2018, 12:37:41 am
This https://sourceforge.net/p/codeblocks/tickets/753/ seems to be caused by the change in dragscroll...
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: BlueHazzard on October 18, 2018, 02:48:17 am
hmmm.. can you explain the steps in more detail? I am not sure how to reproduce. I see some bug, but i don't think it is the same as you describe, because it does not go away after disabling the plugin...
I see the following:
1) Right down click on one item in the tree (not realease the button)
2) Drag the mouse to a other item
3) Release the right button
4) Menu gets shown and two items are higlighted
5) Drag the right mouse again, you can select multiple items
I am not sure if this is even a bug...
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Quiss on October 18, 2018, 07:34:04 am
Just right click and release the button. Here is a gif: https://i.imgur.com/gXjc2qa.gifv The last click is left one.

Your patch fixes it, I've been using it, seems ok.
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: BlueHazzard on October 18, 2018, 09:10:45 am
Quote
Just right click and release the button. Here is a gif: https://i.imgur.com/gXjc2qa.gifv The last click is left one.
one gif says more then 1000 words.
Thank you i can reproduce it now.

To future clear things:
1) You have reverted commit 11455 (https://github.com/obfuscated/codeblocks_sf/commit/40e313df4f7ffd7d4bcdb9bdc538e1377c1e2717)
2) You have applied the patch from this post http://forums.codeblocks.org/index.php/topic,22807.msg155000.html#msg155000

Now:
1) you do not see the behavior of the right click posted in the current topic
2) The highlighting does not disappears if you scroll
3) The scroll plugin is activated
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Quiss on October 18, 2018, 10:08:02 am
Yes to all.
Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: Pecan on October 21, 2018, 05:39:48 pm
Fixed in r11506

I did not apply the wxScintilla fix mentioned above since the error could be fixed in Dragscroll itself.
See  http://forums.codeblocks.org/index.php/topic,22807.msg155000.html#msg155000 for the wxSTC discussion.

Title: Re: Right click acts like Ctrl+Left click in Manager-Projects tree
Post by: oBFusCATed on October 21, 2018, 11:52:38 pm
Good. The change to scintilla is not welcome, because we want to keep it as close to the one in wx as possible.