Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: frithjofh on May 27, 2018, 06:07:37 pm

Title: small clean up in cbeditor
Post by: frithjofh on May 27, 2018, 06:07:37 pm

hi everyone,

i am proposing a small code change in the area of cbeditor.

i removed a variable in editorbase which was used to hold the information whether a given pointer refers to a builtin editor or not. i replaced it with the proper override in the derived class.

reasoning: 1) breaks nothing 2) expresses more clearly the relationship 3) removes several lines of code

patch file attached.

regards

Title: Re: small clean up in cbeditor
Post by: oBFusCATed on May 27, 2018, 08:40:48 pm

1 is clearly not true, because you've broken the ABI, so you need to rise the sdk version numbers in the cbplugin.h (just the last number).
Also virtual functions are a bit slower than normal methods. I doubt it would matter too much, but still.

Title: Re: small clean up in cbeditor
Post by: killerbot on May 27, 2018, 09:38:20 pm

patch seems ok