Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: BlueHazzard on February 07, 2017, 07:00:46 pm

Title: Bug with latest trunk and goto file dialog
Post by: BlueHazzard on February 07, 2017, 07:00:46 pm

Hi, i experience a new introduced bug with the goto file dialog:
if i type in the search field, the list does not get updated. The scroll bar is updated (it gets bigger, so the list has less entries), but the text in the list not. I have to scroll the list out of view to get a updated list. So it seems the redraw is not handled correctly?

greetings

[Edit:]
OS: Windows 7 x64 wx2.8 latest trunk tdm 4.8

Title: Re: Bug with latest trunk and goto file dialog
Post by: BlueHazzard on February 07, 2017, 07:43:39 pm

Video:
https://youtu.be/CK_1ggvPPGo

Title: Re: Bug with latest trunk and goto file dialog
Post by: oBFusCATed on February 07, 2017, 09:31:19 pm

Bleh. I guess it is some windows only bug. I've tried it on wx2.8 on linux and it worked. :(

Can you try if this patch fixes the problem:

Code

diff --git a/src/sdk/incremental_select_helper.cpp b/src/sdk/incremental_select_helper.cpp
index 5f9fd3e38..1989ad544 100644
--- a/src/sdk/incremental_select_helper.cpp
+++ b/src/sdk/incremental_select_helper.cpp
@@ -107,6 +107,7 @@ void FilterItemsFinalize(wxListCtrl &list, IncrementalSelectIterator &iterator)

     if (iterator.GetFilteredCount() > 0)
         list.SetItemState(0, wxLIST_STATE_SELECTED, wxLIST_STATE_SELECTED);
+    list.Refresh();
 }

 void IncrementalSelectHandler::FilterItems()

Title: Re: Bug with latest trunk and goto file dialog
Post by: oBFusCATed on February 07, 2017, 09:33:36 pm

And if possible make a really big project and try before and after the patch if performance on windows is similarly improved as on linux.
Downloading the latest linux sources and just adding all h and c files to the project is a good test for performance.
In fact it has show many performance problems already.

Expect more breakages when I start pushing fixes for them in the next days :)

Title: Re: Bug with latest trunk and goto file dialog
Post by: BlueHazzard on February 07, 2017, 10:50:38 pm

yes, this fixes the issue, and the speedup to the old version is really nice!

good work!

Title: Re: Bug with latest trunk and goto file dialog
Post by: oBFusCATed on February 08, 2017, 12:44:56 am

In svn...