Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: omlk on December 27, 2020, 12:01:21 am

Title: Maybe src/sdk/filemanager.cpp (revision 12273)
Post by: omlk on December 27, 2020, 12:01:21 am

+++ src/sdk/filemanager.cpp    (revision 12273)
+        if (!data && len > 0)
+            return false;
+        return file.Write(data, len) == len;
correct:
+        if (!data || len <= 0)
+            return false;
+        return file.Write(data, len) == len;

Title: Re: Maybe src/sdk/filemanager.cpp (revision 12273)
Post by: Commaster on December 27, 2020, 04:46:33 am

size_t can't be < 0...

Title: Re: Maybe src/sdk/filemanager.cpp (revision 12273)
Post by: stahta01 on December 27, 2020, 05:09:38 am

http://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker) (http://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker))

Tim S.

Title: Re: Maybe src/sdk/filemanager.cpp (revision 12273)
Post by: omlk on December 27, 2020, 06:49:30 am

Quote from: Commaster on December 27, 2020, 04:46:33 am

size_t can't be < 0...

I wrote safer  ;)

Title: Re: Maybe src/sdk/filemanager.cpp (revision 12273)
Post by: oBFusCATed on December 27, 2020, 03:51:34 pm

Fixed thanks for reporting.