Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Plugins development => Topic started by: frithjofh on November 20, 2015, 01:46:11 pm

Title: another patch for the todo plugin
Post by: frithjofh on November 20, 2015, 01:46:11 pm

updated a dialogue to be more user friendly. refactored. added some security checks

changes to the asktypedlg gui :

- replaced the combobox with a list of radiobuttons

changes to the asktypedlg.h :

- changed base class to wxDialog
- changed constructor to take argumnts by const&
- made destructor virtual

changes to the asktypedlg.cpp :

- changed base class to wxDialog
- changed constructor to take arguments by const&
- in constructor added some checks for the XRC system
- moved empty destructor to header
- did the according changes caused by change of gui
- some clean up

Title: Re: another patch for the todo plugin
Post by: frithjofh on November 22, 2015, 09:40:44 am

included the list of changes made in the previous post

Title: Re: another patch for the todo plugin
Post by: ollydbg on November 24, 2015, 03:47:41 pm

Quote from: frithjofh on November 20, 2015, 01:46:11 pm

changes to the asktypedlg.h :

- changed base class to wxDialog
...
- changed base class to wxDialog
...

I haven't test your patch, but looked a the patch file, I see the above changes. My question is why you change to wxDialog?

Title: Re: another patch for the todo plugin
Post by: frithjofh on November 24, 2015, 08:15:22 pm

let me return the question: why should it be a wxScrolledDialog?

is that needed by anybody or by anything? I couldn't tell, so I chose the more simple alternative.

if there is a reason for wxScrolledDialog here, please tell me, and I'll switch back.

thx for the feedback  :)

Title: Re: another patch for the todo plugin
Post by: Jenna on November 24, 2015, 10:13:53 pm

Quote from: frithjofh on November 24, 2015, 08:15:22 pm

let me return the question: why should it be a wxScrolledDialog?

is that needed by anybody or by anything? I couldn't tell, so I chose the more simple alternative.

if there is a reason for wxScrolledDialog here, please tell me, and I'll switch back.

thx for the feedback  :)

wxScrollDialog automatically uses scrollbars, if the dialog does not fit on screen.

Title: Re: another patch for the todo plugin
Post by: frithjofh on November 24, 2015, 10:26:55 pm

yes, I know that much, but the dialog is really tiny...

maybe on a mobile phone...