Post by: stahta01 on June 08, 2015, 07:18:02 pm
Doing these steps cause a crash by themselves; but, only when the EnvVars plugin is enabled
Settings -> Environment
Click on OK
Attached new crash log from CodeBlocks_svn10320
Tim S.
In contrast to the nightly offered below, this also includes the crash handler, so its probably better suited for testing and reporting.
Crash handler works.
In the last 3 or 4 nightly a Windows crash has started. Edit: No Problem on svn10253; has problem on svn10314/svn10311
Using the EnvVars plugin, if you have 2 added configs.
Trying to change from one added config to something else causes a crash.
Settings -> Environment
Environmental Variables
Then try to change the selected configs; it sometimes crashes before I try to change the selected config.
Tim S.
Tim S.
Post by: oBFusCATed on June 08, 2015, 09:54:06 pm
Post by: stahta01 on June 08, 2015, 10:00:33 pm
Are you sure you have a clean build of CB?
No, but, I do NOT think it matters since I am getting the problem on the nightly download.
Downloading killerbot most recent build right now.
Tim S.
Post by: stahta01 on June 08, 2015, 10:13:44 pm
Tim S.
Are you sure you have a clean build of CB?
No, but, I do NOT think it matters since I am getting the problem on the nightly download.
Downloading killerbot most recent build right now.
Tim S.
Post by: oBFusCATed on June 08, 2015, 10:56:12 pm
Post by: scarphin on June 08, 2015, 11:48:32 pm
Post by: stahta01 on June 08, 2015, 11:57:39 pm
I can confirm the crash with the latest nightly (rev10320). It doesn't occur on my custom x64 build (rev10305).
What compiler version is used with your custom x64 build?
I am starting to think it might be a Compiler and/or wxWidgets bug.
I have failed to see the problem using TDM MinGW GCC 4.7.1 under Windows 7 64 bit Home Pro.
But, I do see it under MinGW GCC 4.9.?2? under Windows 7 32 bit Ultimate.
Tim S.
Post by: scarphin on June 09, 2015, 12:39:43 am
What compiler version is used with your custom x64 build?tdm 4.9.2
I don't think that's compiler or wxwidgets related, I believe it's because of a change somewhere between 10305 and head revision. I'll rebuild my local trunk to the latest head and try to see where it crashes with drmingw. It doesn't always catch the crashing function though.
Post by: oBFusCATed on June 09, 2015, 12:53:29 am
Post by: scarphin on June 09, 2015, 01:25:09 am
Code
#0 0000000062711545 wxBaseArrayPtrVoid::Index(void const*, bool) const() (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#1 0000000062847448 wxCheckListBoxItem::Check(bool) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#2 0000000070A87898 nsEnvVars::EnvvarArrayApply(envvar=3 count of wxArrayString = {...}, lstEnvVars=0x1664cfa0) (D:\coding\projects\sw\codeblocks\trunk\src\plugins\contrib\envvars\envvars_common.cpp:479)
#3 0000000070A82E1F EnvVarsConfigDlg::LoadSettings(this=0x165d1a90) (D:\coding\projects\sw\codeblocks\trunk\src\plugins\contrib\envvars\envvars_cfgdlg.cpp:167)
#4 0000000070A82836 EnvVarsConfigDlg::EnvVarsConfigDlg(this=0x165d1a90, parent=0x164ca250) (D:\coding\projects\sw\codeblocks\trunk\src\plugins\contrib\envvars\envvars_cfgdlg.cpp:68)
#5 0000000070A82448 EnvVars::GetConfigurationPanel(this=0x7311d10, parent=0x164ca250) (D:\coding\projects\sw\codeblocks\trunk\src\plugins\contrib\envvars\envvars.cpp:286)
#6 000000000151E0E2 PluginManager::GetConfigurationPanels(this=0x6ed0160, group=-4, parent=0x164ca250, arrayToFill=...) (D:\coding\projects\sw\codeblocks\trunk\src\sdk\pluginmanager.cpp:1290)
#7 0000000000438671 EnvironmentSettingsDlg::AddPluginPanels(this=0x22e690) (D:\coding\projects\sw\codeblocks\trunk\src\src\environmentsettingsdlg.cpp:330)
#8 0000000000437B35 EnvironmentSettingsDlg::EnvironmentSettingsDlg(this=0x22e690, parent=0x61cbe10, art=0x61e0c00) (D:\coding\projects\sw\codeblocks\trunk\src\src\environmentsettingsdlg.cpp:308)
#9 0000000000462EA2 MainFrame::OnSettingsEnvironment(this=0x61cbe10, event=...) (D:\coding\projects\sw\codeblocks\trunk\src\src\main.cpp:4620)
#10 0000000062786541 wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#11 0000000062786603 wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#12 00000000627869B7 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#13 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#14 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#15 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#16 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#17 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#18 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#19 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#20 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#21 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#22 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#23 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#24 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#25 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#26 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#27 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#28 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
#29 0000000062786948 wxEvtHandler::ProcessEvent(wxEvent&) () (D:\coding\projects\sw\codeblocks\trunk\src\devel_64\wxmsw28u_gcc_custom.dll:??)
Post by: oBFusCATed on June 09, 2015, 01:38:58 am
Post by: stahta01 on June 09, 2015, 01:58:21 am
Can you try to revert rev 10309 and see if the problem goes away?
Tried that on my Laptop and the problem was NOT there; then I added it back and the problem was still gone.
That why I guessed GCC 4.9.2 was the cause; but, using MinGW GCC 4.7.1 on my desktop and it still had the problem.
Now going to revert rev 10309 on my desktop to see what happens.
Tim S.
Post by: scarphin on June 09, 2015, 02:15:17 am
Post by: stahta01 on June 09, 2015, 02:34:39 am
Edit: Or does the sequence operator "," do something different in C++ than I think it does?
Tim S.
Code
int sel = -1;
if (lstEnvVars)
{
sel = lstEnvVars->Append(key + _T(" = ") + value, new EnvVariableListClientData(key, value));
lstEnvVars->Check(sel, bCheck);
}
Post by: stahta01 on June 09, 2015, 02:43:41 am
Edit: But, I think the second line does nothing useful; but, maybe in the C++ world it does something.
Code
diff --git a/src/plugins/contrib/envvars/envvars_cfgdlg.cpp b/src/plugins/contrib/envvars/envvars_cfgdlg.cpp
index 200e930..c47a3a6 100644
--- a/src/plugins/contrib/envvars/envvars_cfgdlg.cpp
+++ b/src/plugins/contrib/envvars/envvars_cfgdlg.cpp
@@ -450,7 +450,8 @@ void EnvVarsConfigDlg::OnAddEnvVarClick(wxCommandEvent& WXUNUSED(event))
if (nsEnvVars::EnvvarVetoUI(key, NULL, -1))
return;
- int sel = lstEnvVars->Append(key + _T(" = ") + value, new nsEnvVars::EnvVariableListClientData(key, value));
+ int sel = lstEnvVars->Append(key + _T(" = ") + value);
+ new nsEnvVars::EnvVariableListClientData(key, value);
bool success = nsEnvVars::EnvvarApply(key, value);
if (sel>=0)
lstEnvVars->Check(sel, success);
Code
diff --git a/src/plugins/contrib/envvars/envvars_common.cpp b/src/plugins/contrib/envvars/envvars_common.cpp
index fa4ded0..d1de5f4 100644
--- a/src/plugins/contrib/envvars/envvars_common.cpp
+++ b/src/plugins/contrib/envvars/envvars_common.cpp
@@ -475,7 +475,8 @@ bool nsEnvVars::EnvvarArrayApply(const wxArrayString& envvar,
int sel = -1;
if (lstEnvVars)
{
- sel = lstEnvVars->Append(key + _T(" = ") + value, new EnvVariableListClientData(key, value));
+ sel = lstEnvVars->Append(key + _T(" = ") + value);
+ new EnvVariableListClientData(key, value);
lstEnvVars->Check(sel, bCheck);
}
Tim S.
Post by: scarphin on June 09, 2015, 03:05:07 am
Can a C++ expert explain how sel can hold the result of new EnvVariableListClientData(key, value)?I'm not a C++ expert but 'sel' has nothing to with 'new EnvVariableListClientData(key, value)':
Edit: Or does the sequence operator "," do something different in C++ than I think it does?
Code
int sel = lstEnvVars->Append(key + _T(" = ") + value, new nsEnvVars::EnvVariableListClientData(key, value));CB crashes at line 479 in 'envvars_common.cpp', I don't think 'Append' is the problematic part.
Post by: stahta01 on June 09, 2015, 03:19:44 am
Can a C++ expert explain how sel can hold the result of new EnvVariableListClientData(key, value)?I'm not a C++ expert but 'sel' has nothing to with 'new EnvVariableListClientData(key, value)':
Edit: Or does the sequence operator "," do something different in C++ than I think it does?Codeinvokes the overloaded 'Append' function with 2 arguments, there is no sequencing here. Sorry if I misunderstood you and you were talking about something else.int sel = lstEnvVars->Append(key + _T(" = ") + value, new nsEnvVars::EnvVariableListClientData(key, value));
CB crashes at line 479 in 'envvars_common.cpp', I don't think 'Append' is the problematic part.
A = B, C;
Assigns the value of C to A.
OK, I see what you mean now.
Tim S.
Post by: stahta01 on June 09, 2015, 03:45:48 am
I just am too tired to think of anything other than wxWidgets is NOT likely something in the code.
Edit: I have decided next time to see if the problem exists under wxWidgets 3.0 because it has better asserts in it.
Tim S.
Post by: oBFusCATed on June 09, 2015, 09:29:31 am
I have no idea why this fails.
To see the real cause of the problem you'll need to rebuild wxwidgets in debug mode.
Post by: oBFusCATed on June 09, 2015, 09:30:46 am
Post by: MortenMacFly on June 09, 2015, 09:44:09 am
Post by: MortenMacFly on June 09, 2015, 09:48:26 am
The crash results in line 167 in EnvVarsConfigDlg::LoadSettings() of envvars_cfgdlr.cpp:
if (nsEnvVars::EnvvarArrayApply(var_array, lstEnvVars))
lstEnvVars seems to be valid... very weird.
So I cannot set any environment (not only envvar) settings... that is no good.
Post by: oBFusCATed on June 09, 2015, 10:25:37 am
Post by: stahta01 on June 09, 2015, 04:11:25 pm
Can someone extract his/her env settings from default.conf and share them?
Code
<envvars>
<sets>
<default>
<ENVVAR0>
<str>
<![CDATA[1|LC_ALL|en_US.utf8]]>
</str>
</ENVVAR0>
</default>
<wx28>
<ENVVAR0>
<str>
<![CDATA[1|wxcfg|gcc_dll\mswu]]>
</str>
</ENVVAR0>
<ENVVAR1>
<str>
<![CDATA[1|wxwin|C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12]]>
</str>
</ENVVAR1>
</wx28>
<wx30>
<ENVVAR0>
<str>
<![CDATA[1|wxcfg|gcc_dll\mswu]]>
</str>
</ENVVAR0>
<ENVVAR1>
<str>
<![CDATA[1|wxwin|C:\wxMSW\wxMSW-3.0\wxWidgets-3.0.2]]>
</str>
</ENVVAR1>
</wx30>
</sets>
<ACTIVE_SET>
<str>
<![CDATA[wx30]]>
</str>
</ACTIVE_SET>
<DEBUG_LOG bool="1" />
</envvars>
Tim S.
Post by: stahta01 on June 09, 2015, 05:08:02 pm
Code
---------------------------
wxWidgets Debug Alert
---------------------------
../../src/msw/listbox.cpp(441): assert "wxAssertFailure" failed in DoSetItemClientData(): Can't use client data with owner-drawn listboxes
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
---------------------------
wxWidgets Debug Alert
---------------------------
../../src/msw/listbox.cpp(441): assert "wxAssertFailure" failed in DoSetItemClientData(): Can't use client data with owner-drawn listboxes
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
Post by: oBFusCATed on June 09, 2015, 08:27:45 pm
There is no mentioning of wxLB_OWNERDRAW in the whole repo. :(
And the styles for it in the xrc file are wxLB_SINGLE|wxLB_HSCROLL|wxLB_NEEDED_SB...
Post by: oBFusCATed on June 09, 2015, 09:28:08 pm
Post by: oBFusCATed on June 09, 2015, 09:32:13 pm
Looking at the code I can guess that it should be working fine.
Post by: stahta01 on June 09, 2015, 11:57:29 pm
Can someone confirm that this issue is not present in wx30 builds?
Looking at the code I can guess that it should be working fine.
Will check later today; building wx30 right now.
Tim S.
Post by: stahta01 on June 10, 2015, 01:55:30 am
Can someone confirm that this issue is not present in wx30 builds?
Looking at the code I can guess that it should be working fine.
Will check later today; building wx30 right now.
Tim S.
It worked with the debug build of wxWidgets 3.0.2.
Going to test the non-debug version next.
Edit: No problem with the non-debug version.
Tim S.
Post by: stahta01 on June 10, 2015, 02:24:01 am
Can someone confirm that this issue is not present in wx30 builds?
Looking at the code I can guess that it should be working fine.
Will check later today; building wx30 right now.
Tim S.
It worked with the debug build of wxWidgets 3.0.2.
Going to test the non-debug version next.
Edit: No problem with the non-debug version.
Tim S.
I think adding wx30 conditionals would be a good option to take.
Tim S.
Post by: MortenMacFly on June 10, 2015, 07:02:14 am
Post by: oBFusCATed on June 10, 2015, 08:31:46 am
Post by: stahta01 on June 11, 2015, 03:07:29 pm
Post by: MortenMacFly on June 11, 2015, 10:00:47 pm
Post by: oBFusCATed on June 12, 2015, 01:04:44 am
Post by: oBFusCATed on June 13, 2015, 12:34:32 pm
Post by: stahta01 on June 13, 2015, 03:33:47 pm
Should be fixed in trunk. Hopefully it compiles and works correctly on windows with both 2.8 and 3.0.
Compiling it now on Windows 7 32 bit using wxWidgets 2.8.12.
Tim S.
Post by: stahta01 on June 13, 2015, 04:15:38 pm
Should be fixed in trunk. Hopefully it compiles and works correctly on windows with both 2.8 and 3.0.
Compiling it now on Windows 7 32 bit using wxWidgets 2.8.12.
Tim S.
Post by: stahta01 on June 13, 2015, 04:35:17 pm
ToDo List related Crash.
Quote
---------------------------
wxWidgets Debug Alert
---------------------------
C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12\include/wx/object.h(314): assert "ptr" failed in wxCheckCast(): wxStaticCast() used incorrectly
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
Post by: stahta01 on June 13, 2015, 05:27:43 pm
I am using my own Git repo and custom CB project to build the binary that has the issue.
It could be a mistake in my CB Project or Git Repo that is causing it.
Or, it could be a mistake in my self-built wxWidgets.
I am leaning towards an wxWidgets caused error.
Tim S.
I was having crashing still when using wxWidgets 2.8.12 debug; but, it is NO longer EnvVars that causes it it is the ToDo Plugin.
ToDo List related Crash.Quote---------------------------
wxWidgets Debug Alert
---------------------------
C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12\include/wx/object.h(314): assert "ptr" failed in wxCheckCast(): wxStaticCast() used incorrectly
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
Post by: scarphin on June 13, 2015, 10:27:02 pm
I was having crashing still when using wxWidgets 2.8.12 debug; but, it is NO longer EnvVars that causes it it is the ToDo Plugin.ToDo plugin seems to be working fine with my custom x64 setup. I'm using wx2.8.12 release though. Can you please post the steps to reproduce so I can test further?
ToDo List related Crash.Quote---------------------------
wxWidgets Debug Alert
---------------------------
C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12\include/wx/object.h(314): assert "ptr" failed in wxCheckCast(): wxStaticCast() used incorrectly
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
Post by: stahta01 on June 14, 2015, 12:30:02 am
The svn r10333 build I do does NOT have the problem.
Tim S.
Have the ToDo and Compiler plugins enabled.
Settings -> Environment
It only does it with my recent self builds; the last nightly does NOT do it.
That is one reason I think it might just be my self build of wxWidgets.
That is why I plan to wait till the next nightly and see if it happens with it.
Tim S.
I was having crashing still when using wxWidgets 2.8.12 debug; but, it is NO longer EnvVars that causes it it is the ToDo Plugin.ToDo plugin seems to be working fine with my custom x64 setup. I'm using wx2.8.12 release though. Can you please post the steps to reproduce so I can test further?
ToDo List related Crash.Quote---------------------------
wxWidgets Debug Alert
---------------------------
C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12\include/wx/object.h(314): assert "ptr" failed in wxCheckCast(): wxStaticCast() used incorrectly
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
Post by: stahta01 on June 14, 2015, 03:48:30 am
Tim S.
I was having crashing still when using wxWidgets 2.8.12 debug; but, it is NO longer EnvVars that causes it it is the ToDo Plugin.
ToDo List related Crash.Quote---------------------------
wxWidgets Debug Alert
---------------------------
C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12\include/wx/object.h(314): assert "ptr" failed in wxCheckCast(): wxStaticCast() used incorrectly
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------
Post by: stahta01 on June 14, 2015, 04:54:20 am
I am now 90% certain the problem (ToDo List related Crash) is being caused by edits I made to the CB Project files.
Tim S.I was having crashing still when using wxWidgets 2.8.12 debug; but, it is NO longer EnvVars that causes it it is the ToDo Plugin.
ToDo List related Crash.Quote---------------------------
wxWidgets Debug Alert
---------------------------
C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12\include/wx/object.h(314): assert "ptr" failed in wxCheckCast(): wxStaticCast() used incorrectly
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes No Cancel
---------------------------