Author Topic: Exporter : wxPdfDocument (remove warnings)  (Read 3005 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5272
Exporter : wxPdfDocument (remove warnings)
« on: August 15, 2007, 03:56:07 pm »
I have removed several warnigns from the wxPdfDocument code.
This is what I have done :

Quote
pdfparser.h :
   Comments : /** -> ///  to avoid warning 'warning: "/*" within comment'''


pdfgraphics.cpp : @GetSegment() : switch case doesn't deal with all cases --> default that does nothing, so we avoid the warning 'warning: enumeration value 'wxPDF_SEG_UNDEFINED' not handled in switch



pdfkernel.cpp : @PutShaders() : 2 X switch case doesn't deal with all cases --> default that does nothing, so we avoid the warnings
   warning: enumeration value ‘wxPDF_COLOURTYPE_UNKNOWN’ not handled in switch
   warning: enumeration value ‘wxPDF_COLOURTYPE_SPOT’ not handled in switch



pdfrijndael.cpp : all 2 dim structures need braces to avoid warning 'warning: missing braces around initializer for ‘UINT8 [4]’'

static UINT8 T1[256][4]=
{
  0xc6,0x63,0x63,0xa5, 0xf8,0x7c,0x7c,0x84, 0xee,0x77,0x77,0x99, 0xf6,0x7b,0x7b,0x8d,
  0xff,0xf2,0xf2,0x0d, 0xd6,0x6b,0x6b,0xbd, 0xde,0x6f,0x6f,0xb1, 0x91,0xc5,0xc5,0x54,


should be :

static UINT8 T1[256][4]=
{
  {0xc6,0x63,0x63,0xa5}, {0xf8,0x7c,0x7c,0x84}, {0xee,0x77,0x77,0x99}, {0xf6,0x7b,0x7b,0x8d},
  {0xff,0xf2,0xf2,0x0d}, {0xd6,0x6b,0x6b,0xbd}, {0xde,0x6f,0x6f,0xb1}, {0x91,0xc5,0xc5,0x54},

and so on

@Ceniza : I think you always monitor and update our copy of the wxPdfDocument sources. Could you send the changes I made back to the original author, I hope he/she appreciates the removal of warnings, that way it is easier to focus on real warnings. Most changes were very simple, only the pdfrijndael.cpp was a bit 'replace magic' ;-)


Offline Ceniza

  • Developer
  • Lives here!
  • *****
  • Posts: 1441
    • CenizaSOFT
Re: Exporter : wxPdfDocument (remove warnings)
« Reply #1 on: August 15, 2007, 05:58:49 pm »
Done :D