Author Topic: About background colour of symbols window  (Read 16005 times)

lfm

  • Guest
About background colour of symbols window
« on: May 24, 2006, 07:26:43 am »
The background colour of symbols window is not good-look. can i change ?


[attachment deleted by admin]

sethjackson

  • Guest
Re: About background colour of symbols window
« Reply #1 on: May 24, 2006, 01:57:35 pm »
The background colour of symbols window is not good-look. can i change ?


It is not in any C::B setting. However you can modify the code to "fix" it (it looks ugly on windows)....
The reason is eranif in one of his wxFNB release changed the background color on Windows.

Fourth post from the bottom......

http://wxforum.shadonet.com/viewtopic.php?t=5761&postdays=0&postorder=asc&start=90
« Last Edit: May 24, 2006, 03:05:36 pm by sethjackson »

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #2 on: May 24, 2006, 02:12:40 pm »
This has been fixed *long* ago...
Be patient!
This bug will be fixed soon...

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
Re: About background colour of symbols window
« Reply #3 on: May 24, 2006, 02:49:48 pm »
This has been fixed *long* ago...

sorry, that screeny is from svn rev 2498



it really doesn't look fixed  :P

WinXP, wxWidgets 2.6.3 unicode

takeshimiya

  • Guest
Re: About background colour of symbols window
« Reply #4 on: May 24, 2006, 02:55:10 pm »
it really doesn't look fixed  :P
I can confirm that. :P

A wxPanel there shouldn't solve it?

@tiwag: that cyan background doesn't hurt your eyes? :o

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #5 on: May 24, 2006, 02:55:42 pm »
You might want to run update.bat (windows) or "sh update" (linux, build using C::B).
If you 're using linux/autotools, run the following:
Code
make clean-zipfiles
make
make install


[attachment deleted by admin]
Be patient!
This bug will be fixed soon...

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #6 on: May 24, 2006, 02:57:19 pm »
A wxPanel there shouldn't solve it?

Look in src/plugins/codecompletion/resources/classbrowser.xrc.
Surprise! It uses a wxPanel :)
Be patient!
This bug will be fixed soon...

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
Re: About background colour of symbols window
« Reply #7 on: May 24, 2006, 03:02:22 pm »
You might want to run update.bat (windows) ...
done, but without success

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
Re: About background colour of symbols window
« Reply #8 on: May 24, 2006, 03:04:21 pm »
@tiwag: that cyan background doesn't hurt your eyes? :o
it doesn't as hurt as certain questions in this forum here ...

sethjackson

  • Guest
Re: About background colour of symbols window
« Reply #9 on: May 24, 2006, 03:05:18 pm »
Hey everyone this happens on Windows only. See my post above. :D

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: About background colour of symbols window
« Reply #10 on: May 24, 2006, 03:06:18 pm »
@tiwag: that cyan background doesn't hurt your eyes? :o
it doesn't as hurt as certain questions in this forum here ...
I believe the background in SciTE is not cyan... :)

EDIT: And looking closely, the above isn't either :)
« Last Edit: May 24, 2006, 03:10:39 pm by thomas »
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline Defender

  • Multiple posting newcomer
  • *
  • Posts: 49
Re: About background colour of symbols window
« Reply #11 on: May 24, 2006, 03:07:32 pm »
Yes, I can confirm this too.
Windows XP SP2
wxWidgets 2.6.3 patch2
Code::Blocks 2490 Full rebuild
But it doesn't hurt me...

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #12 on: May 24, 2006, 03:12:59 pm »
Well, did anyone have a look at src/plugins/codecompletion/resources/classbrowser.xrc???
Be patient!
This bug will be fixed soon...

sethjackson

  • Guest
Re: About background colour of symbols window
« Reply #13 on: May 24, 2006, 03:22:44 pm »
Well, did anyone have a look at src/plugins/codecompletion/resources/classbrowser.xrc???

Yes, but the real problem is wxFNB. I have rev 2498. I ran update.bat same "problem" described above.....

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
Re: About background colour of symbols window
« Reply #14 on: May 24, 2006, 03:23:54 pm »
Well, did anyone have a look at src/plugins/codecompletion/resources/classbrowser.xrc???

when i test this with XRCed it looks ok, all bg and fg colours are set to default, also the
CodeBlocks\share\CodeBlocks\code_completion.zip
contains the right classbrowser.xrc file,
i don't know why this happens, but it is not related to an outdated classbrowser.xrc file.

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #15 on: May 24, 2006, 03:28:38 pm »
Yes, but the real problem is wxFNB.

Yes, wxFNB was responsible back when we didn't use a panel for those comboboxes above the symbols browser.
But it isn't responsible anymore. It can't be. There's a wxPanel there. I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...
Be patient!
This bug will be fixed soon...

sethjackson

  • Guest
Re: About background colour of symbols window
« Reply #16 on: May 24, 2006, 03:29:45 pm »
This is how to "fix" (I'm not saying this code should go in SVN trunk just proving my point....).

Code: diff
Index: src/sdk/wxFlatNotebook/wxFlatNotebook.cpp
===================================================================
--- src/sdk/wxFlatNotebook/wxFlatNotebook.cpp (revision 2498)
+++ src/sdk/wxFlatNotebook/wxFlatNotebook.cpp (working copy)
@@ -488,7 +488,7 @@
  m_mainSizer = new wxBoxSizer(wxVERTICAL);
  SetSizer(m_mainSizer);
 
- SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE));
+ SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_3DLIGHT));
 
  // Add the tab container to the sizer
  m_mainSizer->Insert(0, m_pages, 0, wxEXPAND);


« Last Edit: May 24, 2006, 03:32:38 pm by sethjackson »

sethjackson

  • Guest
Re: About background colour of symbols window
« Reply #17 on: May 24, 2006, 03:30:52 pm »
Yes, but the real problem is wxFNB.

Yes, wxFNB was responsible back when we didn't use a panel for those comboboxes above the symbols browser.
But it isn't responsible anymore. It can't be. There's a wxPanel there. I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...

mandrav see my post above. This only happens on Windows. The reason is wxSYS_COLOUR_APPWORKSPACE is a different color on Windows than on *nix. :D

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #18 on: May 24, 2006, 03:32:05 pm »
OK, I think I see why this happens. Give me a few minutes...
Be patient!
This bug will be fixed soon...

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
Re: About background colour of symbols window
« Reply #19 on: May 24, 2006, 03:32:12 pm »
... I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...
it doesn't have the heart to misbehave at the boss's computer ... :D

sethjackson

  • Guest
Re: About background colour of symbols window
« Reply #20 on: May 24, 2006, 03:33:13 pm »
... I don't understand why it behaves like that for you guys. As you can see from my screenshot above, it works fine here. As expected...
it doesn't have the heart to misbehave at the boss's computer ... :D

 :lol:

« Last Edit: May 24, 2006, 03:35:02 pm by sethjackson »

Offline mandrav

  • Project Leader
  • Administrator
  • Lives here!
  • *****
  • Posts: 4315
    • Code::Blocks IDE
Re: About background colour of symbols window
« Reply #21 on: May 24, 2006, 03:46:34 pm »
First of all, the fix has been committed.

OK, here's what happens.
You 're using the symbols browser docked inside the project manager's notebook, while I 'm using it as a free floating window. When I docked it here too, I saw the problem.
It still doesn't make sense why this happens. There's a panel there. It should paint itself. Period. But it doesn't...
Anyway, as I said, I committed the fix so enough about this :)
Be patient!
This bug will be fixed soon...

takeshimiya

  • Guest
Re: About background colour of symbols window
« Reply #22 on: May 24, 2006, 04:24:43 pm »
It still doesn't make sense why this happens. There's a panel there. It should paint itself. Period. But it doesn't...

Strange things happens. :P