Author Topic: The 01 March 2020 build (11973) is out.  (Read 24368 times)

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: The 01 March 2020 build (11973) is out.
« Reply #15 on: March 07, 2020, 09:03:50 pm »
I don't see anything interesting here. Can you show me a screenshot? (I've tested on linux and your config seems to work fine)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline raynebc

  • Almost regular
  • **
  • Posts: 217
Re: The 01 March 2020 build (11973) is out.
« Reply #16 on: March 08, 2020, 10:06:58 pm »
Here's a screen capture:
https://i.imgur.com/vq28ZsJ.png

The first instance of "eof_selection" is selected, but that is not visible due to the background color of selected text.  After going into "Settings>Editor>Syntax highlighting, picking "Selection from the list and changing the background color from "Default" to light gray, it looks like this:
https://i.imgur.com/g3yvUMD.png

Going back to "Syntax Highlighting>Selection" and clicking "Reset defaults" changes the clearly visible shade of gray to one so light it's hardly visible:
https://i.imgur.com/SzO6L4G.png

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: The 01 March 2020 build (11973) is out.
« Reply #17 on: March 08, 2020, 11:10:16 pm »
Can you try to revert rev 11930 and test again? (it is the commit I've mentioned and it fixes this issue https://sourceforge.net/p/codeblocks/tickets/267/ )

I don't see this. Can someone else on windows try to reproduce this?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline raynebc

  • Almost regular
  • **
  • Posts: 217
Re: The 01 March 2020 build (11973) is out.
« Reply #18 on: March 09, 2020, 08:06:37 am »
As per our previous communications, I can't build C::B from source:
http://forums.codeblocks.org/index.php/topic,23498.msg160068.html#msg160068

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 3353
Re: The 01 March 2020 build (11973) is out.
« Reply #19 on: March 10, 2020, 06:17:46 pm »
Quote
I don't see this. Can someone else on windows try to reproduce this?
I can not reproduce it normally: i have tried to do Settings->Editor->Syntax highlighting->Reset defaults . After this still all seems to be normal
Hovever i can make the same behaviour by pressing the "D" Button near the "Background" selector for the "Selection" color. So steps to reproduce for me:
1) Open Settings->Editor->Syntax highlighting
2) Select "Selection" from the List
3) Hit the "D" Button for the "Background" color. It resets to "Default" and this seems to be "invisible?"
By pressing the button "Reset defaults" the "Background" color goes back to some gray type.
I have not looked into the code....
« Last Edit: March 10, 2020, 06:19:52 pm by BlueHazzard »

Offline BlueHazzard

  • Developer
  • Lives here!
  • *****
  • Posts: 3353
Re: The 01 March 2020 build (11973) is out.
« Reply #20 on: March 10, 2020, 10:11:22 pm »
Looking into the code this seems to be the default behavior
Code
void EditorConfigurationDlg::OnSetDefaultColour(wxCommandEvent& event)
{
    wxWindow *button = nullptr;
    if (event.GetId() == XRCID("btnForeSetDefault"))
        button = FindWindowById(XRCID("btnColoursFore"));
    else if (event.GetId() == XRCID("btnBackSetDefault"))
        button = FindWindowById(XRCID("btnColoursBack"));
    if (!button)
        return;
    button->SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE));
    button->SetLabel(_("\"Default\""));
    WriteColours();
}