Dependencies / ProjectManager::CloseProject

[Bat]

I saw from long time a crash on C::B windows, when lots of files and projects are modified outsided C::B (typically git checkout on another branch without C::B closed). I tracked it.

I land here :

Code

bool ProjectManager::CloseProject(cbProject* project, bool dontsave, bool refresh)

We have :
   

Code

RemoveProjectFromAllDependencies(project);

But I think we need also this call, to clean the global DepsMap array that will track pointer on closed project :
   

Code

ClearProjectDependencies(project);

Note :
1)this "leak" can lead to crash only after the second reloading of a project (or any other DepsMap pointers usage), not the first one
2)in my specific case, it solved the crash

Am I missing something ?
If not did you want a ticket and a patch ?

[oBFusCATed]

Already fixed in r11344 

[oBFusCATed]

Unfortunately I've just got a crash when switching branches in git and the whole workspace had to be reloaded.
The backtrace seems similar like the fixed crash, so the problem is not 100% fixed.