hi everybody,
just some minor refactoring in this class:
- change some ints to size_t
- added some new lines for clarity
- added some conts in variable declarations
- changed IsEmpty() to empty() member function on wxStrings
- refactrored function FindReplaceDlg::FillComboWithLastValues:
- removed loop and replaced it with member function which adds a wxArrayString
- removed check for empty strings as it is not necessary. when the values get written into config
this check is already performed
- refactored function FindReplaceDlg::SaveComboValues:
- changed order of actions. instead of first adding the entries and then checking for the currently
selected entry an d adding it, and removing it... , now it first gets the current selected value and
adds it, and then goes through adding all other entries, skipping empties and doubles
as always: just refactoring. I sometimes use my low quality free time while traveling or sick, to just randomly jump into some file of c::b and read it, checking for strange things, or things that are hard to read at first glance, or that could hide some error, or some superfluous code...
please don't scold me for it. this is my free time
and I can't spend it for things that would require a better programmer. making this small clean-ups eventually contributes a little bit every time to make c::b even better than it is
regards
frithjof