Author Topic: Todo list plugin improvements, do not refresh the list after double click  (Read 6678 times)

Online ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5295
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
I have a serial of git patches to fix this issue, I will put it here for comments and review for a few days, if no objections, I will commit to the trunk.

The change log:

Quote
* todo list plugin: disable refresh the list on double click. When user double click on a todo list item, it will move the caret to the source location, since the source file is already parsed, we don't need to parse it again.

 * todo list plugin: use the second kind of constructor of wxCombobox, as it can given a wxArrayString reference, no hard-coded number is needed.

 - todo list plugin: add debug logs (it is currently disabled)

 - todo list plugin: remove unused member variable ToDoList::m_timer.

 - todo list plugin: remove an unused function prototype

 - todo list plugin: add many comments (no functional change)

If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13008
    • Travis build status
Why don't you just make a branch in github?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Online ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5295
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Why don't you just make a branch in github?
The reason is that github sometimes will be blocked here, so access to it is not quite stable.... :(
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13008
    • Travis build status
Bleh...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Online ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5295
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
The patches are in trunk now. ;D
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.