Patch: function arguments added to autocomplete tooltip

[oBFusCATed]

p2rkw:
First impressions - it look really bad, when longer functions are completed. It adds '...' at the end.
Is it possible to try to resize the completion window?

[p2rkw]

My first idea was to call:
            ed->GetControl()->AutoCompSetMaxWidth(0);
            ed->GetControl()->AutoCompSetMaxHeight(12);
before AutoComp show, but this doesn't work. Maximum size of autocomp listbox is hardcoded in ListBoxImpl::GetDesiredRect() in file PlatWX.cpp:
(...) if (maxw > 350)
        maxw = 350;
add similar for maxh.
This limitations are unnecessary because later scintilla clamp rect returned by this function to values setted by AutoCompSetMaxWidth and AutoCompSetMaxHeight. So I removed this limitations and AutoCompSetMaxWidth and AutoCompSetMaxHeight works as it should be.

[p2rkw]

I removed few bugs, now default arguments, and overloads are handled correctly. If you use autocomp outside function's block argument's types will be not removed (because outside blocks are only function's definitions/declarations).
I also apped patch for PlatWX.cpp - if you apply it your autocomplete listbox will be adjusted to widest match.
I think I finished this functionality, now I will work on documentation helper.

edit: patches are now in patch tracker.

[ollydbg]

patches are now in patch tracker.

Good work.
Both Enlargment of autocomplete's listbox and CC,autocomplete: added argument's names and types to list.
The first one was patch on PlatWX.cpp.

[MortenMacFly]

patches are now in patch tracker.

Good work.
Both Enlargment of autocomplete's listbox and CC,autocomplete: added argument's names and types to list.
The first one was patch on PlatWX.cpp.

Warning: These conflict with:
http://forums.codeblocks.org/index.php/topic,17172.msg117678.html#new
...which is a nice one, too.

[oBFusCATed]

Then we choose one to be committed and the second will be fixed after the commit.

[Alpha]

Commit this one first (it was here longer ; I will update my patch after that.

[oBFusCATed]

I've found some problems with this patch:
1. completing push_back of a std::vector results in vec.push_back(__x)|, but what I want to have after the completion is vec.push_back|
2. completing end of a std::vector results in vec.end()|, I want it to be vec.end|

'|' is where the cursor is after the completion.

[p2rkw]

You probably have disabled option "add parentheses after function autocomplete". Thanks for info. I'll fix it when Alpha's patch will be in svn.
btw: can you enable this option and say what you think about new behaviour?

[oBFusCATed]

Yes, it is disabled, but the first case will be an error even if it is enabled.

[p2rkw]

Ok, I fixed it, but now I don't have time to generate patch.
When this option is enabled and you complete push_back then argument names (in this case "__x") will be selected. It's a feature

[oBFusCATed]

What do you mean by selected?
Keep in mind that this is bug in my opinion and it can be very annoying!

[p2rkw]

Patch updated.

Btw. if I will prepare patch, should I start topic to describe it, send it directly to patch tracker, or maybe I shouldn't send anything at all?

[oBFusCATed]

Btw. if I will prepare patch, should I start topic to describe it, send it directly to patch tracker, or maybe I shouldn't send anything at all?

What patch? Some other patch? Are you asking what is the accepted procedure for providing patches?

[p2rkw]

Yea, exactly.