Author Topic: debugger start/stop slow because of tabs  (Read 16335 times)

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5490
debugger start/stop slow because of tabs
« on: November 16, 2011, 11:43:52 pm »
This occurs both on trunk as on the debugger branch.

Build your application --> in the panel at the bottom the 'build log' has the focus. Now start the debugger and watch how a bunch of other tabs get the focus, one by one. The same occurs when stopping the debug sessions. This browsing through the different panels is extremely slow and unnecessary.

Such thing will bot happen eg when you run the eg valgrind plugin, then there's an immediate jump to the correct panel, and when valigrind's done and you 'build' then one have a direct jump to build tab.

Something for our debugger gurus ? ;-)  (trunk and branch)

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: debugger start/stop slow because of tabs
« Reply #1 on: November 17, 2011, 06:39:48 am »
Does this also happen, if you change the perspective manually to "Debugging" ("View -> Perspective -> Debugging") and also if you change back to the default perspective ?
Does it happen on windows or on linux ?

It might be related to the saving (and restoring) of the tabs visibility and order of the "Logs & others" tabs.
I can see it also, but it happens quite fast, but if it is related to saving/restoring the perspective, I can look into it.

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5490
Re: debugger start/stop slow because of tabs
« Reply #2 on: November 17, 2011, 06:56:55 am »
on one pc it seems to go 'acceptable slow' but on my work laptop, it is really slow (maybe it gets slower the longer CB is running ?).

Just tried the manual perspective change as you suggested on above mentioned 'pc', and it is the same as when the debugger started/stopped.

I think you are right it is perspective related, since sometimes it occurs to me by somewhere clicking (or an unwanted mini drag) that CB goes into 'minimal perspective' and it is also that slow.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: debugger start/stop slow because of tabs
« Reply #3 on: November 17, 2011, 07:27:22 am »
For me the perspective change takes a second and it is visible. I though it is slow, too.
It takes longer if I have more tabs open in the messages window.

I can see how the tabs are removed and then added, like an animation.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: debugger start/stop slow because of tabs
« Reply #4 on: November 18, 2011, 01:27:18 pm »
Seems to be a wxGTK issue (again), because it works instantly on my xp-system.

Please test the attached patch.

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: debugger start/stop slow because of tabs
« Reply #5 on: November 19, 2011, 10:17:59 am »
I'm testing it and I'll report if there are problems with it.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: debugger start/stop slow because of tabs
« Reply #6 on: November 19, 2011, 11:02:29 am »
It seems that closing the last tab in the "Log and others" crashes C::B
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5490
Re: debugger start/stop slow because of tabs
« Reply #7 on: November 19, 2011, 03:03:01 pm »
as far as the speed is concerned, this patch works marvelous :-)

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: debugger start/stop slow because of tabs
« Reply #8 on: November 20, 2011, 01:18:31 am »
It seems that closing the last tab in the "Log and others" crashes C::B
Should be fixed with the attached patch.

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9694
Re: debugger start/stop slow because of tabs
« Reply #9 on: November 20, 2011, 11:51:01 am »
Should be fixed with the attached patch.
A side note: Jens, your patches are really hard to apply on Windows. The first one didn't work at all, the second one had wrong line feeds (Linux) which crashes (!) the GnuWin32 patch executable on Windows (7 at least). I know this sucks in general, but for Windows, the right format seems as you did, but with CRLF linefeed. For the record...
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: https://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: https://wiki.codeblocks.org/index.php?title=FAQ

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: debugger start/stop slow because of tabs
« Reply #10 on: November 20, 2011, 11:58:15 am »
patch.exe is extremely buggy on windows.
What I use to apply patches is TortoiseSVN. It does a better job, but has a stupid interface.

p.s. you can use unix2dos to convert the line endings
p.p.s. you can use --binary to force it to apply the patch
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: debugger start/stop slow because of tabs
« Reply #11 on: November 20, 2011, 12:07:13 pm »
Should be fixed with the attached patch.
A side note: Jens, your patches are really hard to apply on Windows. The first one didn't work at all, the second one had wrong line feeds (Linux) which crashes (!) the GnuWin32 patch executable on Windows (7 at least). I know this sucks in general, but for Windows, the right format seems as you did, but with CRLF linefeed. For the record...
The CrLF-issue with patch.exe is a bug in my opinion.
But the patch(es) should work correctly with tortoiseSVN at least and most likely also with SmartSVN (they are convereted to tortoise understandable format).

Offline MortenMacFly

  • Administrator
  • Lives here!
  • *****
  • Posts: 9694
Re: debugger start/stop slow because of tabs
« Reply #12 on: November 20, 2011, 12:19:12 pm »
most likely also with SmartSVN (they are convereted to tortoise understandable format).
That might be, indeed - I'll try next time. ;-)
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: https://www.codeblocks.org/docs/main_codeblocks_en.html
C::B FAQ: https://wiki.codeblocks.org/index.php?title=FAQ

Offline oBFusCATed

  • Developer
  • Lives here!
  • *****
  • Posts: 13413
    • Travis build status
Re: debugger start/stop slow because of tabs
« Reply #13 on: November 21, 2011, 10:31:17 am »
The new patch doesn't crash, when the last tab is closed and changing perspectives is lightning fast :)
Let me test it for the next couple of days and if there are no problems, you can commit it:)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Offline killerbot

  • Administrator
  • Lives here!
  • *****
  • Posts: 5490
Re: debugger start/stop slow because of tabs
« Reply #14 on: November 26, 2011, 09:33:07 pm »
Jens, when will you commit this patch. I used it for more then a week now, all seems to be fine.