Author Topic: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.  (Read 23528 times)

Offline Cryogen

  • Regular
  • ***
  • Posts: 260
Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« on: May 21, 2010, 04:17:02 am »

 Hi Guys,

I have patched wxSmith to add wxAnimationCtrl and wxMediaCtrl. It's posted as patch 2998 on Berlios. Patch and images attached.
To use:

    * Apply the patch and copy the images to src\plugins\contrib\wxSmith\wxwidgets\icons.
    * Rebuild the contrib plugins workspace.
    * Run the update script in src\.

Cheers,

Cryo.


[attachment deleted by admin]

Offline seb_seb0

  • Almost regular
  • **
  • Posts: 166
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #1 on: May 30, 2010, 08:36:28 pm »
Hello,

I have tried to apply this patch against the new codeblocks release (10.5) and it does not work.
The message I receive from Tortoise SVN is:
   "Unknown line type at line 75"

Have you modified manually the patch file ?

Note: all your other patches have worked without problems (bitmap dialog in wxSmith, wxHyperlinkctrl, dialogs addition)

Thank you for your work !

Sebastien

Offline Cryogen

  • Regular
  • ***
  • Posts: 260
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #2 on: June 08, 2010, 04:33:54 pm »

 Hey Seb,

I have tried to apply this patch against the new codeblocks release (10.5) and it does not work.
The message I receive from Tortoise SVN is:
   "Unknown line type at line 75"

Have you modified manually the patch file ?

Yes, possibly. I can't recreate it separately, now, since all of the more recent changes are in my sandbox. That's a nuisance. I'll have to think about that one.

Note: all your other patches have worked without problems (bitmap dialog in wxSmith, wxHyperlinkctrl, dialogs addition)

Thank you for your work !

Sebastien

That's good to know, thanks, and no problem.

Cheers.

Offline Cryogen

  • Regular
  • ***
  • Posts: 260
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #3 on: June 08, 2010, 05:11:59 pm »
 Hi,

I regressed some files and recreated the patch. Please let me know how this one goes.

Thanks.


[attachment deleted by admin]
« Last Edit: June 08, 2010, 05:58:10 pm by Cryogen »

Offline Loaden

  • Lives here!
  • ****
  • Posts: 1014
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #4 on: June 08, 2010, 06:36:09 pm »
Great working!

Offline Cryogen

  • Regular
  • ***
  • Posts: 260
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #5 on: June 10, 2010, 07:30:52 pm »

Offline ZinnJonas

  • Multiple posting newcomer
  • *
  • Posts: 23
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #6 on: September 11, 2010, 01:35:23 pm »
Hi Cryogen,

your wxAnimationCtrl and wxMediaCtrl was added into the SVN version, but
in this version there are some mistakes.

Please finde endclosed my pruposle to correct the files:

Code
Index: Makefile.am
===================================================================
--- Makefile.am (revision 6578)
+++ Makefile.am (working copy)
@@ -77,6 +77,7 @@
 ./wxsglcanvas.cpp \
 ./wxshyperlinkctrl.cpp \
 ./wxsanimationctrl.cpp \
+./wxsmediactrl.cpp \
 ./wxsfindreplacedialog.cpp \
 ./wxsfontdialog.cpp \
 ./wxsmessagedialog.cpp \
@@ -167,6 +168,7 @@
 ./wxsglcanvas.h \
 ./wxshyperlinkctrl.h \
 ./wxsanimationctrl.h \
+./wxsmediactrl.h \
 ./wxsfindreplacedialog.h \
 ./wxsfontdialog.h \
 ./wxsmessagedialog.h \

also in the wxSmith.cbp;D

Code
Index: wxSmith.cbp
===================================================================
--- wxSmith.cbp (revision 6578)
+++ wxSmith.cbp (working copy)
@@ -528,10 +528,10 @@
  <Option target="wxSmithLib" />
  </Unit>
  <Unit filename="wxwidgets\defitems\wxsmediactrl.cpp">
- <Option target="&lt;{~None~}&gt;" />
+ <Option target="wxSmithLib" />
  </Unit>
  <Unit filename="wxwidgets\defitems\wxsmediactrl.h">
- <Option target="&lt;{~None~}&gt;" />
+ <Option target="wxSmithLib" />
  </Unit>
  <Unit filename="wxwidgets\defitems\wxsmenu.cpp">
  <Option target="wxSmithLib" />

So I hope this is the right place to post this;D

You did a good Job

Jonas


Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #7 on: September 11, 2010, 02:10:57 pm »
Hi Cryogen,

your wxAnimationCtrl and wxMediaCtrl was added into the SVN version, but
in this version there are some mistakes.

Please finde endclosed my pruposle to correct the files:

Code
Index: Makefile.am
===================================================================
--- Makefile.am (revision 6578)
+++ Makefile.am (working copy)
@@ -77,6 +77,7 @@
 ./wxsglcanvas.cpp \
 ./wxshyperlinkctrl.cpp \
 ./wxsanimationctrl.cpp \
+./wxsmediactrl.cpp \
 ./wxsfindreplacedialog.cpp \
 ./wxsfontdialog.cpp \
 ./wxsmessagedialog.cpp \
@@ -167,6 +168,7 @@
 ./wxsglcanvas.h \
 ./wxshyperlinkctrl.h \
 ./wxsanimationctrl.h \
+./wxsmediactrl.h \
 ./wxsfindreplacedialog.h \
 ./wxsfontdialog.h \
 ./wxsmessagedialog.h \

also in the wxSmith.cbp;D

Code
Index: wxSmith.cbp
===================================================================
--- wxSmith.cbp (revision 6578)
+++ wxSmith.cbp (working copy)
@@ -528,10 +528,10 @@
  <Option target="wxSmithLib" />
  </Unit>
  <Unit filename="wxwidgets\defitems\wxsmediactrl.cpp">
- <Option target="&lt;{~None~}&gt;" />
+ <Option target="wxSmithLib" />
  </Unit>
  <Unit filename="wxwidgets\defitems\wxsmediactrl.h">
- <Option target="&lt;{~None~}&gt;" />
+ <Option target="wxSmithLib" />
  </Unit>
  <Unit filename="wxwidgets\defitems\wxsmenu.cpp">
  <Option target="wxSmithLib" />

So I hope this is the right place to post this;D

You did a good Job

Jonas



That's not an error, wxMediaCtrl is currently not compiled in on linux, because it's missing on many distributions and leads to a compile-and/or link-time error therefore.

Offline ZinnJonas

  • Multiple posting newcomer
  • *
  • Posts: 23
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #8 on: September 11, 2010, 03:56:31 pm »
hi Jens,

thx for your reply.

I'm not using Linux, I'm running Win, with these changes the mediaCtrl runs perfektly well.

I'm using Win32 WX-2.8.11 with mingw-4.5.

Pls don't hesitate to post if you have any news.

Br
Jonas

Offline Cryogen

  • Regular
  • ***
  • Posts: 260
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #9 on: September 11, 2010, 07:09:07 pm »
hi Jens,

thx for your reply.

I'm not using Linux, I'm running Win, with these changes the mediaCtrl runs perfektly well.

I'm using Win32 WX-2.8.11 with mingw-4.5.

Pls don't hesitate to post if you have any news.

Br
Jonas

Hi there. I proposed making it conditional for Windows only, as it works fine here, too. How does that sound, Jens.

Cheers.


Offline Jenna

  • Administrator
  • Lives here!
  • *****
  • Posts: 7255
Re: Added wxAnimationCtrl and wxMediaCtrl to wxSmith.
« Reply #10 on: September 11, 2010, 11:54:54 pm »
The cause why I removed it from windows project-file also, was that I wanted to keep the versions in sync on all platforms.