Some "Log & others" problems

[oBFusCATed]

1. Closing pages in the notebook removes them from the drop down list and they can't be reopened
2. The order and the state of the tabs/pages is not remembered and I've to close the ones I don't need every time I start C::B
3. Build/Build messages are at the end of the notebook, which is very annoying

[Jenna]

1. Closing pages in the notebook removes them from the drop down list and they can't be reopened
2. The order and the state of the tabs/pages is not remembered and I've to close the ones I don't need every time I start C::B
3. Build/Build messages are at the end of the notebook, which is very annoying

1. Yes, they are not in dropdownlist, but can be reopened via context-menu ("Toggle -> ...")
2. Yes, it's not so easy to do this, because many of them are opened by plugins and the load-order can vary, and a closed/toggled logger is mostly automatically reopened if the owner tries to write into it.
3. Here they are the fifth and sixth logger of thirteen, but as written before it depends on load-order of the plugins.

Saving the state and order can be done on shutdown before unloading the plugins and loading the layout in CreateIDE() after CreateMenubar(), because it loads all plugins.
This would fix 2 and 3.
I will see if I find the time to look into it.

[Jenna]

I created a patch for 2 (can fix 3 automatically).

See http://forums.codeblocks.org/index.php/topic,12650.msg85768.html#msg85768 for details.

[oBFusCATed]

Jens: The patch (version 1, never tried v2, because I'm too lazy ) works very well, probably you could commit it?

Also, there is another problem, here are the steps to reproduce it:
1. Switch to "Build messages"
2. Right click and open the context menu
3. Left click and the context menu is opened at the position of the click

or

1. Switch to the "Thread search" tab, Thread search should be in list ctrl mode, have not tested the tree mode
2. Perform a search which should have some results
3. Right click on a result string to open the context menu
4. Click "Delete all items", the general context menu shows up

Tested on gentoo linux 64bit debuggers branch (but it is not related to the changes in it, I think)

[Jenna]

It's in trunk now (svn r6406) and will sooner or later be available in the debugger- and the cc-branch also, I think.

I don't have any of them at the moment, so I can not commit the changes soon.

[MortenMacFly]

It's in trunk now (svn r6406) and will sooner or later be available in the debugger- and the cc-branch also, I think.

Done that.

[oBFusCATed]

Debugger branch is broken

Code

/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp: In member function ‘int InfoPane::GetCurrentPage(bool&)’:
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:204: error: ‘num_pages’ was not declared in this scope
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:206: error: request for member ‘indexInNB’ in ‘((InfoPane*)this)->InfoPane::page.InfoPane::wxArrayOfPage::operator[](((size_t)ii))’, which is of non-class type ‘InfoPane::Page*’
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:208: error: request for member ‘islogger’ in ‘((InfoPane*)this)->InfoPane::page.InfoPane::wxArrayOfPage::operator[](((size_t)ii))’, which is of non-class type ‘InfoPane::Page*’
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp: In member function ‘Logger* InfoPane::GetLogger(int)’:
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:217: error: ‘num_pages’ was not declared in this scope
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:219: error: request for member ‘islogger’ in ‘((InfoPane*)this)->InfoPane::page.InfoPane::wxArrayOfPage::operator[](((size_t)index))’, which is of non-class type ‘InfoPane::Page*’
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:219: error: request for member ‘logger’ in ‘((InfoPane*)this)->InfoPane::page.InfoPane::wxArrayOfPage::operator[](((size_t)index))’, which is of non-class type ‘InfoPane::Page*’
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp: In member function ‘wxWindow* InfoPane::GetWindow(int)’:
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:223: error: ‘num_pages’ was not declared in this scope
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:225: error: request for member ‘islogger’ in ‘((InfoPane*)this)->InfoPane::page.InfoPane::wxArrayOfPage::operator[](((size_t)index))’, which is of non-class type ‘InfoPane::Page*’
/home/obfuscated/projects/codeblocks/brances/wxpropgrid_debugger/src/src/infopane.cpp:225: error: request for member ‘window’ in ‘((InfoPane*)this)->InfoPane::page.InfoPane::wxArrayOfPage::operator[](((size_t)index))’, which is of non-class type ‘InfoPane::Page*’

[MortenMacFly]

Debugger branch is broken

I've a patch for that but cannot commit for a while (no access to SVN).

[oBFusCATed]

Can you post it?

[Jenna]

Can you post it?

Please test this patch:

Code

--- tmp/tmp93xXnj-meld/infopane.cpp 
+++ home/jens/codeblocks-build/codeblocks.dbg/src/src/infopane.cpp 
@@ -200,29 +200,22 @@
 
 int InfoPane::GetCurrentPage(bool &is_logger)
 {
-    int page_index = GetSelection();
-    for (int ii = 0; ii < num_pages; ++ii)
-    {
-        if (page[ii].indexInNB == page_index)
-        {
-            is_logger = page[ii].islogger;
-            return ii;
-        }
-    }
-    return -1;
+    int i = GetPageIndexByWindow(GetPage(GetSelection()));
+    is_logger = page.Item(i)->islogger;
+    return (is_logger?i:-1);
 }
 
 Logger* InfoPane::GetLogger(int index)
 {
-    if (index < 0 || index > num_pages)
+    if (index < 0 || (size_t)index > page.GetCount())
         return NULL;
-    return page[index].islogger ? page[index].logger : NULL;
+    return page.Item(index)->islogger ? page.Item(index)->logger : NULL;
 }
 wxWindow* InfoPane::GetWindow(int index)
 {
-    if (index < 0 || index > num_pages)
+    if (index < 0 || (size_t)index > page.GetCount())
         return NULL;
-    return !page[index].islogger ? page[index].window : NULL;
+    return !page.Item(index)->islogger ? page.Item(index)->window : NULL;
 }
 
 void InfoPane::Show(size_t i)

[oBFusCATed]

Applied at my installed version... seems to work

[Jenna]

Applied at my installed version... seems to work

Committed (dbg-branch r6412) , thanks for testing.