New code completion remarks/issues

[ollydbg]

I just find a small bug.
When I first only the TESTING workplace, and only the symbol tree. When I double click on the tree item, no jumping was taken.

After I toggle or switch the editor page several times, the jumping works.

So, it seems the "First jump mechanism" was some problem.

[blueshake]

Maybe the parse has not been finished yet.

[ollydbg]

For the right valuetip on typedef.
patch:

Code

Index: src/plugins/codecompletion/parser/parserthread.cpp
===================================================================
--- src/plugins/codecompletion/parser/parserthread.cpp	(revision 5852)
+++ src/plugins/codecompletion/parser/parserthread.cpp	(working copy)
@@ -1765,6 +1765,7 @@
         {
             tdef->m_AncestorsString = ancestor;
             tdef->m_ActualType = ancestor;
+            tdef->m_Type = ancestor;
         }
         else
             tdef->m_ActualType = ancestor + args;

Yes, it works on the test code below:

Code

#include <iostream>
#include <iostream>
using namespace std;
std::vector<string> ssss;
#define  xxxxxxxxx 12e
typedef class qq
{
    int x;
    int y;
}eeee;
typedef unsigned int wwwwwwwww;
www!
int main()
{

    cout << "Hello world!" << endl;
    return 0;
}

[blueshake]

test codes:

Code

#include <iostream>

using namespace std;
struct qq
{
    int x;
    int y;
};
typedef qq (*ptr)(int a, int b);
ptr pp;
pp(3,3). --------not work.
int main()
{
    cout << "Hello world!" << endl;
    return 0;
}

Edit:
relative with these codes:

Code

        if (token.GetChar(0) == '(')
        {
            // function pointer (probably)
            is_function_pointer = true;
            if (peek.GetChar(0) == '(')
            {
                // typedef void (*dMessageFunction)(int errnum, const char *msg, va_list ap);
                // typedef void (MyClass::*Function)(int);

                // remove parentheses and keep everything after the dereferencing symbol
                token.RemoveLast();
                int pos = token.Find('*', true);
                if (pos != wxNOT_FOUND)
                {
                    typ << _T('(') << token.Mid(1, pos) << _T(')');
                    token.Remove(0, pos + 1);
                }
                else
                {
                    typ = _T("(*)");
                    token.Remove(0, 1); // remove opening parenthesis
                }
                args = peek;
                components.push(token);
            }
            else
            {
                // typedef void dMessageFunction (int errnum, const char *msg, va_list ap);

                typ = _T("(*)");
                // last component is already the name and this is the args
                args = token;
            }
            break;
        }

[ollydbg]

typedef qq (*ptr)(int a, int b);
ptr pp;
pp(3,3). --------not work.

But it seems the parser get the right token type. You can open the CC debug tool dialog.
see here:


and


So, I think the AI function in nativeparser.cpp has a bug to expand the "ptr".

[blueshake]

Dear ollydbg,
I think the actualtype should be qq,and the type should be qq(*), and the ancestor should be qq too,
for codes:

Code

typedef qq (*ptr)(int a, int b);

can be treat as

Code

typedef qq ptr;

and this maybe can fix the bug.

[ollydbg]

Dear ollydbg,
I think the actualtype should be qq,and the type should be qq(*), and the ancestor should be qq too,
for codes:

Code

typedef qq (*ptr)(int a, int b);

can be treat as

Code

typedef qq ptr;

and this maybe can fix the bug.

Good idea, I will try it .

[blueshake]

Do some modification on value tip.
patch:

Code

Index: src/plugins/codecompletion/parser/token.cpp
===================================================================
--- src/plugins/codecompletion/parser/token.cpp	(revision 5852)
+++ src/plugins/codecompletion/parser/token.cpp	(working copy)
@@ -126,15 +126,42 @@
 
 wxString Token::DisplayName() const
 {
-//    wxString result(_T(""));
-//    wxString parentname = GetParentName();
-//    if (!parentname.IsEmpty())
-//        result << parentname << _T("::");
-    wxString result = GetNamespace();
-    result << m_Name << m_Args;
-    if (!m_Type.IsEmpty())
-        result << _T(" : ") << m_Type;
-    return result;
+    wxString result;
+    if (m_TokenKind == tkClass)
+    {
+        result << _T("class ") << m_Name << _T(" {...}");
+        return result;
+    }
+    else if (m_TokenKind == tkNamespace)
+    {
+        result << _T("namespace ") << m_Name << _T(" {...}");
+        return result;
+    }
+    else if (m_TokenKind == tkEnum)
+    {
+        return result << _T("enum ") << m_Name << _T(" {...}");
+    }
+    else if (m_TokenKind == tkTypedef)
+    {
+        result << _T("typedef") ;
+        if (!m_Type.IsEmpty())
+            result << _T(" ") << m_Type;
+        result << _T(" ") << m_Name;
+        return result;
+    }
+    else if (m_TokenKind == tkPreprocessor)
+    {
+        result << _T("#define ") << m_Name << m_Args;
+        if(!m_Type.IsEmpty())
+            result << _T(" ") << m_Type;
+            return result;
+    }
+    else
+    {
+        if (!m_Type.IsEmpty())
+            result << m_Type << _T(" ");
+        return result << GetNamespace() << m_Name << m_Args;
+    }
 }
 
 Token* Token::GetParentToken()

[attachment deleted by admin]

[mmkider]

Hi,

In SVN 5840, code completion can pop up function paramter.
But SVN 5853, it's not.

What happen  ? or do I  some error thing  ? 

Code

int bbbbb(int cccccc)
{
                  //can't pop up cccccc
}

[ollydbg]

Hi,

In SVN 5840, code completion can pop up function paramter.
But SVN 5853, it's not.

What happen  ? or do I  some error thing  ? 

Code

int bbbbb(int cccccc)
{
                  //can't pop up cccccc
}

I can confirm this bug.
In the function body, if you enter cccc, then, there is no suggestion list "cccccc".

Need time to find the bug.

By the way, the code in nativeparser.cpp, such as

Code

// Start an Artificial Intelligence (!) sequence to gather all the matching tokens..
// The actual AI is in FindAIMatches() below...
size_t NativeParser::AI(TokenIdxSet& result,
                        cbEditor* editor,
                        Parser* parser,
                        const wxString& lineText,
                        bool noPartialMatch,
                        bool caseSensitive,
                        TokenIdxSet* search_scope,
                        int caretPos)

is really hard to read and understand for me.

[ollydbg]

I just write a simple test code:

Code

void zfunction(int abcdefg){
ab|         <---
;

};

Then I debug the CC under CB.

In codecompletion.cpp function int CodeCompletion::CodeComplete(), before line 602, the items was add correctly( which means "abcdefg"　was correctly added to the suggestion list wxstring array ).

But finally, there is not suggestion list output... I don't know why...)

Edit: line 639 and line 640 of codecompletion.cpp, this function run to an early exit.

Code

            if (items.GetCount() == 0)
                return -2;

[/s]

Edit
It seems the match result size is always "0"...

Also, I always meet the "gdb.exe" crash when debugging(TDM-MinGW + GDB 6.8, "evaluate the express under cursor" was checked. )  I think this problem is caused by the "mouse hovers on a complex statement", then the gdb can't evaluate the statement, so ,it crashes. )

Any more comments? Thanks.

[blueshake]

Dear ollydbg:
The function tokens search followed the below steps:
1.serach the function name the line stayed.
2.parse the function arguments and stored tokens in pTempTreepTree ,marked with temp.
3.parse the fucntion body and stored tokens in pTempTreepTree,marked with temp.
I guess we should check whether tokens(e.g. ccccc) is in the pTempTree, and make sure the pTempTree is searched.
should compare with last svn version,I guess it caused by the recent fixed.

[blueshake]

I can confirm it work in svn 5852.
see my screen shot.

[attachment deleted by admin]

[ollydbg]

Dear ollydbg:
The function tokens search followed the below steps:
1.serach the function name the line stayed.
2.parse the function arguments and stored tokens in pTempTree.
3.parse the fucntion body and stored tokens in pTempTree.
I guess we should check whether tokens(e.g. ccccc) in the pTempTree, and make sure the pTempTree is searched.
should compare with last svn version,I guess it caused by the recent fixed.

Thanks, but in which function takes these steps? I'm examining right now.

[ollydbg]

I can confirm it work in svn 5852.
see my screen shot.

Oh, this is a good catch, I was looking at the changes in nativeparser.cpp.
Now, it seems the bug is in other source files, because the newest nativeparser.cpp is rev 5849.

Wait:
It failed in rev 5852 of my working copy.